From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0363DC07E9D for ; Thu, 22 Jul 2021 03:36:45 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5947060FF4 for ; Thu, 22 Jul 2021 03:36:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5947060FF4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3D1E882991; Thu, 22 Jul 2021 05:36:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ZYmHBdmk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F41B380EEA; Thu, 22 Jul 2021 05:36:11 +0200 (CEST) Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 254A382956 for ; Thu, 22 Jul 2021 05:36:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-oi1-x22a.google.com with SMTP id s23so5149948oiw.12 for ; Wed, 21 Jul 2021 20:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PjBiac8BIYr1SAUpcGJmY+3DpJvgjxFW6BZonSNdwBk=; b=ZYmHBdmkU1ZG/o4KVRASW30Tj7fQyTB4zrZuf+IReFHnNK/Pis733ER2NY/0mRhYP3 y2v6b1gcT8dGkDC3/zrH2rwHYJ/Z6d7AajevKTjucmrHmPoWFUoKgYoCSXa7QTF1FwlJ ZkENbbNRF5uj2SAtbMz0Kkob/EvJax6iptNlE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PjBiac8BIYr1SAUpcGJmY+3DpJvgjxFW6BZonSNdwBk=; b=k3tEO+yRMvgpVcVkRacsR/ZUt9B/rvXE/CyXq0agKYwo5XosCYOe+k3D5r3gBSVoco YHxDyb9t8WvdLiNUxZ39ciw7135+O1IBEXaRSEH2ZpQAPuoWO1p3s2il+bgKUhnUJeuR RWbbyW969oEJFhg0L3kMvQixuHnhXQ58HI+ZDstb8H8IJjmyPTiQtCgtBrZKU4TDJC77 GisDwXqnNZ8gb+aJ/LjVx2MQ0G9ulLB8c5JUhpC9UDE9nWgefzD6AADbRtbGuLMIWOjC 4bGip7GOG7tIX49aEz/HXF/pP8PsmtaTzZm84nfoEVbyv3hFM23tegl1QAcxXycSFN+3 d7Jw== X-Gm-Message-State: AOAM533J199jXkbBEM/W+rJDKzx3u9E2uNPtk57JrJIjB91rkNOLaQR7 BX6wGFM8hJ2NkXZVRcpOQlbSuxPnE73B/q8C X-Google-Smtp-Source: ABdhPJxjhLc9Pwb9lTqRrtj5u/jvUK8g2PRS+UGOdvRIOhnsUoQnqeZD39pcTXTAI/l32/eCPl2bXQ== X-Received: by 2002:aca:c40a:: with SMTP id u10mr4347283oif.111.1626924962607; Wed, 21 Jul 2021 20:36:02 -0700 (PDT) Received: from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id c11sm5058257otm.37.2021.07.21.20.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 20:36:02 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Marek Vasut , Simon Glass Subject: [PATCH 4/5] doc: Fix up outdated moveconfig docs Date: Wed, 21 Jul 2021 21:35:52 -0600 Message-Id: <20210722033553.1588358-5-sjg@chromium.org> X-Mailer: git-send-email 2.32.0.402.g57bb445576-goog In-Reply-To: <20210722033553.1588358-1-sjg@chromium.org> References: <20210722033553.1588358-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean The examples here are a bit messed up since the command does not match the documentation. Use a different example instead. Signed-off-by: Simon Glass --- doc/develop/moveconfig.rst | 58 +++++++++++++++----------------------- 1 file changed, 22 insertions(+), 36 deletions(-) diff --git a/doc/develop/moveconfig.rst b/doc/develop/moveconfig.rst index aaa155e8c70..dcd4d927e40 100644 --- a/doc/develop/moveconfig.rst +++ b/doc/develop/moveconfig.rst @@ -144,50 +144,36 @@ This tool can help find such configs. To use it, first build a database:: Then try to query it:: - ./tools/moveconfig.py -i CONFIG_CMD_IRQ - CONFIG_CMD_IRQ found in 311/2384 defconfigs - 44 : CONFIG_SYS_FSL_ERRATUM_IFC_A002769 - 41 : CONFIG_SYS_FSL_ERRATUM_A007075 - 31 : CONFIG_SYS_FSL_DDR_VER_44 - 28 : CONFIG_ARCH_P1010 - 28 : CONFIG_SYS_FSL_ERRATUM_P1010_A003549 - 28 : CONFIG_SYS_FSL_ERRATUM_SEC_A003571 - 28 : CONFIG_SYS_FSL_ERRATUM_IFC_A003399 - 25 : CONFIG_SYS_FSL_ERRATUM_A008044 - 22 : CONFIG_ARCH_P1020 - 21 : CONFIG_SYS_FSL_DDR_VER_46 - 20 : CONFIG_MAX_PIRQ_LINKS - 20 : CONFIG_HPET_ADDRESS - 20 : CONFIG_X86 - 20 : CONFIG_PCIE_ECAM_SIZE - 20 : CONFIG_IRQ_SLOT_COUNT - 20 : CONFIG_I8259_PIC - 20 : CONFIG_CPU_ADDR_BITS - 20 : CONFIG_RAMBASE - 20 : CONFIG_SYS_FSL_ERRATUM_A005871 - 20 : CONFIG_PCIE_ECAM_BASE - 20 : CONFIG_X86_TSC_TIMER - 20 : CONFIG_I8254_TIMER - 20 : CONFIG_CMD_GETTIME - 19 : CONFIG_SYS_FSL_ERRATUM_A005812 - 18 : CONFIG_X86_RUN_32BIT - 17 : CONFIG_CMD_CHIP_CONFIG - ... - -This shows a list of config options which might imply CONFIG_CMD_EEPROM along + ./tools/moveconfig.py -i CONFIG_I8042_KEYB + CONFIG_I8042_KEYB found in 33/5155 defconfigs + 28 : CONFIG_X86 + 28 : CONFIG_SA_PCIEX_LENGTH + 28 : CONFIG_HPET_ADDRESS + 28 : CONFIG_MAX_PIRQ_LINKS + 28 : CONFIG_I8254_TIMER + 28 : CONFIG_I8259_PIC + 28 : CONFIG_RAMBASE + 28 : CONFIG_IRQ_SLOT_COUNT + 28 : CONFIG_PCIE_ECAM_SIZE + 28 : CONFIG_APIC + ... + +This shows a list of config options which might imply CONFIG_I8042_KEYB along with how many defconfigs they cover. From this you can see that CONFIG_X86 -implies CONFIG_CMD_EEPROM. Therefore, instead of adding CONFIG_CMD_EEPROM to +generally implies CONFIG_I8042_KEYB but not always (28 out of 35). Therefore, +instead of adding CONFIG_I8042_KEYB to the defconfig of every x86 board, you could add a single imply line to the -Kconfig file: +Kconfig file:: config X86 bool "x86 architecture" ... imply CMD_EEPROM -That will cover 20 defconfigs. Many of the options listed are not suitable as -they are not related. E.g. it would be odd for CONFIG_CMD_GETTIME to imply -CMD_EEPROM. +That will cover 28 defconfigs and you can perhaps find another condition that +indicates that CONFIG_I8042_KEYB is not needed for the remaining 5 boards. Many +of the options listed are not suitable as they are not related. E.g. it would be +odd for CONFIG_RAMBASE to imply CONFIG_I8042_KEYB. Using this search you can reduce the size of moveconfig patches. -- 2.32.0.402.g57bb445576-goog