All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Jani Nikula <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/bios: Fix ports mask
Date: Thu, 22 Jul 2021 02:05:34 -0400	[thread overview]
Message-ID: <20210722060534.mbbicupeecihgyww@ldmartin-desk2> (raw)
In-Reply-To: <20210721220023.268194-1-rodrigo.vivi@intel.com>

On Wed, Jul 21, 2021 at 06:00:23PM -0400, Rodrigo Vivi wrote:
>PORT_A to PORT_F are regular integers defined in the enum port,
>while for_each_port_masked requires a bit mask for the ports.
>
>Current given mask: 0b111
>Desired mask: 0b111111
>
>I noticed this while Christoph was reporting a bug found on headless
>GVT configuration which bisect blamed commit 3ae04c0c7e63 ("drm/i915/bios:
>limit default outputs to ports A through F")
>
>Cc: Christoph Hellwig <hch@infradead.org>
>Fixes: 3ae04c0c7e63 ("drm/i915/bios: limit default outputs to ports A through F")
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>Cc: Jani Nikula <jani.nikula@intel.com>

humn.. something wrong with your git setup (maybe you have --suppress-cc
set?). Because people mentioned here were not actually Cc'ed. Adding
them.

> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

thanks
Lucas De Marchi


>---
> drivers/gpu/drm/i915/display/intel_bios.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>index 5b6922e28ef2..8bbeb5978bf7 100644
>--- a/drivers/gpu/drm/i915/display/intel_bios.c
>+++ b/drivers/gpu/drm/i915/display/intel_bios.c
>@@ -2166,7 +2166,8 @@ static void
> init_vbt_missing_defaults(struct drm_i915_private *i915)
> {
> 	enum port port;
>-	int ports = PORT_A | PORT_B | PORT_C | PORT_D | PORT_E | PORT_F;
>+	int ports = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | \
>+		    BIT(PORT_D) | BIT(PORT_E) | BIT(PORT_F);
>
> 	if (!HAS_DDI(i915) && !IS_CHERRYVIEW(i915))
> 		return;
>-- 
>2.31.1
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-07-22  6:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 22:00 [Intel-gfx] [PATCH] drm/i915/bios: Fix ports mask Rodrigo Vivi
2021-07-21 23:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-07-21 23:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-22  5:47 ` [Intel-gfx] [PATCH] " Souza, Jose
2021-07-22  5:58 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2021-07-22  6:05 ` Lucas De Marchi [this message]
2021-07-22  7:22   ` [Intel-gfx] [PATCH] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210722060534.mbbicupeecihgyww@ldmartin-desk2 \
    --to=lucas.demarchi@intel.com \
    --cc=hch@infradead.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.