From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E8EC63793 for ; Thu, 22 Jul 2021 10:07:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF0D461249 for ; Thu, 22 Jul 2021 10:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231355AbhGVJ0X (ORCPT ); Thu, 22 Jul 2021 05:26:23 -0400 Received: from mga11.intel.com ([192.55.52.93]:23475 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbhGVJ0V (ORCPT ); Thu, 22 Jul 2021 05:26:21 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10052"; a="208496670" X-IronPort-AV: E=Sophos;i="5.84,260,1620716400"; d="asc'?scan'208";a="208496670" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2021 03:06:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,260,1620716400"; d="asc'?scan'208";a="433069587" Received: from zhen-hp.sh.intel.com (HELO zhen-hp) ([10.239.160.143]) by fmsmga007.fm.intel.com with ESMTP; 22 Jul 2021 03:06:54 -0700 Date: Thu, 22 Jul 2021 17:45:16 +0800 From: Zhenyu Wang To: Christoph Hellwig Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Zhenyu Wang , Zhi Wang , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: refactor the i915 GVT support Message-ID: <20210722094516.GQ13928@zhen-hp.sh.intel.com> Reply-To: Zhenyu Wang References: <20210721155355.173183-1-hch@lst.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wjoFZxbW4tu+iR6v" Content-Disposition: inline In-Reply-To: <20210721155355.173183-1-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wjoFZxbW4tu+iR6v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021.07.21 17:53:34 +0200, Christoph Hellwig wrote: > Hi all, >=20 > the GVT code in the i915 is a bit of a mess right now due to strange > abstractions and lots of indirect calls. This series refactors various > bits to clean that up. The main user visible change is that almost all > of the GVT code moves out of the main i915 driver and into the kvmgt > module. > The reason we isolated hypervisor specific code from core vgpu emulation is to make multiple hypervisor support possible. Yes, we do have Xen support but never got way into upstream...And we also have third party hypervisors which leverage gvt function through current hypervisor interface. Sorry I may not have more time to check in details for now, but some of them look fine to me. I'll review more after vacation or let Zhi check d= etails. Thanks! > Tested on my Thinkpad with a Kaby Lake CPU and integrated graphics. >=20 > Git tree: >=20 > git://git.infradead.org/users/hch/misc.git i915-gvt >=20 > Gitweb: >=20 > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/i915-= gvt >=20 > Diffstat: > b/drivers/gpu/drm/i915/Kconfig | 31=20 > b/drivers/gpu/drm/i915/Makefile | 30=20 > b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4=20 > b/drivers/gpu/drm/i915/gvt/cfg_space.c | 89 -- > b/drivers/gpu/drm/i915/gvt/cmd_parser.c | 4=20 > b/drivers/gpu/drm/i915/gvt/dmabuf.c | 36=20 > b/drivers/gpu/drm/i915/gvt/execlist.c | 12=20 > b/drivers/gpu/drm/i915/gvt/gtt.c | 55 - > b/drivers/gpu/drm/i915/gvt/gvt.c | 100 -- > b/drivers/gpu/drm/i915/gvt/gvt.h | 132 ++- > b/drivers/gpu/drm/i915/gvt/interrupt.c | 38 - > b/drivers/gpu/drm/i915/gvt/kvmgt.c | 634 ++++------= ------- > b/drivers/gpu/drm/i915/gvt/mmio.c | 4=20 > b/drivers/gpu/drm/i915/gvt/opregion.c | 148 --- > b/drivers/gpu/drm/i915/gvt/page_track.c | 8=20 > b/drivers/gpu/drm/i915/gvt/scheduler.c | 37=20 > b/drivers/gpu/drm/i915/gvt/trace.h | 2=20 > b/drivers/gpu/drm/i915/gvt/vgpu.c | 22=20 > b/drivers/gpu/drm/i915/i915_drv.h | 7=20 > b/drivers/gpu/drm/i915/i915_params.c | 2=20 > b/drivers/gpu/drm/i915/intel_gvt.c | 64 + > b/drivers/gpu/drm/i915/intel_gvt.h | 4=20 > drivers/gpu/drm/i915/gvt/Makefile | 9=20 > drivers/gpu/drm/i915/gvt/hypercall.h | 82 -- > drivers/gpu/drm/i915/gvt/mpt.h | 400 ---------- > 25 files changed, 541 insertions(+), 1413 deletions(-) --wjoFZxbW4tu+iR6v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCYPk+JAAKCRCxBBozTXgY J09VAJ9C5w8OkOxQaT+Hh6GRuwyrHlKVPgCfR2B56jaNxNaxyz+943xRn2xdLCo= =enIC -----END PGP SIGNATURE----- --wjoFZxbW4tu+iR6v-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35467C63797 for ; Thu, 22 Jul 2021 10:07:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB0F86124B for ; Thu, 22 Jul 2021 10:06:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB0F86124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E4116EA2E; Thu, 22 Jul 2021 10:06:59 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C813F6EA2A; Thu, 22 Jul 2021 10:06:57 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10052"; a="272727227" X-IronPort-AV: E=Sophos;i="5.84,260,1620716400"; d="asc'?scan'208";a="272727227" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2021 03:06:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,260,1620716400"; d="asc'?scan'208";a="433069587" Received: from zhen-hp.sh.intel.com (HELO zhen-hp) ([10.239.160.143]) by fmsmga007.fm.intel.com with ESMTP; 22 Jul 2021 03:06:54 -0700 Date: Thu, 22 Jul 2021 17:45:16 +0800 From: Zhenyu Wang To: Christoph Hellwig Subject: Re: refactor the i915 GVT support Message-ID: <20210722094516.GQ13928@zhen-hp.sh.intel.com> References: <20210721155355.173183-1-hch@lst.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wjoFZxbW4tu+iR6v" Content-Disposition: inline In-Reply-To: <20210721155355.173183-1-hch@lst.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Zhenyu Wang Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rodrigo Vivi , intel-gvt-dev@lists.freedesktop.org, Zhi Wang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --wjoFZxbW4tu+iR6v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021.07.21 17:53:34 +0200, Christoph Hellwig wrote: > Hi all, >=20 > the GVT code in the i915 is a bit of a mess right now due to strange > abstractions and lots of indirect calls. This series refactors various > bits to clean that up. The main user visible change is that almost all > of the GVT code moves out of the main i915 driver and into the kvmgt > module. > The reason we isolated hypervisor specific code from core vgpu emulation is to make multiple hypervisor support possible. Yes, we do have Xen support but never got way into upstream...And we also have third party hypervisors which leverage gvt function through current hypervisor interface. Sorry I may not have more time to check in details for now, but some of them look fine to me. I'll review more after vacation or let Zhi check d= etails. Thanks! > Tested on my Thinkpad with a Kaby Lake CPU and integrated graphics. >=20 > Git tree: >=20 > git://git.infradead.org/users/hch/misc.git i915-gvt >=20 > Gitweb: >=20 > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/i915-= gvt >=20 > Diffstat: > b/drivers/gpu/drm/i915/Kconfig | 31=20 > b/drivers/gpu/drm/i915/Makefile | 30=20 > b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4=20 > b/drivers/gpu/drm/i915/gvt/cfg_space.c | 89 -- > b/drivers/gpu/drm/i915/gvt/cmd_parser.c | 4=20 > b/drivers/gpu/drm/i915/gvt/dmabuf.c | 36=20 > b/drivers/gpu/drm/i915/gvt/execlist.c | 12=20 > b/drivers/gpu/drm/i915/gvt/gtt.c | 55 - > b/drivers/gpu/drm/i915/gvt/gvt.c | 100 -- > b/drivers/gpu/drm/i915/gvt/gvt.h | 132 ++- > b/drivers/gpu/drm/i915/gvt/interrupt.c | 38 - > b/drivers/gpu/drm/i915/gvt/kvmgt.c | 634 ++++------= ------- > b/drivers/gpu/drm/i915/gvt/mmio.c | 4=20 > b/drivers/gpu/drm/i915/gvt/opregion.c | 148 --- > b/drivers/gpu/drm/i915/gvt/page_track.c | 8=20 > b/drivers/gpu/drm/i915/gvt/scheduler.c | 37=20 > b/drivers/gpu/drm/i915/gvt/trace.h | 2=20 > b/drivers/gpu/drm/i915/gvt/vgpu.c | 22=20 > b/drivers/gpu/drm/i915/i915_drv.h | 7=20 > b/drivers/gpu/drm/i915/i915_params.c | 2=20 > b/drivers/gpu/drm/i915/intel_gvt.c | 64 + > b/drivers/gpu/drm/i915/intel_gvt.h | 4=20 > drivers/gpu/drm/i915/gvt/Makefile | 9=20 > drivers/gpu/drm/i915/gvt/hypercall.h | 82 -- > drivers/gpu/drm/i915/gvt/mpt.h | 400 ---------- > 25 files changed, 541 insertions(+), 1413 deletions(-) --wjoFZxbW4tu+iR6v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCYPk+JAAKCRCxBBozTXgY J09VAJ9C5w8OkOxQaT+Hh6GRuwyrHlKVPgCfR2B56jaNxNaxyz+943xRn2xdLCo= =enIC -----END PGP SIGNATURE----- --wjoFZxbW4tu+iR6v-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A3CC6377D for ; Thu, 22 Jul 2021 10:06:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76BAC6124B for ; Thu, 22 Jul 2021 10:06:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76BAC6124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 11E3E6EBD0; Thu, 22 Jul 2021 10:06:59 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C813F6EA2A; Thu, 22 Jul 2021 10:06:57 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10052"; a="272727227" X-IronPort-AV: E=Sophos;i="5.84,260,1620716400"; d="asc'?scan'208";a="272727227" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2021 03:06:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,260,1620716400"; d="asc'?scan'208";a="433069587" Received: from zhen-hp.sh.intel.com (HELO zhen-hp) ([10.239.160.143]) by fmsmga007.fm.intel.com with ESMTP; 22 Jul 2021 03:06:54 -0700 Date: Thu, 22 Jul 2021 17:45:16 +0800 From: Zhenyu Wang To: Christoph Hellwig Message-ID: <20210722094516.GQ13928@zhen-hp.sh.intel.com> References: <20210721155355.173183-1-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20210721155355.173183-1-hch@lst.de> Subject: Re: [Intel-gfx] refactor the i915 GVT support X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Zhenyu Wang Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org Content-Type: multipart/mixed; boundary="===============1480107282==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --===============1480107282== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wjoFZxbW4tu+iR6v" Content-Disposition: inline --wjoFZxbW4tu+iR6v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021.07.21 17:53:34 +0200, Christoph Hellwig wrote: > Hi all, >=20 > the GVT code in the i915 is a bit of a mess right now due to strange > abstractions and lots of indirect calls. This series refactors various > bits to clean that up. The main user visible change is that almost all > of the GVT code moves out of the main i915 driver and into the kvmgt > module. > The reason we isolated hypervisor specific code from core vgpu emulation is to make multiple hypervisor support possible. Yes, we do have Xen support but never got way into upstream...And we also have third party hypervisors which leverage gvt function through current hypervisor interface. Sorry I may not have more time to check in details for now, but some of them look fine to me. I'll review more after vacation or let Zhi check d= etails. Thanks! > Tested on my Thinkpad with a Kaby Lake CPU and integrated graphics. >=20 > Git tree: >=20 > git://git.infradead.org/users/hch/misc.git i915-gvt >=20 > Gitweb: >=20 > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/i915-= gvt >=20 > Diffstat: > b/drivers/gpu/drm/i915/Kconfig | 31=20 > b/drivers/gpu/drm/i915/Makefile | 30=20 > b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4=20 > b/drivers/gpu/drm/i915/gvt/cfg_space.c | 89 -- > b/drivers/gpu/drm/i915/gvt/cmd_parser.c | 4=20 > b/drivers/gpu/drm/i915/gvt/dmabuf.c | 36=20 > b/drivers/gpu/drm/i915/gvt/execlist.c | 12=20 > b/drivers/gpu/drm/i915/gvt/gtt.c | 55 - > b/drivers/gpu/drm/i915/gvt/gvt.c | 100 -- > b/drivers/gpu/drm/i915/gvt/gvt.h | 132 ++- > b/drivers/gpu/drm/i915/gvt/interrupt.c | 38 - > b/drivers/gpu/drm/i915/gvt/kvmgt.c | 634 ++++------= ------- > b/drivers/gpu/drm/i915/gvt/mmio.c | 4=20 > b/drivers/gpu/drm/i915/gvt/opregion.c | 148 --- > b/drivers/gpu/drm/i915/gvt/page_track.c | 8=20 > b/drivers/gpu/drm/i915/gvt/scheduler.c | 37=20 > b/drivers/gpu/drm/i915/gvt/trace.h | 2=20 > b/drivers/gpu/drm/i915/gvt/vgpu.c | 22=20 > b/drivers/gpu/drm/i915/i915_drv.h | 7=20 > b/drivers/gpu/drm/i915/i915_params.c | 2=20 > b/drivers/gpu/drm/i915/intel_gvt.c | 64 + > b/drivers/gpu/drm/i915/intel_gvt.h | 4=20 > drivers/gpu/drm/i915/gvt/Makefile | 9=20 > drivers/gpu/drm/i915/gvt/hypercall.h | 82 -- > drivers/gpu/drm/i915/gvt/mpt.h | 400 ---------- > 25 files changed, 541 insertions(+), 1413 deletions(-) --wjoFZxbW4tu+iR6v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCYPk+JAAKCRCxBBozTXgY J09VAJ9C5w8OkOxQaT+Hh6GRuwyrHlKVPgCfR2B56jaNxNaxyz+943xRn2xdLCo= =enIC -----END PGP SIGNATURE----- --wjoFZxbW4tu+iR6v-- --===============1480107282== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1480107282==--