From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77EA8C63793 for ; Thu, 22 Jul 2021 13:01:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6464860698 for ; Thu, 22 Jul 2021 13:01:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232070AbhGVMU7 (ORCPT ); Thu, 22 Jul 2021 08:20:59 -0400 Received: from verein.lst.de ([213.95.11.211]:34079 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232056AbhGVMUw (ORCPT ); Thu, 22 Jul 2021 08:20:52 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4EF0468BFE; Thu, 22 Jul 2021 15:01:17 +0200 (CEST) Date: Thu, 22 Jul 2021 15:01:17 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, Arnd Bergmann , "James E.J. Bottomley" , Al Viro , Anton Ivanov , Brian Cain , Chris Zankel , Christian Borntraeger , Christoph Hellwig , Guo Ren , Heiko Carstens , Helge Deller , Jeff Dike , Linus Walleij , Max Filippov , Michal Simek , Richard Weinberger , Thomas Bogendoerfer , Vasily Gorbik , Vineet Gupta , Yoshinori Sato , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, uclinux-h8-devel@lists.sourceforge.jp Subject: Re: [PATCH v3 5/9] csky: use generic strncpy/strnlen from_user Message-ID: <20210722130117.GE26225@lst.de> References: <20210722124814.778059-1-arnd@kernel.org> <20210722124814.778059-6-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722124814.778059-6-arnd@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Thu, Jul 22, 2021 at 02:48:10PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Remove the csky implemenation of strncpy/strnlen and instead use the > generic versions. The csky version is fairly slow because it always does > byte accesses even for aligned data, and it lacks a checks for > user_addr_max(). Looks good, Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9962C63793 for ; Thu, 22 Jul 2021 13:34:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9896F61289 for ; Thu, 22 Jul 2021 13:34:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9896F61289 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bBZ4KZexSM9oviSjrySAZmOe4yNaJcaTtsF1sA+hecU=; b=lJpfJKkm2g1Hxy oRBH2X+BbKV4BHt3mkW1jpYV2Mupc7PQfChE1VzthIjAOgjU2En2mBep5fpsZgEgEKroL6FHw1k54 nRM7WoKcbDcCBkFYX6hWwIzmH3fqa1yerHHMMpqxa+UMS+uxdflWiNdyR3ntZi1CfFxBK5c1za9iJ HXj8WFu0cXTAIODK6ArTKZqFZb/c6Gn9uZY9KKQ3rPVyPRwfO61yCbr4ssFlaW1KGFCA3g9toPPh6 CtAGM3FgI8+4YzNxGtIzcQEtjlpa/hTcxOpjiSYU8zbz7ULLmvd1lyFHfdGjd0e5WhAyJPWqBEhmH +GVIgsacMlVI4tMXbQlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6Yq8-001ggy-MU; Thu, 22 Jul 2021 13:34:16 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6YKF-001Zmh-Ep; Thu, 22 Jul 2021 13:01:20 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4EF0468BFE; Thu, 22 Jul 2021 15:01:17 +0200 (CEST) Date: Thu, 22 Jul 2021 15:01:17 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, Arnd Bergmann , "James E.J. Bottomley" , Al Viro , Anton Ivanov , Brian Cain , Chris Zankel , Christian Borntraeger , Christoph Hellwig , Guo Ren , Heiko Carstens , Helge Deller , Jeff Dike , Linus Walleij , Max Filippov , Michal Simek , Richard Weinberger , Thomas Bogendoerfer , Vasily Gorbik , Vineet Gupta , Yoshinori Sato , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, uclinux-h8-devel@lists.sourceforge.jp Subject: Re: [PATCH v3 5/9] csky: use generic strncpy/strnlen from_user Message-ID: <20210722130117.GE26225@lst.de> References: <20210722124814.778059-1-arnd@kernel.org> <20210722124814.778059-6-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210722124814.778059-6-arnd@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_060119_711454_F3AC6634 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Thu, Jul 22, 2021 at 02:48:10PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Remove the csky implemenation of strncpy/strnlen and instead use the > generic versions. The csky version is fairly slow because it always does > byte accesses even for aligned data, and it lacks a checks for > user_addr_max(). Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 22 Jul 2021 13:01:17 +0000 Subject: Re: [PATCH v3 5/9] csky: use generic strncpy/strnlen from_user Message-Id: <20210722130117.GE26225@lst.de> List-Id: References: <20210722124814.778059-1-arnd@kernel.org> <20210722124814.778059-6-arnd@kernel.org> In-Reply-To: <20210722124814.778059-6-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, Arnd Bergmann , "James E.J. Bottomley" , Al Viro , Anton Ivanov , Brian Cain , Chris Zankel , Christian Borntraeger , Christoph Hellwig , Guo Ren , Heiko Carstens , Helge Deller , Jeff Dike , Linus Walleij , Max Filippov , Michal Simek , Richard Weinberger , Thomas Bogendoerfer , Vasily Gorbik , Vineet Gupta , Yoshinori Sato , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, uclinux-h8-devel@lists.sourceforge.jp On Thu, Jul 22, 2021 at 02:48:10PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Remove the csky implemenation of strncpy/strnlen and instead use the > generic versions. The csky version is fairly slow because it always does > byte accesses even for aligned data, and it lacks a checks for > user_addr_max(). Looks good, Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3 5/9] csky: use generic strncpy/strnlen from_user Date: Thu, 22 Jul 2021 15:01:17 +0200 Message-ID: <20210722130117.GE26225@lst.de> References: <20210722124814.778059-1-arnd@kernel.org> <20210722124814.778059-6-arnd@kernel.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20210722124814.778059-6-arnd@kernel.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, Arnd Bergmann , "James E.J. Bottomley" , Al Viro , Anton Ivanov , Brian Cain , Chris Zankel , Christian Borntraeger , Christoph Hellwig , Guo Ren , Heiko Carstens , Helge Deller , Jeff Dike , Linus Walleij , Max Filippov , Michal Simek , Richard Weinberger , Thomas Bogendoerfer , Vasily Gorbik , Vineet Gupta , Yoshinori On Thu, Jul 22, 2021 at 02:48:10PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Remove the csky implemenation of strncpy/strnlen and instead use the > generic versions. The csky version is fairly slow because it always does > byte accesses even for aligned data, and it lacks a checks for > user_addr_max(). Looks good, Reviewed-by: Christoph Hellwig