From: "email@example.com" <firstname.lastname@example.org> To: Trond Myklebust <email@example.com> Cc: "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com> Subject: Re: [PATCH 3/3] nfs: don't allow reexport reclaims Date: Thu, 22 Jul 2021 10:34:23 -0400 [thread overview] Message-ID: <20210722143423.GB4552@fieldses.org> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, Jun 14, 2021 at 09:03:35PM +0000, Trond Myklebust wrote: > I want to avoid the kind of issues we've be met with earlier when > mixing types just because they happened to be integer valued. > > We introduced the mixing of POSIX/Linux and NFS errors in the NFS > client back in the 1990s, and that was a mistake that we're still > paying for. For instance, the value ERR_PTR(-NFSERR_NO_GRACE) will be > happily declared as a valid pointer by the IS_ERR() test, and every so > often we find an Oops around that issue because someone used the return > value from a function that they thought was POSIX/Linux error valued, > because it usually is returning POSIX errors. I did this, by the way, but also ran across a couple more bugs in testing. At this point I've got connectathon locking tests passing on a re-export--I need to do a little more cleanup and then I'll repost. --b.
prev parent reply other threads:[~2021-07-22 14:34 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-14 14:48 [PATCH 0/3] reexport lock fixes J. Bruce Fields 2021-06-14 14:48 ` [PATCH 1/3] nfs: don't atempt blocking locks on nfs reexports J. Bruce Fields 2021-06-14 14:48 ` [PATCH 2/3] lockd: lockd server-side shouldn't set fl_ops J. Bruce Fields 2021-06-14 14:48 ` [PATCH 3/3] nfs: don't allow reexport reclaims J. Bruce Fields 2021-06-14 14:56 ` Trond Myklebust 2021-06-14 19:34 ` J. Bruce Fields 2021-06-14 19:53 ` Trond Myklebust 2021-06-14 20:03 ` bfields 2021-06-14 21:03 ` Trond Myklebust 2021-07-22 14:34 ` bfields [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210722143423.GB4552@fieldses.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 3/3] nfs: don'\''t allow reexport reclaims' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.