From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F023AC63793 for ; Thu, 22 Jul 2021 15:26:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31EB1613B2 for ; Thu, 22 Jul 2021 15:26:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31EB1613B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5EB6C82BAA; Thu, 22 Jul 2021 17:26:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="TZiW/Ve8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CCC5D82BE7; Thu, 22 Jul 2021 17:26:29 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CE7AC829F8 for ; Thu, 22 Jul 2021 17:26:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id k9so4476974qtx.3 for ; Thu, 22 Jul 2021 08:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ce9hxbbcWSpm9G0B7dGQgZqeeafqS05D3oEl69vv1Mo=; b=TZiW/Ve8e4T9UB+uaX2cJSqqBqG1KKlkEVGyDRwZ0CddOSLvXi+4HhIyWDizUSD/gu KgVDEghAR5zBrCxgve51cM46Z8jEqCHl+UYWlIaU3JS9wdeQkxVJFrLtquwDRNAtYfY4 9ACf23+YhSeQvO1sQjedL1KmcDEWnKDuRGiFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ce9hxbbcWSpm9G0B7dGQgZqeeafqS05D3oEl69vv1Mo=; b=Ax/ijbqMNRemqQIw1ztoLCdi8NGn6DLAtcFcCdVDMbYURAOw3qDm2MDu6Trqskv2zy 6BAyAiM3effsACeSi76AO7lxskLua80SvPsrigkh4MXEYuVqhIDyOBaNvnnQ61qZTGG3 QSINdKW23JwWl+2zsFa2cZIiXGpSUhhpDUZ+bSZrGn3N34zQbkS50lTWe3/CdtFyG4lP LvpccmT2vU5srJKGUeCQhrb7lxQzhUsQEqGxEqO+ttpU5+qpztOnVflf2+qGD+SGGxBy BPL+bL93s/solsT04edkjf90Gwwuz9c6e9Xbgtf6oVh551fLc9h6EzsCaLIn+KKXp0ks L0AQ== X-Gm-Message-State: AOAM531NZ1NJMpvaSFUOCYWyWb3cxNEEklYWfY/ByAZ17RNtZBJL8D+l cE1W6LgxhMjLt6xeYzTc62JJAg== X-Google-Smtp-Source: ABdhPJye/lEiosCTEdET46ggrlon2zx3rIKT4rFuZa1xPdH9pJWzFqN3GoFSh5E4TKmGZa8/CxDIYQ== X-Received: by 2002:a05:622a:549:: with SMTP id m9mr234849qtx.248.1626967585672; Thu, 22 Jul 2021 08:26:25 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9c9f-331b-6244-0ec0.res6.spectrum.com. [2603:6081:7b01:cbda:9c9f:331b:6244:ec0]) by smtp.gmail.com with ESMTPSA id x125sm12943139qkd.8.2021.07.22.08.26.24 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Jul 2021 08:26:24 -0700 (PDT) Date: Thu, 22 Jul 2021 11:26:22 -0400 From: Tom Rini To: Zhiqiang Hou , Michael Walle , Heinrich Schuchardt Cc: u-boot@lists.denx.de, priyanka.jain@nxp.com Subject: Re: [PATCH] configs: layerscape: Disable the EFI_LOADER feature Message-ID: <20210722152622.GY9379@bill-the-cat> References: <20210722062559.21188-1-Zhiqiang.Hou@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="arh1ZL78woflSoTn" Content-Disposition: inline In-Reply-To: <20210722062559.21188-1-Zhiqiang.Hou@nxp.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --arh1ZL78woflSoTn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 22, 2021 at 02:25:59PM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang >=20 > The feature BOOTENV_SHARED_EFI is not supported on layerscape > boards, it didn't result kernel boot crash previously since > there isn't the efi/boot/"BOOTEFI_NAME" and it skip calling of > 'boot_efi_binary'. >=20 > But since the commit f3866909e350 ("distro_bootcmd: call EFI > bootmgr even without having /EFI/boot"), it will cause kernel > boot crash as there isn't a valid fdt_addr and it finially uses > the device tree blob of U-Boot and further cause errors. >=20 > As this feature is enabled by default for armv7 and armv8, so > disable it explicitly to avoid calling the 'scan_dev_for_efi'. I'm not thrilled with this. Why isn't the solution to get and keep in sync the device trees, so that the tree U-Boot has is valid for the kernel? I'm also open to discussing f3866909e350 more. But I'm really opposed to disabling EFI_LOADER on modern platforms as that will make adoption of U-Boot in device harder I feel. --=20 Tom --arh1ZL78woflSoTn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD5jhcACgkQFHw5/5Y0 tyxk/Qv9FyJoCSvl2cUSw7mdP3L/uv/gX9I5v8t2c2R+5EUiUgabb73v8sQ+B++f GVBfSHQfyEoEIJLAjzrCEKedOmYSFd39AcF5qwuNtkO8WyCCGFcgOS5n6Xy1T4om tmJYg89sXeNVN4MvRtD1klgYPBfo+2NCQszh6gyaW+V95AP8ZIPxaewqJTZ4wkVo /60qkSTpKhc+xH79BgKMU4EeCNRJoyY3PsKCFVFxrOdSRnlHMryuasYkrXRGOZzQ AB22zKS3mnhr6Vo6arMM2ERIPE38Dq8eB99a4ZetgqSahtnT47waMthnABYx4D/b BtbjA6nH+pkfS1zO6w04UEeiy8ZsHCarPC9r38tMgBbqVDDspCQmCVfcyDaiCqAi cc6z/UddcF1B+y/U7rZUhZRAJOUPT/qRCXoZjG22wqlY+JZ8v6WMow3wYYpp63sD aAC9cThAEz8H8SgHUpta3oXkAXJRc0Jdz5gq98uIoFBrlbBtHFVX3kgMpxOlWSPN AxlEAdFl =pn0m -----END PGP SIGNATURE----- --arh1ZL78woflSoTn--