From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EDFC63793 for ; Thu, 22 Jul 2021 16:22:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60E696128A for ; Thu, 22 Jul 2021 16:22:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbhGVPl6 (ORCPT ); Thu, 22 Jul 2021 11:41:58 -0400 Received: from verein.lst.de ([213.95.11.211]:34894 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbhGVPl4 (ORCPT ); Thu, 22 Jul 2021 11:41:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B75EC67373; Thu, 22 Jul 2021 18:22:28 +0200 (CEST) Date: Thu, 22 Jul 2021 18:22:28 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: netdev@vger.kernel.org, Arnd Bergmann , Al Viro , Andrew Lunn , Christoph Hellwig , David Ahern , "David S. Miller" , Eric Dumazet , Hideaki YOSHIFUJI , Jakub Kicinski , Kees Cook , Marco Elver , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH net-next v6 1/6] compat: make linux/compat.h available everywhere Message-ID: <20210722162228.GA9882@lst.de> References: <20210722142903.213084-1-arnd@kernel.org> <20210722142903.213084-2-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722142903.213084-2-arnd@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 04:28:58PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Parts of linux/compat.h are under an #ifdef, but we end up > using more of those over time, moving things around bit by > bit. > > To get it over with once and for all, make all of this file > uncondititonal now so it can be accessed everywhere. There > are only a few types left that are in asm/compat.h but not > yet in the asm-generic version, so add those in the process. > > This requires providing a few more types in asm-generic/compat.h > that were not already there. The only tricky one is > compat_sigset_t, which needs a little help on 32-bit architectures > and for x86. > > Signed-off-by: Arnd Bergmann Looks good, Reviewed-by: Christoph Hellwig