From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D65C4338F for ; Fri, 23 Jul 2021 06:33:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 203ED60EAF for ; Fri, 23 Jul 2021 06:33:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 203ED60EAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6oke-00046O-8E for qemu-devel@archiver.kernel.org; Fri, 23 Jul 2021 02:33:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6oji-0003Qh-79 for qemu-devel@nongnu.org; Fri, 23 Jul 2021 02:32:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6ojf-0004Hq-3a for qemu-devel@nongnu.org; Fri, 23 Jul 2021 02:32:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627021958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AbEjP+eVOPc9srb5WxL6EgQND49UM0YtCnxVj/1nvBo=; b=iFS+aCO50t2K7YKv8MQFO3wAbGHnJBbZlgkD9cciWDPF4CAQZ/3WsM72SotOza/E+n49AL P/QCH0G3osur3qwekafjnuz1pwtbj0DRnV/bDztLIVWcVQ1w4T4707ywCgAwAjdMxuWsVC u8Rb3HZEcCqxH4EsDhSnhrk2WEu1RZI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-63emvbdIOjm9n3DYw6Urag-1; Fri, 23 Jul 2021 02:32:36 -0400 X-MC-Unique: 63emvbdIOjm9n3DYw6Urag-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DE7BF92500 for ; Fri, 23 Jul 2021 06:32:35 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-106.ams2.redhat.com [10.36.114.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A5C5710016F7; Fri, 23 Jul 2021 06:32:35 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C78431800926; Fri, 23 Jul 2021 08:32:33 +0200 (CEST) Date: Fri, 23 Jul 2021 08:32:33 +0200 From: Gerd Hoffmann To: "Dr. David Alan Gilbert" Subject: Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save. Message-ID: <20210723063233.ktjex5knfgz77pbq@sirius.home.kraxel.org> References: <20210721093347.338536-1-kraxel@redhat.com> <20210721093347.338536-2-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.472, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 22, 2021 at 03:44:54PM +0100, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kraxel@redhat.com) wrote: > > Since commit 551dbd0846d2 ("migration: check pre_save return in > > vmstate_save_state") the pre_save hook can fail. So lets finally > > use that to drop the guest-triggerable assert in qxl_pre_save(). > > > > Signed-off-by: Gerd Hoffmann > > --- > > hw/display/qxl.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > > index 84f99088e0a0..3867b94fe236 100644 > > --- a/hw/display/qxl.c > > +++ b/hw/display/qxl.c > > @@ -2283,7 +2283,9 @@ static int qxl_pre_save(void *opaque) > > } else { > > d->last_release_offset = (uint8_t *)d->last_release - ram_start; > > } > > - assert(d->last_release_offset < d->vga.vram_size); > > + if (d->last_release_offset < d->vga.vram_size) { > > + return 1; > > It would be great if there was an error_report or something there > so that we get some idea of what happened. Hmm. Strictly speaking qemu_log_mask(LOG_GUEST_ERROR, "..."); would be the correct approach here, but I guess that wouldn't help much for trouble-shooting as the message would only show up with "-d guest_errors". So better make that error_report("...") ? take care, Gerd