Re: [RFC 3/4] power: supply: Add charger driver for Rockchip RK817

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3020 bytes --]

Hi Chris,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on rockchip/for-next]
[also build test WARNING on power-supply/for-next v5.14-rc2 next-20210722]
[cannot apply to lee-mfd/for-mfd-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chris-Morgan/power-supply-Add-Support-for-RK817-Charger/20210723-031508
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: x86_64-randconfig-r031-20210723 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9625ca5b602616b2f5584e8a49ba93c52c141e40)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/8054ca1dc455218984a38432a1d39530cd287b38
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chris-Morgan/power-supply-Add-Support-for-RK817-Charger/20210723-031508
        git checkout 8054ca1dc455218984a38432a1d39530cd287b38
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/power/supply/rk817_charger.c:152:2: warning: variable 'out' is uninitialized when used here [-Wuninitialized]
           out |= tmp;
           ^~~
   drivers/power/supply/rk817_charger.c:146:14: note: initialize the variable 'out' to silence this warning
           uint32_t out;
                       ^
                        = 0
>> drivers/power/supply/rk817_charger.c:875:14: warning: address of array 'info->ocv_table' will always evaluate to 'true' [-Wpointer-bool-conversion]
               (!info->ocv_table)) {
                ~~~~~~~^~~~~~~~~
   2 warnings generated.


vim +/out +152 drivers/power/supply/rk817_charger.c

   142	
   143	static int rk817_get_reg_hl(struct rk817_charger *charger, int regH, int regL)
   144	{
   145		int tmp, ret;
   146		uint32_t out;
   147		struct rk808 *rk808 = charger->rk808;
   148	
   149		ret = regmap_read(rk808->regmap, regL, &tmp);
   150		if (ret)
   151			return ret;
 > 152		out |= tmp;
   153	
   154		ret = regmap_read(rk808->regmap, regH, &tmp);
   155		if (ret)
   156			return ret;
   157		out |= tmp << 8;
   158	
   159		return out;
   160	}
   161	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36494 bytes --]