[PATCH 01/15] staging: vt6655: remove filename from baseband.h

[PATCH 01/15] staging: vt6655: remove filename from baseband.h

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for baseband.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/baseband.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
index 9354ce724446..0a30afaa7cc3 100644
--- a/drivers/staging/vt6655/baseband.h
+++ b/drivers/staging/vt6655/baseband.h
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: baseband.h
- *
  * Purpose: Implement functions to access baseband
  *
  * Author: Jerry Chen
-- 
2.25.1

[PATCH 02/15] staging: vt6655: remove filename from baseband.c

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for baseband.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/baseband.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index d89163299172..f73f3fad3e05 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: baseband.c
- *
  * Purpose: Implement functions to access baseband
  *
  * Author: Kyle Hsu
-- 
2.25.1

[PATCH 03/15] staging: vt6655: remove filename from card.c

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for card.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/card.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 29086189c53a..3ef3a6e0e6e1 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -3,7 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: card.c
  * Purpose: Provide functions to setup NIC operation mode
  * Functions:
  *      s_vSafeResetTx - Rest Tx
-- 
2.25.1

[PATCH 04/15] staging: vt6655: remove filename from card.h

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for card.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/card.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index 568a2ddd6588..09e7f3f1cbed 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: card.h
- *
  * Purpose: Provide functions to setup NIC operation mode
  *
  * Author: Tevin Chen
-- 
2.25.1

[PATCH 05/15] staging: vt6655: remove filename from channel.c

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for channel.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/channel.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
index cf46ee63681a..52b6538a201a 100644
--- a/drivers/staging/vt6655/channel.c
+++ b/drivers/staging/vt6655/channel.c
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: channel.c
- *
  */
 
 #include "baseband.h"
-- 
2.25.1

[PATCH 06/15] staging: vt6655: remove filename from channel.h

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for channel.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/channel.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6655/channel.h b/drivers/staging/vt6655/channel.h
index 0d2709607456..78b2d82317e5 100644
--- a/drivers/staging/vt6655/channel.h
+++ b/drivers/staging/vt6655/channel.h
@@ -3,7 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: channel.h
  */
 
 #ifndef _CHANNEL_H_
-- 
2.25.1

[PATCH 07/15] staging: vt6655: remove filename from device_cfg.h

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for device_cfg.h, and adds an empty line
after the top description comment to match the style of the other vt6655
files.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/device_cfg.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
index 04db6a8d3db3..db0304f6e21c 100644
--- a/drivers/staging/vt6655/device_cfg.h
+++ b/drivers/staging/vt6655/device_cfg.h
@@ -3,14 +3,13 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: device_cfg.h
- *
  * Purpose: Driver configuration header
  * Author: Lyndon Chen
  *
  * Date: Dec 17, 2002
  *
  */
+
 #ifndef __DEVICE_CONFIG_H
 #define __DEVICE_CONFIG_H
 
-- 
2.25.1

[PATCH 08/15] staging: vt6655: remove filename from device_main.c

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for device_main.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/device_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 979165445d88..d40c2ac14928 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: device_main.c
- *
  * Purpose: driver entry for initial, open, close, tx and rx.
  *
  * Author: Lyndon Chen
-- 
2.25.1

[PATCH 09/15] staging: vt6655: remove filename from dpc.c

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for dpc.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/dpc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c
index 52214a30e9b6..2d06cecc0307 100644
--- a/drivers/staging/vt6655/dpc.c
+++ b/drivers/staging/vt6655/dpc.c
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: dpc.c
- *
  * Purpose: handle dpc rx functions
  *
  * Author: Lyndon Chen
-- 
2.25.1

[PATCH 10/15] staging: vt6655: remove filename from dpc.h

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for dpc.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/dpc.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/dpc.h b/drivers/staging/vt6655/dpc.h
index eac67794cc49..40364c0ab7f6 100644
--- a/drivers/staging/vt6655/dpc.h
+++ b/drivers/staging/vt6655/dpc.h
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: dpc.h
- *
  * Purpose:
  *
  * Author: Jerry Chen
-- 
2.25.1

[PATCH 11/15] staging: vt6655: remove filename from key.c

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for key.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/key.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/key.c b/drivers/staging/vt6655/key.c
index 94665ddc36a5..20881cf2f394 100644
--- a/drivers/staging/vt6655/key.c
+++ b/drivers/staging/vt6655/key.c
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: key.c
- *
  * Purpose: Implement functions for 802.11i Key management
  *
  * Author: Jerry Chen
-- 
2.25.1

[PATCH 12/15] staging: vt6655: remove filename from key.h

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for key.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/key.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/key.h b/drivers/staging/vt6655/key.h
index 9347776fa3a5..d88da9dfb5c3 100644
--- a/drivers/staging/vt6655/key.h
+++ b/drivers/staging/vt6655/key.h
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: key.h
- *
  * Purpose: Implement functions for 802.11i Key management
  *
  * Author: Jerry Chen
-- 
2.25.1

[PATCH 13/15] staging: vt6655: kernel style cleanup of mac.c

[Lucas Henneman]

This patch removes from mac.c the file name and an ftrace-like pr_debug
per checkpatch's two warnings.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/mac.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index f5ae7f1f5689..9721c2234bf2 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: mac.c
- *
  * Purpose:  MAC routines
  *
  * Author: Tevin Chen
@@ -775,7 +773,6 @@ void MACvSetKeyEntry(struct vnt_private *priv, unsigned short wKeyCtl,
 	if (byLocalID <= 1)
 		return;
 
-	pr_debug("%s\n", __func__);
 	offset = MISCFIFO_KEYETRY0;
 	offset += (uEntryIdx * MISCFIFO_KEYENTRYSIZE);
 
-- 
2.25.1

[PATCH 14/15] staging: vt6655: remove filename from mac.h

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for mac.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/mac.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 6e2bd16ef384..9797eddaea01 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: mac.h
- *
  * Purpose: MAC routines
  *
  * Author: Tevin Chen
-- 
2.25.1

[PATCH 15/15] staging: vt6655: remove filename from upc.h

[Lucas Henneman]

This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for upc.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
---
 drivers/staging/vt6655/upc.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
index 8608693ae9c3..b374db5fca81 100644
--- a/drivers/staging/vt6655/upc.h
+++ b/drivers/staging/vt6655/upc.h
@@ -3,8 +3,6 @@
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
  *
- * File: upc.h
- *
  * Purpose: Macros to access device
  *
  * Author: Tevin Chen
-- 
2.25.1

Re: [PATCH 01/15] staging: vt6655: remove filename from baseband.h

[Lee Jones]

On Fri, 23 Jul 2021, Lucas Henneman wrote:

> This patch resolves checkpatch's warning, "It's generally not useful to
> have the filename in the file" for baseband.h.

I would paste the exact warning you get from checkpatch.pl, warts
(line numbers) and all on a completely separate line.

> Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
> ---
>  drivers/staging/vt6655/baseband.h | 2 --
>  1 file changed, 2 deletions(-)

Nice first attempt at working with Mainline Lucas.

The premise of the patches seem okay.  I don't personally allow
filenames into new commits in subsystems I maintain.

Seeing as though these patches are *so* trivial, if I were Greg, I'd
be asking you to bundle each of these changes into a single patch.

> diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
> index 9354ce724446..0a30afaa7cc3 100644
> --- a/drivers/staging/vt6655/baseband.h
> +++ b/drivers/staging/vt6655/baseband.h
> @@ -3,8 +3,6 @@
>   * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
>   * All rights reserved.
>   *
> - * File: baseband.h
> - *
>   * Purpose: Implement functions to access baseband
>   *
>   * Author: Jerry Chen

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 13/15] staging: vt6655: kernel style cleanup of mac.c

[Lee Jones]

On Fri, 23 Jul 2021, Lucas Henneman wrote:

> This patch removes from mac.c the file name and an ftrace-like pr_debug
> per checkpatch's two warnings.

Please add the warning verbatim.

> Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
> ---
>  drivers/staging/vt6655/mac.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
> index f5ae7f1f5689..9721c2234bf2 100644
> --- a/drivers/staging/vt6655/mac.c
> +++ b/drivers/staging/vt6655/mac.c
> @@ -3,8 +3,6 @@
>   * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
>   * All rights reserved.
>   *
> - * File: mac.c
> - *
>   * Purpose:  MAC routines
>   *
>   * Author: Tevin Chen
> @@ -775,7 +773,6 @@ void MACvSetKeyEntry(struct vnt_private *priv, unsigned short wKeyCtl,
>  	if (byLocalID <= 1)
>  		return;
>  
> -	pr_debug("%s\n", __func__);
>  	offset = MISCFIFO_KEYETRY0;
>  	offset += (uEntryIdx * MISCFIFO_KEYENTRYSIZE);
>  

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 01/15] staging: vt6655: remove filename from baseband.h

[Lucas Henneman]

On Fri, Jul 23, 2021 at 04:13:35PM +0100, Lee Jones wrote:
> On Fri, 23 Jul 2021, Lucas Henneman wrote:
> 
> > This patch resolves checkpatch's warning, "It's generally not useful to
> > have the filename in the file" for baseband.h.
> 
> I would paste the exact warning you get from checkpatch.pl, warts
> (line numbers) and all on a completely separate line.
> 

Ok, I will include checkpatch.pl's original output properly.

> > Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
> > ---
> >  drivers/staging/vt6655/baseband.h | 2 --
> >  1 file changed, 2 deletions(-)
> 
> Nice first attempt at working with Mainline Lucas.
> 

Thanks, Lee!

> The premise of the patches seem okay.  I don't personally allow
> filenames into new commits in subsystems I maintain.
> 
> Seeing as though these patches are *so* trivial, if I were Greg, I'd
> be asking you to bundle each of these changes into a single patch.
> 
> > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
> > index 9354ce724446..0a30afaa7cc3 100644
> > --- a/drivers/staging/vt6655/baseband.h
> > +++ b/drivers/staging/vt6655/baseband.h
> > @@ -3,8 +3,6 @@
> >   * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
> >   * All rights reserved.
> >   *
> > - * File: baseband.h
> > - *
> >   * Purpose: Implement functions to access baseband
> >   *
> >   * Author: Jerry Chen
> 
> -- 
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 01/15] staging: vt6655: remove filename from baseband.h

[Greg KH]

On Fri, Jul 23, 2021 at 04:13:35PM +0100, Lee Jones wrote:
> On Fri, 23 Jul 2021, Lucas Henneman wrote:
> 
> > This patch resolves checkpatch's warning, "It's generally not useful to
> > have the filename in the file" for baseband.h.
> 
> I would paste the exact warning you get from checkpatch.pl, warts
> (line numbers) and all on a completely separate line.
> 
> > Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
> > ---
> >  drivers/staging/vt6655/baseband.h | 2 --
> >  1 file changed, 2 deletions(-)
> 
> Nice first attempt at working with Mainline Lucas.
> 
> The premise of the patches seem okay.  I don't personally allow
> filenames into new commits in subsystems I maintain.
> 
> Seeing as though these patches are *so* trivial, if I were Greg, I'd
> be asking you to bundle each of these changes into a single patch.

I'll take these as-is, it's fine.

thanks,

greg k-h