All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Alexandre Iooss" <erdnaxe@crans.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org
Subject: [PULL 21/28] plugins/cache: Fixed a bug with destroying FIFO metadata
Date: Fri, 23 Jul 2021 18:03:47 +0100	[thread overview]
Message-ID: <20210723170354.18975-22-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210723170354.18975-1-alex.bennee@linaro.org>

From: Mahmoud Mandour <ma.mandourr@gmail.com>

This manifests itself when associativity degree is greater than the
number of sets and FIFO is used, otherwise it's also a memory leak
whenever FIFO was used.

Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210714172151.8494-2-ma.mandourr@gmail.com>
Message-Id: <20210720232703.10650-22-alex.bennee@linaro.org>

diff --git a/contrib/plugins/cache.c b/contrib/plugins/cache.c
index bf0d2f6097..4a71602639 100644
--- a/contrib/plugins/cache.c
+++ b/contrib/plugins/cache.c
@@ -200,7 +200,7 @@ static void fifo_destroy(Cache *cache)
 {
     int i;
 
-    for (i = 0; i < cache->assoc; i++) {
+    for (i = 0; i < cache->num_sets; i++) {
         g_queue_free(cache->sets[i].fifo_queue);
     }
 }
-- 
2.20.1



  parent reply	other threads:[~2021-07-23 17:13 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 17:03 [PULL for 6.1-rc1 00/28] doc, metadata, plugin and testing updates Alex Bennée
2021-07-23 17:03 ` [PULL 01/28] gitignore: Update with some filetypes Alex Bennée
2021-07-23 17:03 ` [PULL 02/28] docs: collect the disparate device emulation docs into one section Alex Bennée
2021-07-23 17:03 ` [PULL 03/28] docs: add a section on the generalities of vhost-user Alex Bennée
2021-07-23 17:03 ` [PULL 04/28] configure: remove needless if leg Alex Bennée
2021-07-23 17:03 ` [PULL 05/28] contrib/gitdm: add some new aliases to fix up commits Alex Bennée
2021-07-23 17:03 ` [PULL 06/28] .mailmap: fix up some broken commit authors Alex Bennée
2021-07-23 17:03 ` [PULL 07/28] contrib/gitdm: add domain-map for MontaVista Alex Bennée
2021-07-23 17:03 ` [PULL 08/28] contrib/gitdm: add a group mapping for robot scanners Alex Bennée
2021-07-23 17:03 ` [PULL 09/28] gitdm.config: sort the corporate GroupMap entries Alex Bennée
2021-07-23 17:03 ` [PULL 10/28] contrib/gitdm: add domain-map/group-map mappings for Samsung Alex Bennée
2021-07-23 17:03 ` [PULL 11/28] contrib/gitdm: add domain-map for Eldorado Alex Bennée
2021-07-23 17:03 ` [PULL 12/28] contrib/gitdm: add domain-map/group-map for Wind River Alex Bennée
2021-07-23 17:03 ` [PULL 13/28] contrib/gitdm: un-ironically add a mapping for LWN Alex Bennée
2021-07-23 17:03 ` [PULL 14/28] contrib/gitdm: add domain-map for Crudebyte Alex Bennée
2021-07-23 17:03 ` [PULL 15/28] contrib/gitdm: add domain-map for NVIDIA Alex Bennée
2021-07-23 17:03 ` [PULL 16/28] contrib/gitdm: add group-map for Netflix Alex Bennée
2021-07-23 17:03 ` [PULL 17/28] contrib/gitdm: add an explicit academic entry for BU Alex Bennée
2021-07-23 17:03 ` [PULL 18/28] contrib/gitdm: add a new interns group-map for GSoC/Outreachy work Alex Bennée
2021-07-23 17:03 ` [PULL 19/28] contrib/gitdm: add more individual contributor entries Alex Bennée
2021-07-23 17:03 ` [PULL 20/28] tcg/plugins: implement a qemu_plugin_user_exit helper Alex Bennée
2021-07-23 17:03 ` Alex Bennée [this message]
2021-07-23 17:03 ` [PULL 22/28] plugins/cache: limited the scope of a mutex lock Alex Bennée
2021-07-23 17:03 ` [PULL 23/28] plugins/cache: Fixed "function decl. is not a prototype" warnings Alex Bennée
2021-07-23 17:03 ` [PULL 24/28] plugins: Fix physical address calculation for IO regions Alex Bennée
2021-07-23 17:03 ` [PULL 25/28] tests/tcg/configure.sh: add handling for assembler only builds Alex Bennée
2021-07-23 17:03 ` [PULL 26/28] gitlab: enable a very minimal build with the tricore container Alex Bennée
2021-07-23 17:03 ` [PULL 27/28] gitlab-ci: Remove the second superfluous macos task Alex Bennée
2021-07-23 17:03 ` [PULL 28/28] gitlab-ci: Extract OpenSBI job rules to reusable section Alex Bennée
2021-07-23 17:44 ` [PULL for 6.1-rc1 00/28] doc, metadata, plugin and testing updates Philippe Mathieu-Daudé
2021-07-24 10:04   ` Peter Maydell
2021-07-26  8:45     ` Daniel P. Berrangé
2021-07-26 12:36       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723170354.18975-22-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=erdnaxe@crans.org \
    --cc=ma.mandourr@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [PULL 21/28] plugins/cache: Fixed a bug with destroying FIFO metadata' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.