From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
sassmann@redhat.com,
Grzegorz Szczurek <grzegorzx.szczurek@intel.com>,
Imam Hassan Reza Biswas <imam.hassan.reza.biswas@intel.com>
Subject: [PATCH net 5/5] i40e: Fix log TC creation failure when max num of queues is exceeded
Date: Fri, 23 Jul 2021 10:10:23 -0700 [thread overview]
Message-ID: <20210723171023.296927-6-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20210723171023.296927-1-anthony.l.nguyen@intel.com>
From: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Fix missing failed message if driver does not have enough queues to
complete TC command. Without this fix no message is displayed in dmesg.
Fixes: a9ce82f744dc ("i40e: Enable 'channel' mode in mqprio for TC configs")
Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Tested-by: Imam Hassan Reza Biswas <imam.hassan.reza.biswas@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 278077208f37..1d1f52756a93 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -7290,6 +7290,8 @@ static int i40e_validate_mqprio_qopt(struct i40e_vsi *vsi,
}
if (vsi->num_queue_pairs <
(mqprio_qopt->qopt.offset[i] + mqprio_qopt->qopt.count[i])) {
+ dev_err(&vsi->back->pdev->dev,
+ "Failed to create traffic channel, insufficient number of queues.\n");
return -EINVAL;
}
if (sum_max_rate > i40e_get_link_speed(vsi)) {
--
2.26.2
next prev parent reply other threads:[~2021-07-23 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 17:10 [PATCH net 0/5][pull request] Intel Wired LAN Driver Updates 2021-07-23 Tony Nguyen
2021-07-23 17:10 ` [PATCH net 1/5] i40e: Fix logic of disabling queues Tony Nguyen
2021-07-23 17:10 ` [PATCH net 2/5] i40e: Fix firmware LLDP agent related warning Tony Nguyen
2021-07-23 17:10 ` [PATCH net 3/5] i40e: Add additional info to PHY type error Tony Nguyen
2021-07-23 17:10 ` [PATCH net 4/5] i40e: Fix queue-to-TC mapping on Tx Tony Nguyen
2021-07-23 17:10 ` Tony Nguyen [this message]
2021-07-23 21:10 ` [PATCH net 0/5][pull request] Intel Wired LAN Driver Updates 2021-07-23 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723171023.296927-6-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=grzegorzx.szczurek@intel.com \
--cc=imam.hassan.reza.biswas@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.