All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Henneman <lucas.henneman@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: greg@kroah.com, forest@alittletooquiet.net,
	linux-staging@lists.linux.dev, trivial@kernel.org
Subject: Re: [PATCH 01/15] staging: vt6655: remove filename from baseband.h
Date: Fri, 23 Jul 2021 13:55:15 -0400	[thread overview]
Message-ID: <20210723175515.GA17351@TUX> (raw)
In-Reply-To: <YPrcnylo47dFU8Cl@google.com>

On Fri, Jul 23, 2021 at 04:13:35PM +0100, Lee Jones wrote:
> On Fri, 23 Jul 2021, Lucas Henneman wrote:
> 
> > This patch resolves checkpatch's warning, "It's generally not useful to
> > have the filename in the file" for baseband.h.
> 
> I would paste the exact warning you get from checkpatch.pl, warts
> (line numbers) and all on a completely separate line.
> 

Ok, I will include checkpatch.pl's original output properly.

> > Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
> > ---
> >  drivers/staging/vt6655/baseband.h | 2 --
> >  1 file changed, 2 deletions(-)
> 
> Nice first attempt at working with Mainline Lucas.
> 

Thanks, Lee!

> The premise of the patches seem okay.  I don't personally allow
> filenames into new commits in subsystems I maintain.
> 
> Seeing as though these patches are *so* trivial, if I were Greg, I'd
> be asking you to bundle each of these changes into a single patch.
> 
> > diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
> > index 9354ce724446..0a30afaa7cc3 100644
> > --- a/drivers/staging/vt6655/baseband.h
> > +++ b/drivers/staging/vt6655/baseband.h
> > @@ -3,8 +3,6 @@
> >   * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
> >   * All rights reserved.
> >   *
> > - * File: baseband.h
> > - *
> >   * Purpose: Implement functions to access baseband
> >   *
> >   * Author: Jerry Chen
> 
> -- 
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2021-07-23 17:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 14:43 [PATCH 01/15] staging: vt6655: remove filename from baseband.h Lucas Henneman
2021-07-23 14:43 ` [PATCH 02/15] staging: vt6655: remove filename from baseband.c Lucas Henneman
2021-07-23 14:43 ` [PATCH 03/15] staging: vt6655: remove filename from card.c Lucas Henneman
2021-07-23 14:43 ` [PATCH 04/15] staging: vt6655: remove filename from card.h Lucas Henneman
2021-07-23 14:43 ` [PATCH 05/15] staging: vt6655: remove filename from channel.c Lucas Henneman
2021-07-23 14:43 ` [PATCH 06/15] staging: vt6655: remove filename from channel.h Lucas Henneman
2021-07-23 14:43 ` [PATCH 07/15] staging: vt6655: remove filename from device_cfg.h Lucas Henneman
2021-07-23 14:43 ` [PATCH 08/15] staging: vt6655: remove filename from device_main.c Lucas Henneman
2021-07-23 14:43 ` [PATCH 09/15] staging: vt6655: remove filename from dpc.c Lucas Henneman
2021-07-23 14:43 ` [PATCH 10/15] staging: vt6655: remove filename from dpc.h Lucas Henneman
2021-07-23 14:43 ` [PATCH 11/15] staging: vt6655: remove filename from key.c Lucas Henneman
2021-07-23 14:43 ` [PATCH 12/15] staging: vt6655: remove filename from key.h Lucas Henneman
2021-07-23 14:43 ` [PATCH 13/15] staging: vt6655: kernel style cleanup of mac.c Lucas Henneman
2021-07-23 15:15   ` Lee Jones
2021-07-23 14:43 ` [PATCH 14/15] staging: vt6655: remove filename from mac.h Lucas Henneman
2021-07-23 14:43 ` [PATCH 15/15] staging: vt6655: remove filename from upc.h Lucas Henneman
2021-07-23 15:13 ` [PATCH 01/15] staging: vt6655: remove filename from baseband.h Lee Jones
2021-07-23 17:55   ` Lucas Henneman [this message]
2021-07-27 13:22   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723175515.GA17351@TUX \
    --to=lucas.henneman@linaro.org \
    --cc=forest@alittletooquiet.net \
    --cc=greg@kroah.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.