Re: [RFC PATCH 4/6] leds: pca955x: Use pinctrl to map GPIOs to pins

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH 4/6] leds: pca955x: Use pinctrl to map GPIOs to pins
Date: Fri, 23 Jul 2021 20:40:27 +0800	[thread overview]
Message-ID: <202107232009.WNVTKKFc-lkp@intel.com> (raw)
In-Reply-To: <20210723075858.376378-5-andrew@aj.id.au>

[-- Attachment #1: Type: text/plain, Size: 4912 bytes --]

Hi Andrew,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on pinctrl/devel]
[also build test WARNING on pavel-linux-leds/for-next v5.14-rc2 next-20210723]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andrew-Jeffery/leds-Fix-pca955x-GPIO-pin-mappings/20210723-160236
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/b0a72adc5668fe81b75d7b10f310d05aea0f3b82
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andrew-Jeffery/leds-Fix-pca955x-GPIO-pin-mappings/20210723-160236
        git checkout b0a72adc5668fe81b75d7b10f310d05aea0f3b82
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/gpio/driver.h:5,
                    from drivers/leds/leds-pca955x.c:43:
   drivers/leds/leds-pca955x.c: In function 'pca955x_pinctrl_get_group_name':
>> drivers/leds/leds-pca955x.c:426:4: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     426 |    "Group selector (%u) exceeds the supported group count (%u)\n",
         |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/leds/leds-pca955x.c:425:3: note: in expansion of macro 'dev_err'
     425 |   dev_err(&pca955x->client->dev,
         |   ^~~~~~~
   drivers/leds/leds-pca955x.c:426:61: note: format string is defined here
     426 |    "Group selector (%u) exceeds the supported group count (%u)\n",
         |                                                            ~^
         |                                                             |
         |                                                             unsigned int
         |                                                            %lu
   In file included from include/linux/device.h:15,
                    from include/linux/gpio/driver.h:5,
                    from drivers/leds/leds-pca955x.c:43:
   drivers/leds/leds-pca955x.c: In function 'pca955x_pinctrl_get_group_pins':
   drivers/leds/leds-pca955x.c:449:4: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
     449 |    "Group selector (%u) exceeds the supported group count (%u)\n",
         |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/leds/leds-pca955x.c:448:3: note: in expansion of macro 'dev_err'
     448 |   dev_err(&pca955x->client->dev,
         |   ^~~~~~~
   drivers/leds/leds-pca955x.c:449:61: note: format string is defined here
     449 |    "Group selector (%u) exceeds the supported group count (%u)\n",
         |                                                            ~^
         |                                                             |
         |                                                             unsigned int
         |                                                            %lu

vim +426 drivers/leds/leds-pca955x.c

   411	
   412	static const char *
   413	pca955x_pinctrl_get_group_name(struct pinctrl_dev *pctldev, unsigned int selector)
   414	{
   415		struct pca955x *pca955x = pinctrl_dev_get_drvdata(pctldev);
   416	
   417		if (unlikely(selector > pca955x->chipdef->bits)) {
   418			dev_err(&pca955x->client->dev,
   419				"Group selector (%u) exceeds groups count (%u)\n",
   420				selector, pca955x->chipdef->bits);
   421			return NULL;
   422		}
   423	
   424		if (unlikely(selector > ARRAY_SIZE(pca9552_groups))) {
   425			dev_err(&pca955x->client->dev,
 > 426				"Group selector (%u) exceeds the supported group count (%u)\n",
   427				selector, ARRAY_SIZE(pca9552_groups));
   428			return NULL;
   429		}
   430	
   431		return pca9552_groups[selector];
   432	}
   433	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65969 bytes --]