Hi Mark,

I love your patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on v5.14-rc2 next-20210723]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mark-Brown/ASoC-tlv320aic31xx-Fix-jack-detection-after-suspend/20210724-020429
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: arm-randconfig-r022-20210723 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9625ca5b602616b2f5584e8a49ba93c52c141e40)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/fd727e56e60de06a923175ce246e965e27c6df88
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mark-Brown/ASoC-tlv320aic31xx-Fix-jack-detection-after-suspend/20210724-020429
        git checkout fd727e56e60de06a923175ce246e965e27c6df88
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> sound/soc/codecs/tlv320aic31xx.c:1264:2: error: implicit declaration of function 'aic31xx_set_jack' [-Werror,-Wimplicit-function-declaration]
           aic31xx_set_jack(component, aic31xx->jack, NULL);
           ^
   sound/soc/codecs/tlv320aic31xx.c:1312:12: error: static declaration of 'aic31xx_set_jack' follows non-static declaration
   static int aic31xx_set_jack(struct snd_soc_component *component,
              ^
   sound/soc/codecs/tlv320aic31xx.c:1264:2: note: previous implicit declaration is here
           aic31xx_set_jack(component, aic31xx->jack, NULL);
           ^
   2 errors generated.


vim +/aic31xx_set_jack +1264 sound/soc/codecs/tlv320aic31xx.c

  1231	
  1232	static int aic31xx_power_on(struct snd_soc_component *component)
  1233	{
  1234		struct aic31xx_priv *aic31xx = snd_soc_component_get_drvdata(component);
  1235		int ret;
  1236	
  1237		ret = regulator_bulk_enable(ARRAY_SIZE(aic31xx->supplies),
  1238					    aic31xx->supplies);
  1239		if (ret)
  1240			return ret;
  1241	
  1242		regcache_cache_only(aic31xx->regmap, false);
  1243	
  1244		/* Reset device registers for a consistent power-on like state */
  1245		ret = aic31xx_reset(aic31xx);
  1246		if (ret < 0)
  1247			dev_err(aic31xx->dev, "Could not reset device: %d\n", ret);
  1248	
  1249		ret = regcache_sync(aic31xx->regmap);
  1250		if (ret) {
  1251			dev_err(component->dev,
  1252				"Failed to restore cache: %d\n", ret);
  1253			regcache_cache_only(aic31xx->regmap, true);
  1254			regulator_bulk_disable(ARRAY_SIZE(aic31xx->supplies),
  1255					       aic31xx->supplies);
  1256			return ret;
  1257		}
  1258	
  1259		/*
  1260		 * The jack detection configuration is in the same register
  1261		 * that is used to report jack detect status so is volatile
  1262		 * and not covered by the cache sync, restore it separately.
  1263		 */
> 1264		aic31xx_set_jack(component, aic31xx->jack, NULL);
  1265	
  1266		return 0;
  1267	}
  1268	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org