All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] Config.in: disable PIC/PIE for microblaze
@ 2021-07-25 13:48 Thomas Petazzoni
  2021-08-05 10:59 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2021-07-25 13:48 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=d120f844604da2295bb7bd8fc6c1f4efbe8b5792
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

As reported by Toolchain-builder project [1], the system doesn't
boot when PIC/PIE is enabled for glibc based toolchain (the init
process hang).

Also, hardening features may not be wanted or possible for such
slow soft-core cpus [2].

Like for NiosII, disable BR2_PIC_PIE.

[1] https://gitlab.com/bootlin/toolchains-builder/-/pipelines/318038406
[2] http://lists.busybox.net/pipermail/buildroot/2021-June/312416.html

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Config.in b/Config.in
index a146ba0f43..2ef5d407e4 100644
--- a/Config.in
+++ b/Config.in
@@ -729,6 +729,8 @@ comment "Security Hardening Options"
 config BR2_PIC_PIE_ARCH_SUPPORTS
 	bool
 	default y
+	# Microblaze glibc toolchains don't work with PIC/PIE enabled
+	depends on !BR2_microblaze
 	# Nios2 toolchains produce non working binaries with -fPIC
 	depends on !BR2_nios2
 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [git commit] Config.in: disable PIC/PIE for microblaze
  2021-07-25 13:48 [Buildroot] [git commit] Config.in: disable PIC/PIE for microblaze Thomas Petazzoni
@ 2021-08-05 10:59 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2021-08-05 10:59 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=d120f844604da2295bb7bd8fc6c1f4efbe8b5792
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > As reported by Toolchain-builder project [1], the system doesn't
 > boot when PIC/PIE is enabled for glibc based toolchain (the init
 > process hang).

 > Also, hardening features may not be wanted or possible for such
 > slow soft-core cpus [2].

 > Like for NiosII, disable BR2_PIC_PIE.

 > [1] https://gitlab.com/bootlin/toolchains-builder/-/pipelines/318038406
 > [2] http://lists.busybox.net/pipermail/buildroot/2021-June/312416.html

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2021.02.x and 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-05 10:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-25 13:48 [Buildroot] [git commit] Config.in: disable PIC/PIE for microblaze Thomas Petazzoni
2021-08-05 10:59 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.