From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73316C4338F for ; Sun, 25 Jul 2021 21:10:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FE8860F11 for ; Sun, 25 Jul 2021 21:10:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6FE8860F11 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0309A82D49; Sun, 25 Jul 2021 23:10:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jW8mTOMf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D3D7D83118; Sun, 25 Jul 2021 23:10:44 +0200 (CEST) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4352481BC8 for ; Sun, 25 Jul 2021 23:10:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id t4so4168775qvj.0 for ; Sun, 25 Jul 2021 14:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=b+N+aFfwHiQdJfdnIvBCOAMntj+R3IpkNu146rTkLXU=; b=jW8mTOMfmbfEekb7qcMTLNPOV5/kLdXtlHoUM/Wz93WrHjhMcZb+Ps5UAieGOURlWX XjIz2aEErTutgyz49OO2/P9jNOkPceehlkk155vxASd+HzUe4e0rKRZjXH7qjwEdPs/y r6Ep/M/Vyi1hfpkChEmkcH4HcXQBLsxCKNvBE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=b+N+aFfwHiQdJfdnIvBCOAMntj+R3IpkNu146rTkLXU=; b=Lv73zpxIunE/5ztfIH+bgRGJ1bqJq/afcFsPjeadBA56OcO86YzqM86d5T6NdLhGpa mkO0ibnt7pszrqRjdyXtrIVJNZFSnErzlSeSHBj5QQ4dl4V/mwlUPR1jP1N5126uxGjr MHRibu80CsTXXv+KudNCSE6xNQETw6fzH/L0QL+LXxSC4jbSCKzAWJ7m5e1ZHsXQXape lmp0VB+KVflrQD3qdp6mFvm+t6ZmMJKmn4q4IbP15vTSuGgE4Mm/aH3KinDXayp52TtX nNjLroYP7BCIqVCe3ZPyg2jD87XDEkfJaj7XigG/QbQsUuUx7gCDySAgFyq2TzGa+oIK +WOw== X-Gm-Message-State: AOAM532MoU2KU36dDXGSFuotleZiuk2/tjFZD/r9r9mD1V1Q8MnLfeWG e1DL/paGbUt7wzA+MubkplxyRJZk7rKuhA== X-Google-Smtp-Source: ABdhPJztuuKrWeoax9lOSe+sV32o8ATWnEby/sxicYL45xdLqhFDTxoI3+OiX+A4NUcjHSPSRlcCVg== X-Received: by 2002:ad4:44aa:: with SMTP id n10mr2327596qvt.18.1627247435900; Sun, 25 Jul 2021 14:10:35 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5449-b89b-3de4-1412.res6.spectrum.com. [2603:6081:7b01:cbda:5449:b89b:3de4:1412]) by smtp.gmail.com with ESMTPSA id d4sm11400975qty.15.2021.07.25.14.10.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Jul 2021 14:10:34 -0700 (PDT) Date: Sun, 25 Jul 2021 17:10:33 -0400 From: Tom Rini To: u-boot@lists.denx.de, Simon Glass Subject: Debugging dtoc? Message-ID: <20210725211033.GH9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zfirVZkGKm4RZN5X" Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --zfirVZkGKm4RZN5X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable So, I'm trying to fix the problem on am335x_evm (and some family configs) with needing SPL_OF_CONTROL enabled. This is mostly fine just enabling the option, except on am335x_evm itself, which is the kitchen-sink config and overflows memory. I've gone with switching to SPL_OF_PLATDATA there as am335x in general has all of the U_BOOT_DRVINFO entries it needs I believe. But, with the following patch: diff --git a/arch/arm/dts/am335x-evm-u-boot.dtsi b/arch/arm/dts/am335x-evm-= u-boot.dtsi index 4cf5f9928d58..514f682cac99 100644 --- a/arch/arm/dts/am335x-evm-u-boot.dtsi +++ b/arch/arm/dts/am335x-evm-u-boot.dtsi @@ -8,6 +8,7 @@ &l4_per { =20 segment@300000 { + u-boot,dm-pre-reloc; =20 target-module@e000 { u-boot,dm-pre-reloc; diff --git a/configs/am335x_boneblack_vboot_defconfig b/configs/am335x_bone= black_vboot_defconfig index a0baeec79edd..ffeefd1a0087 100644 --- a/configs/am335x_boneblack_vboot_defconfig +++ b/configs/am335x_boneblack_vboot_defconfig @@ -31,6 +31,7 @@ CONFIG_CMD_SPL=3Dy # CONFIG_CMD_SETEXPR is not set CONFIG_BOOTP_DNS2=3Dy CONFIG_OF_CONTROL=3Dy +CONFIG_SPL_OF_CONTROL=3Dy CONFIG_ENV_OVERWRITE=3Dy CONFIG_ENV_IS_IN_MMC=3Dy CONFIG_SYS_REDUNDAND_ENVIRONMENT=3Dy diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig index a33efff42a74..f35b2a02f56b 100644 --- a/configs/am335x_evm_defconfig +++ b/configs/am335x_evm_defconfig @@ -37,13 +37,16 @@ CONFIG_MTDIDS_DEFAULT=3D"nand0=3Dnand.0" CONFIG_MTDPARTS_DEFAULT=3D"mtdparts=3Dnand.0:128k(NAND.SPL),128k(NAND.SPL.= backup1),128k(NAND.SPL.backup2),128k(NAND.SPL.backup3),256k(NAND.u-boot-spl= -os),1m(NAND.u-boot),128k(NAND.u-boot-env),128k(NAND.u-boot-env.backup1),8m= (NAND.kernel),-(NAND.file-system)" # CONFIG_SPL_EFI_PARTITION is not set CONFIG_OF_CONTROL=3Dy +CONFIG_SPL_OF_CONTROL=3Dy CONFIG_OF_LIST=3D"am335x-evm am335x-bone am335x-boneblack am335x-evmsk am3= 35x-bonegreen am335x-icev2 am335x-pocketbeagle" +CONFIG_SPL_OF_PLATDATA=3Dy CONFIG_ENV_OVERWRITE=3Dy CONFIG_SYS_RELOC_GD_ENV_ADDR=3Dy CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=3Dy CONFIG_SPL_ENV_IS_NOWHERE=3Dy CONFIG_VERSION_VARIABLE=3Dy CONFIG_BOOTP_SEND_HOSTNAME=3Dy +# CONFIG_SPL_SIMPLE_BUS is not set CONFIG_BOOTCOUNT_LIMIT=3Dy CONFIG_CLK=3Dy CONFIG_CLK_CDCE9XX=3Dy diff --git a/configs/am335x_evm_spiboot_defconfig b/configs/am335x_evm_spib= oot_defconfig index 8f0c330674a9..4a2a56a9af9e 100644 --- a/configs/am335x_evm_spiboot_defconfig +++ b/configs/am335x_evm_spiboot_defconfig @@ -32,6 +32,7 @@ CONFIG_BOOTP_DNS2=3Dy CONFIG_CMD_MTDPARTS=3Dy # CONFIG_SPL_EFI_PARTITION is not set CONFIG_OF_CONTROL=3Dy +CONFIG_SPL_OF_CONTROL=3Dy CONFIG_OF_LIST=3D"am335x-evm am335x-bone am335x-boneblack am335x-evmsk am3= 35x-bonegreen am335x-icev2 am335x-pocketbeagle" CONFIG_ENV_OVERWRITE=3Dy # CONFIG_ENV_IS_IN_FAT is not set I get the following failure and I don't see how to debug this: DTOC spl/dts/dt-plat.c Traceback (most recent call last): File "./tools/dtoc/dtoc", line 115, in args.phase, instantiate=3Dargs.instantiate) File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platdata.py",= line 1223, in run_steps outfile.method(plat) File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platdata.py",= line 1081, in generate_plat self.output_node_plat(node) File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platdata.py",= line 1023, in output_node_plat self._output_values(node) File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platdata.py",= line 812, in _output_values self._output_prop(node, node.props[pname]) File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platdata.py",= line 798, in _output_prop self._output_list(node, prop) File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platdata.py",= line 628, in _output_list vals.append(get_value(prop.type, val)) File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platdata.py",= line 126, in get_value val =3D '%#x' % fdt_util.fdt32_to_cpu(value) File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/fdt_util.py", lin= e 28, in fdt32_to_cpu return struct.unpack('>I', val)[0] TypeError: a bytes-like object is required, not 'bool' scripts/Makefile.spl:352: recipe for target 'spl/dts/dt-plat.c' failed make[1]: *** [spl/dts/dt-plat.c] Error 1 make[1]: *** Deleting file 'spl/dts/dt-plat.c' Makefile:1999: recipe for target 'spl/u-boot-spl' failed make: *** [spl/u-boot-spl] Error 2 --=20 Tom --zfirVZkGKm4RZN5X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD900UACgkQFHw5/5Y0 tyza3Qv9F0im9bMrgCC00mueQE0LwGObB4XVs5YyNlrlGBPfBy9zgjZeWFSkraFs H8d4/LT5pzOyRiaobEaRvjVnzKUX43xgk2wgrunZ4k/nKSL50zV0rcSpC5xgyff6 5ab11yanoCzQIuAKLAHgoe2m5ts9dRhrOV6punhQgqff5AqKZZ+E54hRxL312WqN wQoTXLsD7vVMIWNpIt968iZBe5cpLmNfKXZ4a0jqSMYUxAwMuiR4JAcTritbi5mm bZB/qz8rximpwSMBv9uJSSTWSzGBfr14hKXgzz+fGNbs6OOBT4fFLbud300NqtT/ 5t81BgAAcw8xwfAHgdEvptpl2jVFOybeDwSoodZAX6rOg6eetPpdlVwuiFi8Xh0X ocbxPKBmJfEnU5cLts76vGNd1iNqPNk7+1G6aflb7gzwfD2EU1rJNBkGFEOyRiJl 3W3xIjmxJ9uqEaLoZrCi6jj6tFACq4upW8rbHcK2Pu5+dxOIfW3Yiw0G+TZQ2xG/ jrk+zys9 =FZTo -----END PGP SIGNATURE----- --zfirVZkGKm4RZN5X--