On Mon, Jul 26, 2021 at 12:06:28AM +0000, ChiaWei Wang wrote: > Hi Tom, > > > From: Tom Rini > > Sent: Saturday, July 24, 2021 8:57 PM > > > > On Tue, Jul 20, 2021 at 02:38:31PM +0800, Chia-Wei Wang wrote: > > > > > From: Joel Stanley > > > > > > Currently the FIT verification calls directly into SW implemented > > > functions to get a CRC/SHA/MD5 hash. > > > > > > This patch removes duplcated algorithm lookup and use hash_lookup_algo > > > to get the hashing function with HW accelearation supported if > > > configured. > > > > > > The MD5 direct call remains as it is not included in the hash lookup > > > table of hash.c. > > > > > > Signed-off-by: Joel Stanley > > > Signed-off-by: Chia-Wei Wang > > > > While this is a good idea, there's some required prep work. At least the > > following platforms don't compile due to this patch: > > ls1046ardb_qspi imx8mm_beacon imx8mn_beacon imx8mn_beacon_2g > > imx8mm-icore-mx8mm-ctouch2 imx8mm-icore-mx8mm-edimm2.2 > > imx8mm_evk imx8mn_ddr4_evk imx8mn_evk imx8mp_evk imx8mq_evk > > imx8mm_venice imx8mq_phanbell phycore-imx8mm phycore-imx8mp > > pico-imx8mq verdin-imx8mm mt8183_pumpkin mt8516_pumpkin mscc_jr2 > > mscc_luton mscc_ocelot mscc_serval mscc_servalt mt7620_mt7530_rfb > > mt7620_rfb mt7628_rfb > > > > Which is likely due to cases where HASH or SPL_HASH_SUPPORT are not being > > selected as it was not previously required. > > > > Thanks for the notification of this error. I will examine the code flow to figure out the root cause on these platforms. > > Meanwhile, Simon also suggested the need to add a new UCLASS_HASH to refactor the hash structure. > http://patchwork.ozlabs.org/project/uboot/patch/20210720063839.1518-4-chiawei_wang@aspeedtech.com/ > > I was wondering if I can prepare another leading patch for UCLASS_HASH and also to make sure the current codebase works fine? > After that, we can restart this patch series for Aspeed FIT booting. OK, sounds like a good plan, thanks! -- Tom