From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8185FC4338F for ; Mon, 26 Jul 2021 08:09:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F3A060F4A for ; Mon, 26 Jul 2021 08:09:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F3A060F4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 29D5582BFD; Mon, 26 Jul 2021 09:55:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id C84A582B66; Mon, 26 Jul 2021 09:55:34 +0200 (CEST) Received: from ATCSQR.andestech.com (atcsqr.andestech.com [60.248.187.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 38A8C82B66 for ; Mon, 26 Jul 2021 09:55:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (atcpcs16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id 16Q7tDWg091213; Mon, 26 Jul 2021 15:55:14 +0800 (GMT-8) (envelope-from ycliang@andestech.com) Received: from andestech.com (10.0.15.65) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Mon, 26 Jul 2021 15:55:14 +0800 Date: Mon, 26 Jul 2021 15:55:15 +0800 From: Leo Liang To: Dimitri John Ledkov CC: Subject: Re: [PATCH] qemu-riscv64_smode: fix extlinux (define preboot) Message-ID: <20210726075515.GD983@andestech.com> References: <20210723161225.47677-1-dimitri.ledkov@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210723161225.47677-1-dimitri.ledkov@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.0.15.65] X-DNSRBL: X-MAIL: ATCSQR.andestech.com 16Q7tDWg091213 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Dimitri, On Sat, Jul 24, 2021 at 12:12:25AM +0800, Dimitri John Ledkov wrote: > Commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > Kconfig") removed preboot commands in RISC-V targets and broke > extlinux support as reported by Fu Wei . > > The patch finishes migration of CONFIG_USE_PREBOOT and CONFIG_REBOOT > to Kconfig. Could you add a "Fixes" tag and a "Reported-by" tag as suggested by Bin? > > Signed-off-by: David Abdurachmanov > Signed-off-by: Dimitri John Ledkov > --- > > Original patch author is David Abdurachmanov > > Previously this was submitted in 2019 > https://patchwork.ozlabs.org/project/uboot/patch/20190821190720.4286-1-david.abdurachmanov@sifive.com/ > > Since then the sifive fu540 portion of this change was merged, but > not the qemu one. > > Submitting the qemu portion again. Without this change, qemu smode > cannot boot Ubuntu's riscv64 cloud images with extlinux.conf. > > > configs/qemu-riscv64_smode_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/qemu-riscv64_smode_defconfig b/configs/qemu-riscv64_smode_defconfig > index 0000564e41..cb674c6a75 100644 > --- a/configs/qemu-riscv64_smode_defconfig > +++ b/configs/qemu-riscv64_smode_defconfig > @@ -14,3 +14,5 @@ CONFIG_CMD_NVEDIT_EFI=y > CONFIG_OF_PRIOR_STAGE=y > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_DM_MTD=y > +CONFIG_USE_PREBOOT=y > +CONFIG_PREBOOT="setenv fdt_addr ${fdtcontroladdr}; fdt addr ${fdtcontroladdr};" The config option should be inserted using "make savedefconfig". e.g. $ make menuconfig choose the config option desired $ make savedefconfig $ cp defconfig configs/qemu-riscv64_smode_defconfig Thanks! Best regards, Leo > -- > 2.30.2 >