All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Antonio Caggiano <antonio.caggiano@collabora.com>
Cc: qemu-devel@nongnu.org, Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	vivek.kasireddy@intel.com
Subject: Re: virtio-gpu: Mapping blob resources
Date: Mon, 26 Jul 2021 10:19:21 +0200	[thread overview]
Message-ID: <20210726081921.yekhfrxg6bccvn64@sirius.home.kraxel.org> (raw)
In-Reply-To: <baf58f3a-6b82-74c4-5383-117ac51d6579@collabora.com>

On Fri, Jul 23, 2021 at 05:07:52PM +0200, Antonio Caggiano wrote:
> Awesome, thanks!
> 
> I already cherry-picked that commit. :D
> 
> I am experimenting with memory regions now. So, I created a ram subregion,
> did I use the right type for the task?

Yes, ram is correct.

> I added it to the gpu hostmem at the offset specified by the map command. I
> enabled the subregion, and then I used subregion->addr for the vkMapMemory
> call.

Hmm, no.  I'd suggest to first vkMapMemory into qemu address space, then
pass the address of the mapping to memory_region_init_ram_device_ptr().

take care,
  Gerd



  reply	other threads:[~2021-07-26  8:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 13:33 virtio-gpu: Mapping blob resources Antonio Caggiano
2021-07-23 13:52 ` Gerd Hoffmann
2021-07-23 15:07   ` Antonio Caggiano
2021-07-26  8:19     ` Gerd Hoffmann [this message]
2021-07-26 14:32       ` Antonio Caggiano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210726081921.yekhfrxg6bccvn64@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=antonio.caggiano@collabora.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tomeu.vizoso@collabora.com \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.