All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] opp: remove WARN when no valid OPPs remain
@ 2021-07-26  8:30 Michał Mirosław
  2021-07-26  9:02 ` Viresh Kumar
  0 siblings, 1 reply; 2+ messages in thread
From: Michał Mirosław @ 2021-07-26  8:30 UTC (permalink / raw)
  To: Viresh Kumar, Nishanth Menon, Stephen Boyd; +Cc: linux-pm, linux-kernel

This WARN can be triggered per-core and the stack trace is not useful.
Replace it with plain dev_err(). Fix a comment while at it.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
 drivers/opp/of.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index c582a9ca397b..01feeba78426 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -985,8 +985,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
 		}
 	}
 
-	/* There should be one of more OPP defined */
-	if (WARN_ON(!count)) {
+	/* There should be one or more OPPs defined */
+	if (!count) {
+		dev_err(dev, "%s: no supported OPPs", __func__);
 		ret = -ENOENT;
 		goto remove_static_opp;
 	}
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] opp: remove WARN when no valid OPPs remain
  2021-07-26  8:30 [PATCH] opp: remove WARN when no valid OPPs remain Michał Mirosław
@ 2021-07-26  9:02 ` Viresh Kumar
  0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2021-07-26  9:02 UTC (permalink / raw)
  To: Michał Mirosław
  Cc: Viresh Kumar, Nishanth Menon, Stephen Boyd, linux-pm, linux-kernel

On 26-07-21, 10:30, Michał Mirosław wrote:
> This WARN can be triggered per-core and the stack trace is not useful.
> Replace it with plain dev_err(). Fix a comment while at it.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
>  drivers/opp/of.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index c582a9ca397b..01feeba78426 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -985,8 +985,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
>  		}
>  	}
>  
> -	/* There should be one of more OPP defined */
> -	if (WARN_ON(!count)) {
> +	/* There should be one or more OPPs defined */
> +	if (!count) {
> +		dev_err(dev, "%s: no supported OPPs", __func__);
>  		ret = -ENOENT;
>  		goto remove_static_opp;
>  	}

Applied. Thanks.

-- 
viresh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-26  9:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26  8:30 [PATCH] opp: remove WARN when no valid OPPs remain Michał Mirosław
2021-07-26  9:02 ` Viresh Kumar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.