Thanks. Reviewed-by: Alain Volmat On Wed, Jul 14, 2021 at 03:10:04AM +0800, kernel test robot wrote: > From: kernel test robot > > drivers/spi/spi-stm32.c:915:23-25: WARNING !A || A && B is equivalent to !A || B > > > Condition !A || A && B is equivalent to !A || B. > > Generated by: scripts/coccinelle/misc/excluded_middle.cocci > > Fixes: 7ceb0b8a3ced ("spi: stm32: finalize message either on dma callback or EOT") > CC: Alain Volmat > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 8f0df15bafc1e1c92b6d96bf8ef24dd8be3aec7b > commit: 7ceb0b8a3ceddc36ae4ef1cba6c25a0e28ed65fc [1012/1340] spi: stm32: finalize message either on dma callback or EOT > :::::: branch date: 11 hours ago > :::::: commit date: 2 days ago > > spi-stm32.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/spi/spi-stm32.c > +++ b/drivers/spi/spi-stm32.c > @@ -912,8 +912,7 @@ static irqreturn_t stm32h7_spi_irq_threa > if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) > stm32h7_spi_read_rxfifo(spi); > if (!spi->cur_usedma || > - (spi->cur_usedma && (spi->cur_comm == SPI_SIMPLEX_TX || > - spi->cur_comm == SPI_3WIRE_TX))) > + (spi->cur_comm == SPI_SIMPLEX_TX || spi->cur_comm == SPI_3WIRE_TX)) > end = true; > } >