From: Tomasz Duszynski <tduszynski@marvell.com>
To: <dev@dpdk.org>, Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
Jakub Palider <jpalider@marvell.com>,
"Tomasz Duszynski" <tduszynski@marvell.com>
Cc: <thomas@monjalon.net>, <jerinj@marvell.com>
Subject: [dpdk-dev] [PATCH 3/6] raw/cnxk_bphy: don't include irq header directly
Date: Mon, 26 Jul 2021 08:58:12 -0500 [thread overview]
Message-ID: <20210726135815.81201-4-tduszynski@marvell.com> (raw)
In-Reply-To: <20210726135815.81201-1-tduszynski@marvell.com>
One should only use roc_api.h which exports all internal headers.
Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
---
drivers/common/cnxk/roc_bphy.h | 1 +
drivers/raw/cnxk_bphy/cnxk_bphy.c | 1 -
drivers/raw/cnxk_bphy/cnxk_bphy_irq.c | 1 -
3 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/common/cnxk/roc_bphy.h b/drivers/common/cnxk/roc_bphy.h
index 0579c6c443..ea3124c6aa 100644
--- a/drivers/common/cnxk/roc_bphy.h
+++ b/drivers/common/cnxk/roc_bphy.h
@@ -6,6 +6,7 @@
#define _ROC_BPHY_
#include "roc_api.h"
+#include "roc_bphy_irq.h"
struct roc_bphy {
struct plt_pci_device *pci_dev;
diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c
index 9cb3f8d332..affc5c3e83 100644
--- a/drivers/raw/cnxk_bphy/cnxk_bphy.c
+++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c
@@ -11,7 +11,6 @@
#include <rte_rawdev_pmd.h>
#include <roc_api.h>
-#include <roc_bphy_irq.h>
#include "cnxk_bphy_irq.h"
#include "rte_pmd_bphy.h"
diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_irq.c b/drivers/raw/cnxk_bphy/cnxk_bphy_irq.c
index bbcc285a7a..ac1d51777b 100644
--- a/drivers/raw/cnxk_bphy/cnxk_bphy_irq.c
+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_irq.c
@@ -7,7 +7,6 @@
#include <rte_rawdev_pmd.h>
#include <roc_api.h>
-#include <roc_bphy_irq.h>
#include "cnxk_bphy_irq.h"
--
2.25.1
next prev parent reply other threads:[~2021-07-26 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 13:58 [dpdk-dev] [PATCH 0/6] common/cnxk: sync with local codebase Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 1/6] common/cnxk: return saner error codes Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 2/6] common/cnxk: remove duplicated constant Tomasz Duszynski
2021-07-26 13:58 ` Tomasz Duszynski [this message]
2021-07-26 13:58 ` [dpdk-dev] [PATCH 4/6] common/cnxk: reduce function visibility Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 5/6] common/cnxk: align function naming Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 6/6] raw/cnxk_bphy: use named value for queue count Tomasz Duszynski
2021-09-28 9:18 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726135815.81201-4-tduszynski@marvell.com \
--to=tduszynski@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jpalider@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.