From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43145C4320E for ; Mon, 26 Jul 2021 14:37:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 276616069E for ; Mon, 26 Jul 2021 14:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234614AbhGZN4n (ORCPT ); Mon, 26 Jul 2021 09:56:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234555AbhGZN4g (ORCPT ); Mon, 26 Jul 2021 09:56:36 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 365FEC061757; Mon, 26 Jul 2021 07:37:04 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id go31so2997778ejc.6; Mon, 26 Jul 2021 07:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nnXH9OEkX6/64CRIXpm2q4YcE5R0RLwwDJpdnIFDAWY=; b=a46eeZbS67P014IPIYYEuugVBwQdVkgc3xe0nHoGpHa+CLu7h3/0rDHMm1C9u0Vaqa GG6yKIfhXq34B2c+8u8MmZz/P8VknqBLIWzPDzPE5/00VCC4jSFXgeTKTC2wGXJFy4po chD8bkSL5cNkfThbloN9qTqGuQWNoVdPsm6e0ey1QHpVLG6oAxNjaLNpThgTzEHom8O3 rlR5IsNd9LSI3RhMjDl0t54xClnANAGUaIY+79MwKaKe9CAoBzAEPbX7sz5Dq3JuoZjW XJLk4RjT0csljKhvY94qUxjlJ53IISuVPtHFebdaSySPN9o7sgHspaWRzl0/RrZs8zdI 3kTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nnXH9OEkX6/64CRIXpm2q4YcE5R0RLwwDJpdnIFDAWY=; b=WacPbHN2dhzqU17ZSg8xt8SxmWb0+2K7pswURSUUe2VI21TKu+LpS/bNw5VG/Ywa43 DJ16tbXh0gvSAQc7nxxKBFdnv+Oi/QtTO91cKjzXmWr32d3XmdBRVgH7skIyH+9uvvq3 gvIcCGOn+/BWMlIFty5K3Buiv0hJ0uvMnmeEA/bNHwzSc3/gMeiaWW3Sc0tuOUcCcvmp eydRal0uRjwcgpUu2ILC5TPbsdu6VVUr/w0E9+1HlWiv/x1UCVgpOtJUTHmUelYw8dhT jZshFOxvQkfyaV6fnQYjOcwxX7O/768fv5qmnQuUKaBfPY9vRssTEnOhORWxU+ztyXr3 FD9Q== X-Gm-Message-State: AOAM533kX5oVFCHVYzFwy4pkEFF/f6zWnsCuSta8NN16K+9CisJzmuPq YOpxuFAp5rcGuU8+vWoQaV4= X-Google-Smtp-Source: ABdhPJzWjQjZmVeAk8PLFry/T+D+4zv8qYEjpty4byCCB34i8VAjKq0MnJQSS8SoToMzbNYfSvQY0g== X-Received: by 2002:a17:906:8158:: with SMTP id z24mr17367464ejw.359.1627310222797; Mon, 26 Jul 2021 07:37:02 -0700 (PDT) Received: from skbuf ([82.76.66.29]) by smtp.gmail.com with ESMTPSA id t15sm14213464ejf.119.2021.07.26.07.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 07:37:02 -0700 (PDT) Date: Mon, 26 Jul 2021 17:37:00 +0300 From: Vladimir Oltean To: Andrew Lunn Cc: Naresh Kamboju , Vladimir Oltean , Netdev , Jakub Kicinski , "David S. Miller" , Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , Tobias Waldekranz , Roopa Prabhu , Nikolay Aleksandrov , Stephen Hemminger , bridge@lists.linux-foundation.org, Grygorii Strashko , Marek Behun , DENG Qingfang , Vadym Kochan , Taras Chornyi , Ioana Ciornei , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Claudiu Manoil , Alexandre Belloni , Horatiu Vultur , Linux-Next Mailing List , Stephen Rothwell Subject: Re: [PATCH v6 net-next 5/7] net: bridge: switchdev: let drivers inform which bridge ports are offloaded Message-ID: <20210726143700.6lszvah4jqde3o54@skbuf> References: <20210721162403.1988814-1-vladimir.oltean@nxp.com> <20210721162403.1988814-6-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello Naresh, On Mon, Jul 26, 2021 at 04:08:10PM +0200, Andrew Lunn wrote: > On Mon, Jul 26, 2021 at 07:21:20PM +0530, Naresh Kamboju wrote: > > On Wed, 21 Jul 2021 at 21:56, Vladimir Oltean wrote: > > > > > > On reception of an skb, the bridge checks if it was marked as 'already > > > forwarded in hardware' (checks if skb->offload_fwd_mark == 1), and if it > > > is, it assigns the source hardware domain of that skb based on the > > > hardware domain of the ingress port. Then during forwarding, it enforces > > > that the egress port must have a different hardware domain than the > > > ingress one (this is done in nbp_switchdev_allowed_egress). > > > [Please ignore if it is already reported] > > > > Following build error noticed on Linux next 20210723 tag > > with omap2plus_defconfig on arm architecture. > > Hi Naresh > > Please trim emails when replying. It is really annoying to have to > page down and down and down to find your part in the email, and you > always wonder if you accidentally jumped over something when paging > down at speed. I agree with what Andrew said. I've sent this patch to address the build issue you reported. Thanks. https://patchwork.kernel.org/project/netdevbpf/patch/20210726142536.1223744-1-vladimir.oltean@nxp.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nnXH9OEkX6/64CRIXpm2q4YcE5R0RLwwDJpdnIFDAWY=; b=a46eeZbS67P014IPIYYEuugVBwQdVkgc3xe0nHoGpHa+CLu7h3/0rDHMm1C9u0Vaqa GG6yKIfhXq34B2c+8u8MmZz/P8VknqBLIWzPDzPE5/00VCC4jSFXgeTKTC2wGXJFy4po chD8bkSL5cNkfThbloN9qTqGuQWNoVdPsm6e0ey1QHpVLG6oAxNjaLNpThgTzEHom8O3 rlR5IsNd9LSI3RhMjDl0t54xClnANAGUaIY+79MwKaKe9CAoBzAEPbX7sz5Dq3JuoZjW XJLk4RjT0csljKhvY94qUxjlJ53IISuVPtHFebdaSySPN9o7sgHspaWRzl0/RrZs8zdI 3kTg== Date: Mon, 26 Jul 2021 17:37:00 +0300 From: Vladimir Oltean Message-ID: <20210726143700.6lszvah4jqde3o54@skbuf> References: <20210721162403.1988814-1-vladimir.oltean@nxp.com> <20210721162403.1988814-6-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Bridge] [PATCH v6 net-next 5/7] net: bridge: switchdev: let drivers inform which bridge ports are offloaded List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Lunn Cc: Alexandre Belloni , Vladimir Oltean , Ido Schimmel , Ioana Ciornei , UNGLinuxDriver@microchip.com, Horatiu Vultur , Marek Behun , Florian Fainelli , Naresh Kamboju , bridge@lists.linux-foundation.org, Linux-Next Mailing List , Nikolay Aleksandrov , Roopa Prabhu , Jakub Kicinski , Vivien Didelot , Grygorii Strashko , Jiri Pirko , Stephen Rothwell , Vadym Kochan , DENG Qingfang , Claudiu Manoil , Lars Povlsen , Netdev , "David S. Miller" , Taras Chornyi , Steen Hegelund , Tobias Waldekranz Hello Naresh, On Mon, Jul 26, 2021 at 04:08:10PM +0200, Andrew Lunn wrote: > On Mon, Jul 26, 2021 at 07:21:20PM +0530, Naresh Kamboju wrote: > > On Wed, 21 Jul 2021 at 21:56, Vladimir Oltean wrote: > > > > > > On reception of an skb, the bridge checks if it was marked as 'already > > > forwarded in hardware' (checks if skb->offload_fwd_mark == 1), and if it > > > is, it assigns the source hardware domain of that skb based on the > > > hardware domain of the ingress port. Then during forwarding, it enforces > > > that the egress port must have a different hardware domain than the > > > ingress one (this is done in nbp_switchdev_allowed_egress). > > > [Please ignore if it is already reported] > > > > Following build error noticed on Linux next 20210723 tag > > with omap2plus_defconfig on arm architecture. > > Hi Naresh > > Please trim emails when replying. It is really annoying to have to > page down and down and down to find your part in the email, and you > always wonder if you accidentally jumped over something when paging > down at speed. I agree with what Andrew said. I've sent this patch to address the build issue you reported. Thanks. https://patchwork.kernel.org/project/netdevbpf/patch/20210726142536.1223744-1-vladimir.oltean@nxp.com/