All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Michael Nosthoff <buildroot@heine.tech>
Cc: Marcin Bis <marcin@bis.org.pl>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/bluez5_utils: expose more disable options
Date: Mon, 26 Jul 2021 23:07:16 +0200	[thread overview]
Message-ID: <20210726230716.2c7079c5@windsurf> (raw)
In-Reply-To: <20210726201244.43070-1-buildroot@heine.tech>

Hello,

(Yann, Arnout, Peter: question for you below.)

On Mon, 26 Jul 2021 22:12:42 +0200
Michael Nosthoff via buildroot <buildroot@busybox.net> wrote:

> BlueZ builds a lot of Classic BT profiles by default but allows
> to disable them. This is especially handy when only BLE is needed
> and enabled in the kernel.
> 
> Otherwise this yields warnings like this on bootup:
> 
>  profiles/network/bnep.c:bnep_init() kernel lacks bnep-protocol support
>  src/plugin.c:plugin_init() System does not support network plugin
> 
> Also it allows to disable btmon which should not be needed on
> production systems and is ~800KB in size.
> 
> Expose those options but default to 'y' to no break existing
> configurations.
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
>  package/bluez5_utils/Config.in       | 36 ++++++++++++++++++++++++
>  package/bluez5_utils/bluez5_utils.mk | 41 ++++++++++++++++++++++++++++
>  2 files changed, 77 insertions(+)

Applied to master, thanks.

Arnout, Peter, Yann: in order to preserve backward compatibility,
Michael has created those new options with a "default y". However,
while it keeps backward compatibility, it also means that all new users
will get a more bloated bluez_utils installation than is probably
necessary. Should we break our backward compatibility rule here and
drop the "default y" on those new options ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-07-26 21:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 20:12 [Buildroot] [PATCH] package/bluez5_utils: expose more disable options Michael Nosthoff via buildroot
2021-07-26 21:07 ` Thomas Petazzoni [this message]
2021-07-27 19:53   ` Arnout Vandecappelle
2021-07-27 20:19     ` Michael Nosthoff via buildroot
2021-07-28 17:00   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210726230716.2c7079c5@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=buildroot@heine.tech \
    --cc=marcin@bis.org.pl \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.