From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30805C4338F for ; Mon, 26 Jul 2021 23:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F37C560F59 for ; Mon, 26 Jul 2021 23:25:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233491AbhGZWpO (ORCPT ); Mon, 26 Jul 2021 18:45:14 -0400 Received: from mail-il1-f176.google.com ([209.85.166.176]:34601 "EHLO mail-il1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233380AbhGZWpN (ORCPT ); Mon, 26 Jul 2021 18:45:13 -0400 Received: by mail-il1-f176.google.com with SMTP id a14so10582702ila.1 for ; Mon, 26 Jul 2021 16:25:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MT4ylZQUL8zUjXo5xoBdpyFKPIyYeR5lDgFshQ2XgV4=; b=MpUJjGQ6kuNrHlJpANOwnZ1hcwb6Z9uOFuD6mXWquZYbhf+2qjkLygFGKMCPJrKiI3 8YCDsxSr13hQljf/7pF2YaBd+1dVrMcLvJVlhtORqRpSza3b58OUwIgGTDxmWg2RYaGw KJ/gFSZCQ/gUy5vB+2sdjrW+G6W/bhulSSGs5DaCJyHOG3W3rX7Y+XIG5E5kEb5DTfNV nG3922yDeUCxGJuOUFgM65chV6MBWluLXCKqKTuSevbI6xBqtqyYKRXxBg+P4M4Grobi 1ymqT93hFuc4Q2sBnYr+p9pQBpeetZlpZtjUtkUvPObfxKzRyjvaGHrCCNUFt/QptH+u Aq3g== X-Gm-Message-State: AOAM530c5TIwD1d/oTR/jUtmd76Hd3y3G3D+fSWcwK7sSWcVy4MFxGuP Z/eE4hRVLhjEy1nVUOqsKKaHQzffuA== X-Google-Smtp-Source: ABdhPJybV1QTJn5F7wJak8d/0grLF5h3EbNyDlCgdReZoM4WIRqGcy5VdThDY8w8DBuHmbVt84Bdbg== X-Received: by 2002:a92:cf05:: with SMTP id c5mr14181235ilo.196.1627341940689; Mon, 26 Jul 2021 16:25:40 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id x11sm666558ilu.3.2021.07.26.16.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 16:25:40 -0700 (PDT) Received: (nullmailer pid 1074977 invoked by uid 1000); Mon, 26 Jul 2021 23:25:37 -0000 Date: Mon, 26 Jul 2021 17:25:37 -0600 From: Rob Herring To: Marek Vasut Cc: dri-devel@lists.freedesktop.org, Laurent Pinchart , Sam Ravnborg , devicetree@vger.kernel.org Subject: Re: [PATCH V3 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select Message-ID: <20210726232537.GA1065054@robh.at.kernel.org> References: <20210726210250.531544-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210726210250.531544-1-marex@denx.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 26, 2021 at 11:02:49PM +0200, Marek Vasut wrote: > Decoder input LVDS format is a property of the decoder chip or even > its strapping. Add DT property data-mapping the same way lvds-panel > does, to define the LVDS data mapping. > > Signed-off-by: Marek Vasut > Cc: Laurent Pinchart > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: devicetree@vger.kernel.org > To: dri-devel@lists.freedesktop.org > --- > V2: - Use allOf > - Move the data-mapping to endpoint > V3: - Rebase on V2 submitted a while ago, reinstate changelog > - Drop the allOf and un-rebase on previous pclk patch > --- > .../bindings/display/bridge/lvds-codec.yaml | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 304a1367faaa7..f795c671c3ce1 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -60,6 +60,21 @@ properties: > For LVDS encoders, port 1 is the LVDS output > For LVDS decoders, port 1 is the parallel output > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# Adding this means the 'port' needs to reference '$defs/port-base' instead of 'properties/port'. Otherwise, it's going to start failing when 'unevaluatedProperties' gets implemented (appears to be soon now). > + unevaluatedProperties: false > + > + properties: > + data-mapping: > + enum: > + - jeida-18 > + - jeida-24 > + - vesa-24 > + description: | > + The color signals mapping order. See details in > + Documentation/devicetree/bindings/display/panel/lvds.yaml > + > required: > - port@0 > - port@1 > @@ -71,6 +86,22 @@ properties: > > power-supply: true > > +if: > + not: > + properties: > + compatible: > + contains: > + const: lvds-decoder > +then: > + properties: > + ports: > + properties: > + port@1: > + properties: > + endpoint: > + properties: > + data-mapping: false With this, I kind of think the schema should be split into encoder and decoder schemas. But we can leave that for the next addition... Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40004C4320A for ; Mon, 26 Jul 2021 23:25:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A1B960F59 for ; Mon, 26 Jul 2021 23:25:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A1B960F59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F9A86EA31; Mon, 26 Jul 2021 23:25:43 +0000 (UTC) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5906B6EA31 for ; Mon, 26 Jul 2021 23:25:41 +0000 (UTC) Received: by mail-il1-f170.google.com with SMTP id h18so10541668ilc.5 for ; Mon, 26 Jul 2021 16:25:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MT4ylZQUL8zUjXo5xoBdpyFKPIyYeR5lDgFshQ2XgV4=; b=GOifjkUwlQw81WczzWfmSFI/5sur3rIe214eYfbtIYvMXP+VGjVvtTsYLVaK95exQ9 B+VEq5lz7hVP0SI8vpdn35iQyjoF1Mx4kNV1MN21txGqoOFi0C1pXvy435YxWory77Wf L7k/AbCX/eILDUC3UcFBRMaDxKnPmZlPm4liNyGutQJREvTnCfCe1zaR53OeQIMyOgfA Fnq+5U1CoTybJhHORWHEIpo4q18BzFKHX0AKOXg/48pZW+y79zRfDLGYwjltwDD4kWoB gpRrMYLyCBxf9KFnMoygJPdviiDuktHH4RPh/3amLTDLv+3eDHg+HQS/kZrJ0lRwAjdd Vblg== X-Gm-Message-State: AOAM530c0Hp5yMqZ4+Kzh01mfmx8e/QOAT7WgondcvJVh998ZW0qtY4X AWeoj2c5EkvrJ32wOFjHIw== X-Google-Smtp-Source: ABdhPJybV1QTJn5F7wJak8d/0grLF5h3EbNyDlCgdReZoM4WIRqGcy5VdThDY8w8DBuHmbVt84Bdbg== X-Received: by 2002:a92:cf05:: with SMTP id c5mr14181235ilo.196.1627341940689; Mon, 26 Jul 2021 16:25:40 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id x11sm666558ilu.3.2021.07.26.16.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 16:25:40 -0700 (PDT) Received: (nullmailer pid 1074977 invoked by uid 1000); Mon, 26 Jul 2021 23:25:37 -0000 Date: Mon, 26 Jul 2021 17:25:37 -0600 From: Rob Herring To: Marek Vasut Subject: Re: [PATCH V3 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select Message-ID: <20210726232537.GA1065054@robh.at.kernel.org> References: <20210726210250.531544-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210726210250.531544-1-marex@denx.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sam Ravnborg , Laurent Pinchart , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jul 26, 2021 at 11:02:49PM +0200, Marek Vasut wrote: > Decoder input LVDS format is a property of the decoder chip or even > its strapping. Add DT property data-mapping the same way lvds-panel > does, to define the LVDS data mapping. > > Signed-off-by: Marek Vasut > Cc: Laurent Pinchart > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: devicetree@vger.kernel.org > To: dri-devel@lists.freedesktop.org > --- > V2: - Use allOf > - Move the data-mapping to endpoint > V3: - Rebase on V2 submitted a while ago, reinstate changelog > - Drop the allOf and un-rebase on previous pclk patch > --- > .../bindings/display/bridge/lvds-codec.yaml | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 304a1367faaa7..f795c671c3ce1 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -60,6 +60,21 @@ properties: > For LVDS encoders, port 1 is the LVDS output > For LVDS decoders, port 1 is the parallel output > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# Adding this means the 'port' needs to reference '$defs/port-base' instead of 'properties/port'. Otherwise, it's going to start failing when 'unevaluatedProperties' gets implemented (appears to be soon now). > + unevaluatedProperties: false > + > + properties: > + data-mapping: > + enum: > + - jeida-18 > + - jeida-24 > + - vesa-24 > + description: | > + The color signals mapping order. See details in > + Documentation/devicetree/bindings/display/panel/lvds.yaml > + > required: > - port@0 > - port@1 > @@ -71,6 +86,22 @@ properties: > > power-supply: true > > +if: > + not: > + properties: > + compatible: > + contains: > + const: lvds-decoder > +then: > + properties: > + ports: > + properties: > + port@1: > + properties: > + endpoint: > + properties: > + data-mapping: false With this, I kind of think the schema should be split into encoder and decoder schemas. But we can leave that for the next addition... Rob