From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B26EAC4320E
	for <linux-kernel@archiver.kernel.org>; Tue, 27 Jul 2021 02:42:30 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 8D77C60FEE
	for <linux-kernel@archiver.kernel.org>; Tue, 27 Jul 2021 02:42:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234606AbhG0CCB (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 26 Jul 2021 22:02:01 -0400
Received: from mail.kernel.org ([198.145.29.99]:38050 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233727AbhG0CCA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Jul 2021 22:02:00 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id B4B0D60FEB;
        Tue, 27 Jul 2021 02:42:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1627353748;
        bh=h722ui9p7cZx2trWIxgwS3kbBtiKtNTRWxfhr5joFv4=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=TmL4MuHTUBp8sGwxo68Fr0J9weoE8oOSBxduyBxdu9OgWEx8e8OqdcJGVpSPf52Wb
         1FkGEYVHWGHlakQulJSQNUmutG6wr+mPInUO+6B4ddeuSVQwfutvjzR8x7AxW66eJD
         l5lFUYFQXgC7ccdmNG1hbbJu7MQ448c8uCrP4eC7gRYiF3wGR8neXscCe2Nfm/7hKA
         MXr2GAJb/oc+56jxVJeGiAlfRqSmnx00LRDUA0F6108qudfTNdF66srWDd9zJ9yNZ3
         VF3IrQv7lI0/ZWasYfLkJkk8sqMim1hViMBTD/uVz5ygVfPjQry/ItOAOCGXtIOYCS
         7wWDNV0mkhWOw==
Date:   Tue, 27 Jul 2021 05:42:25 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc:     peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Stefan Berger <stefanb@linux.ibm.com>,
        Nayna Jain <nayna@linux.ibm.com>,
        George Wilson <gcwilson@linux.ibm.com>,
        Nageswara R Sastry <rnsastry@linux.ibm.com>
Subject: Re: [PATCH] tpm: ibmvtpm: Avoid error message when process gets
 signal while waiting
Message-ID: <20210727024225.swqy5ypcytsngpd6@kernel.org>
References: <20210712162505.205943-1-stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210712162505.205943-1-stefanb@linux.vnet.ibm.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 12, 2021 at 12:25:05PM -0400, Stefan Berger wrote:
> From: Stefan Berger <stefanb@linux.ibm.com>
> 
> When rngd is run as root then lots of these types of message will appear
> in the kernel log if the TPM has been configure to provide random bytes:
> 
> [ 7406.275163] tpm tpm0: tpm_transmit: tpm_recv: error -4
> 
> The issue is caused by the following call that is interrupted while
> waiting for the TPM's response.
> 
> sig = wait_event_interruptible(ibmvtpm->wq,
>                                !ibmvtpm->tpm_processing_cmd);
> 
> The solution is to use wait_event() instead.

Why?

/Jarkko