From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA6EC4338F for ; Tue, 27 Jul 2021 03:52:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 818D560F9E for ; Tue, 27 Jul 2021 03:52:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 818D560F9E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 707058341F; Tue, 27 Jul 2021 05:52:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gv9knttp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E3A068334E; Tue, 27 Jul 2021 05:52:03 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2E8228335E for ; Tue, 27 Jul 2021 05:51:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf31.google.com with SMTP id s14so6277838qvm.4 for ; Mon, 26 Jul 2021 20:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3l8I/xTP7CUoTABz9s50gz1Qg4ubiaMlSqnli5kik7M=; b=gv9knttpG43J+n6xOFn4+xP5V26ZsdzkyB1soJNIqhln7HFaxZMOE6ntTYVOtDFyI9 XU1Wy9VDw3e7tXIynGD4Ig2xfM0A1RAdZNRgoaYoGhVJqnn0krdcOW9G86VqsjxT60fx mPDU9lfxHeQ56Mpc6bMF4gzrBz1iZY59hsfzGuDyooMazREkRb/KG6ZkFB3oFLU1jkHf whOD1OlnWOHBo8RuIvxAqzHfry/BUmbBSbZJvn4F9/9iGAoWTFagH0cKgKHsaW9YFKFl ftKyH2VNQEtnOFw2Ef1zLg2cEps2Seg5IDkcHy8MzHqVPYOQsJNzbX1KU/fkjrdYzxNm q47w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3l8I/xTP7CUoTABz9s50gz1Qg4ubiaMlSqnli5kik7M=; b=RZZ+VCRnkF0uTreloOaJXBBAkHY1M7y12If9AR6WLrhWuw4MyyMmd9XDbOUGRVuK9Q VidVyLXgYzSgd22V3qw09bnH2ACO1peebg/7WhBD3tUB0HnEdxHYSHIxRpgz2Ed++7Xo QuSLSii05XiHI6w3aFfVXDt3h8jRSyyNMDBWiCb8KffTh7Zvan53XxKUS9yMd0LrkfAi SJWc4XtX6MlMsn+m4ec+sEluazBMtlZg2qW9uNv8NfMf9+9LyAoOeYmSL7d6sa2xkBpa 0Xat7HcxFO/e+qssUkCkcAgPDgCo4tSryzr0buY+XVyhO3IhHzMEVx4/Yn1mujjVfPht VGBw== X-Gm-Message-State: AOAM533j8vE5W9EYt3aEOBAyjXfwN/W1utrlEb8ykbsuQjcVGRnjVqS0 7/MfJehsiur0o8cZvCqJF+Gl3fyyLwY= X-Google-Smtp-Source: ABdhPJy5YTy4UjhavsE3aJ0KebYh2q+lUgcwwow1FYQfPqYuoLZG0AMM93QKK+yjKqd0Pl47wZmZyA== X-Received: by 2002:a0c:de08:: with SMTP id t8mr3401315qvk.53.1627357909923; Mon, 26 Jul 2021 20:51:49 -0700 (PDT) Received: from godwin.fios-router.home (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.gmail.com with ESMTPSA id y67sm1096211qkd.58.2021.07.26.20.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 20:51:49 -0700 (PDT) From: Sean Anderson To: u-boot@lists.denx.de, Leo Liang Cc: Lukasz Majewski , Damien Le Moal , Sean Anderson , Simon Glass Subject: [PATCH 3/4] test: dm: k210: Reduce duplication in test cases Date: Mon, 26 Jul 2021 23:51:43 -0400 Message-Id: <20210727035144.298277-3-seanga2@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210727035144.298277-1-seanga2@gmail.com> References: <20210727035144.298277-1-seanga2@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Having to copy-paste the same 3 lines makes adding new test cases error-prone. Use a macro. Signed-off-by: Sean Anderson --- test/dm/k210_pll.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/test/dm/k210_pll.c b/test/dm/k210_pll.c index 54764f269c..5574ac96fa 100644 --- a/test/dm/k210_pll.c +++ b/test/dm/k210_pll.c @@ -69,27 +69,21 @@ static int dm_test_k210_pll(struct unit_test_state *uts) &theirs)); ut_asserteq(-EINVAL, k210_pll_calc_config(1500000000, 20000000, &theirs)); + ut_asserteq(-EINVAL, k210_pll_calc_config(1750000000, 13300000, + &theirs)); /* Verify we get the same output with brute-force */ - ut_assertok(dm_test_k210_pll_calc_config(390000000, 26000000, &ours)); - ut_assertok(k210_pll_calc_config(390000000, 26000000, &theirs)); - ut_assertok(dm_test_k210_pll_compare(&ours, &theirs)); +#define compare(rate, rate_in) do { \ + ut_assertok(dm_test_k210_pll_calc_config(rate, rate_in, &ours)); \ + ut_assertok(k210_pll_calc_config(rate, rate_in, &theirs)); \ + ut_assertok(dm_test_k210_pll_compare(&ours, &theirs)); \ +} while (0) - ut_assertok(dm_test_k210_pll_calc_config(26000000, 390000000, &ours)); - ut_assertok(k210_pll_calc_config(26000000, 390000000, &theirs)); - ut_assertok(dm_test_k210_pll_compare(&ours, &theirs)); - - ut_assertok(dm_test_k210_pll_calc_config(400000000, 26000000, &ours)); - ut_assertok(k210_pll_calc_config(400000000, 26000000, &theirs)); - ut_assertok(dm_test_k210_pll_compare(&ours, &theirs)); - - ut_assertok(dm_test_k210_pll_calc_config(27000000, 26000000, &ours)); - ut_assertok(k210_pll_calc_config(27000000, 26000000, &theirs)); - ut_assertok(dm_test_k210_pll_compare(&ours, &theirs)); - - ut_assertok(dm_test_k210_pll_calc_config(26000000, 27000000, &ours)); - ut_assertok(k210_pll_calc_config(26000000, 27000000, &theirs)); - ut_assertok(dm_test_k210_pll_compare(&ours, &theirs)); + compare(390000000, 26000000); + compare(26000000, 390000000); + compare(400000000, 26000000); + compare(27000000, 26000000); + compare(26000000, 27000000); return 0; } -- 2.32.0