Re: [PATCH v4 2/2] ASoC: cs35l41: Add bindings for CS35L41

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

On Mon, Jul 26, 2021 at 05:34:38PM -0500, David Rhodes wrote:

> +  cirrus,right-channel-amp:
> +    description:
> +      Boolean to determine which channel
> +      the amplifier is to receive the audio data on. If present the
> +      amplifier receives data on the right channel of I2S data.
> +      If not present the amplifier receives data on the left
> +      channel of I2S data
> +    type: boolean

Does this need to be in the DT or could it be a runtime control (eg, for
a system that supports being rotated to adjust which speaker things go
out of).

> +  cirrus,amp-gain-zc:
> +    description:
> +      Boolean to determine whether to use the amplifier
> +      gain-change zero-crossing feature. If the feature is enabled, any
> +      user-controlled amplifier gain change will occur on a zero-crossing point.
> +      (Default) Disabled
> +    type: boolean

This is usually a runtime control too.  This applies to a bunch of the
properties TBH.

> +  cirrus,classh-bst-overide:
> +    description:
> +      Boolean which will disable Class H tracking and
> +      set Boost voltage to the value in the 'boost-ctl-millivolt' property
> +    type: boolean
> +  cirrus,classh-bst-max-limit:
> +    description:
> +      Value set to the BST_CTL_LIM_EN field.

At some point in the file we stop having a blank line between the
properties.

> +required:
> +  - compatible
> +  - cirrus,boost-peak-milliamp
> +  - cirrus,boost-ind-nanohenry
> +  - cirrus,boost-cap-microfarad

The driver has regulator support but there's no regulator properties
documented anywhere in the binding document.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]