All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-pm@vger.kernel.org
Subject: Re: [Bug 213873] New: Hotplug ethernet cable to runtime suspended Realtek NIC doesn't raise PCIe PME IRQ on Intel ADL
Date: Tue, 27 Jul 2021 10:55:12 -0500	[thread overview]
Message-ID: <20210727155512.GA716431@bjorn-Precision-5520> (raw)
In-Reply-To: <bug-213873-41252@https.bugzilla.kernel.org/>

On Tue, Jul 27, 2021 at 06:10:13AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=213873
> 
>             Bug ID: 213873
>            Summary: Hotplug ethernet cable to runtime suspended Realtek
>                     NIC doesn't raise PCIe PME IRQ on Intel ADL
>            Product: Drivers
>            Version: 2.5
>     Kernel Version: mainline
>           Hardware: All
>                 OS: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: PCI
>           Assignee: drivers_pci@kernel-bugs.osdl.org
>           Reporter: kai.heng.feng@canonical.com
>         Regression: No
> 
> Both PCIe bridge and Realtek NIC are runtime suspended. When ethernet cable is
> plugged, PMEStatus and PMEPending are marked:
> RootSta: PME ReqID 0200, PMEStatus+ PMEPending+
> 
> But the IRQ isn't raised:
> $ cat /proc/interrupts  | grep PME
>  145:          0          0          0          0          0          0        
>  0          0          0          0          0          0   VMD-MSI  126  PCIe
> PME, aerdrv, pcie-dpc
> 
> So the hotplug event isn't detected.
> 
> -- 

From the lspci after cable hotplug (comment #3):

  0000:00:1c.0 PCI bridge ...
    RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna- CRSVisible-
    RootSta: PME ReqID 0200, PMEStatus+ PMEPending+

So it looks like the root port is not enabled to generate a PME
interrupt.  pcie_pme_interrupt_enable() looks like it *could* enable
that.  From a quick look, my guess is that pme.c doesn't claim this
root port because the platform says it doesn't support it:

  acpi PNP0A08:00: _OSC: platform does not support [PCIeHotplug SHPCHotplug PME]
  acpi PNP0A08:00: _OSC: OS now controls [AER PCIeCapability LTR]

Does booting with "pcie_ports=native" make it work?  That's not a very
good solution, of course, because then both the firmware and Linux
think they own this functionality.

Is there a BIOS update that would fix this?

Bjorn

       reply	other threads:[~2021-07-27 15:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-213873-41252@https.bugzilla.kernel.org/>
2021-07-27 15:55 ` Bjorn Helgaas [this message]
2021-07-29 14:50   ` [Bug 213873] New: Hotplug ethernet cable to runtime suspended Realtek NIC doesn't raise PCIe PME IRQ on Intel ADL Kai-Heng Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210727155512.GA716431@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.