From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4660FC4338F for ; Tue, 27 Jul 2021 16:38:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31B4860551 for ; Tue, 27 Jul 2021 16:38:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229831AbhG0Qix (ORCPT ); Tue, 27 Jul 2021 12:38:53 -0400 Received: from foss.arm.com ([217.140.110.172]:41142 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbhG0Qiw (ORCPT ); Tue, 27 Jul 2021 12:38:52 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 653EC31B; Tue, 27 Jul 2021 09:38:52 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BA32D3F70D; Tue, 27 Jul 2021 09:38:50 -0700 (PDT) Date: Tue, 27 Jul 2021 17:38:45 +0100 From: Lorenzo Pieralisi To: Ard Biesheuvel Cc: Linux Kernel Mailing List , Will Deacon , Hanjun Guo , Sudeep Holla , Catalin Marinas , "Rafael J. Wysocki" , ACPI Devel Maling List , Linux ARM , Veronika kabatova , Robin Murphy Subject: Re: [PATCH] ACPI: Add memory semantics to acpi_os_map_memory() Message-ID: <20210727163845.GA16478@lpieralisi> References: <20210726100026.12538-1-lorenzo.pieralisi@arm.com> <20210727100645.GA7108@lpieralisi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jul 27, 2021 at 12:09:47PM +0200, Ard Biesheuvel wrote: [...] > > > > +void __iomem __ref > > > > +*acpi_os_map_iomem(acpi_physical_address phys, acpi_size size) > > > > > > I am aware that this just duplicated the prototype above, but I think > > > this should be > > > > > > void __iomem *__ref > > > > > > given that the __ref comes after the * in the prototype below. > > > > Yes I just moved/duplicated the prototype above but I believe this is > > consistent with include/acpi/acpi_io.h unless I have not understood > > what you meant ? > > > > It is probably worth changing it in both places to > > > > void __iomem *__ref > > > > ? > > > > I can do that with an additional patch. > > > > Yes, as long as they are all mutually consistent. The __ref is not > part of the type at all, so it should not be between the void and the > *, even if the compiler appears to allow it. Updated into a small series, will repost next week when I am back. Thanks, Lorenzo > > > > +{ > > > > + return __acpi_os_map_iomem(phys, size, false); > > > > +} > > > > EXPORT_SYMBOL_GPL(acpi_os_map_iomem); > > > > > > > > void *__ref acpi_os_map_memory(acpi_physical_address phys, acpi_size size) > > > > { > > > > - return (void *)acpi_os_map_iomem(phys, size); > > > > + return (void *)__acpi_os_map_iomem(phys, size, true); > > > > > > I think this should be (__force void *) to shut up sparse address > > > space warnings. > > > > Yes I can add that attribute in an additional patch and rebase this one > > on top of it. > > > > Thanks, > > Lorenzo > > > > > > > > > } > > > > EXPORT_SYMBOL_GPL(acpi_os_map_memory); > > > > > > > > diff --git a/include/acpi/acpi_io.h b/include/acpi/acpi_io.h > > > > index 027faa8883aa..a0212e67d6f4 100644 > > > > --- a/include/acpi/acpi_io.h > > > > +++ b/include/acpi/acpi_io.h > > > > @@ -14,6 +14,14 @@ static inline void __iomem *acpi_os_ioremap(acpi_physical_address phys, > > > > } > > > > #endif > > > > > > > > +#ifndef acpi_os_memmap > > > > +static inline void __iomem *acpi_os_memmap(acpi_physical_address phys, > > > > + acpi_size size) > > > > +{ > > > > + return ioremap_cache(phys, size); > > > > +} > > > > +#endif > > > > + > > > > extern bool acpi_permanent_mmap; > > > > > > > > void __iomem __ref > > > > -- > > > > 2.31.0 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F337C4338F for ; Tue, 27 Jul 2021 16:41:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0F7960FEA for ; Tue, 27 Jul 2021 16:41:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0F7960FEA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cqUqvQox6kswvce1VLnnRk0NefgGWk8uSsF808UnxMo=; b=QhnXxVt9Ysz9Oe WcFkNClpT503LF1gHAOwDFIogZY9EUxK7m1YJ91XycT2T1AG8Ipa0kidgWA5jzfiZTmI57xc17m0L np+a0X4bzI76DcLq3WYf18BdVrapTO1cFso1mCMEP80BFtbXk3xaOn/kJwYBgug4vMtCUqtat0thr s65nMcM3+u/r3RFzUSCc2l/UYU0GJ7rE9VmZHJV+h8sUhgBnqWnrfqeptENotgApIYab2yU6m4aR0 Lrm33ymprGVExmYwR9ip7ienCC5rS8iNtcxoKUhWb073nvqT9vJJZpANEjs2lwT2jjnnJz8mqGsR5 jmE4d5+3XqbmXxDWj1Qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8Q6d-00FOsT-BS; Tue, 27 Jul 2021 16:38:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8Q6Z-00FOro-DL for linux-arm-kernel@lists.infradead.org; Tue, 27 Jul 2021 16:38:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 653EC31B; Tue, 27 Jul 2021 09:38:52 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BA32D3F70D; Tue, 27 Jul 2021 09:38:50 -0700 (PDT) Date: Tue, 27 Jul 2021 17:38:45 +0100 From: Lorenzo Pieralisi To: Ard Biesheuvel Cc: Linux Kernel Mailing List , Will Deacon , Hanjun Guo , Sudeep Holla , Catalin Marinas , "Rafael J. Wysocki" , ACPI Devel Maling List , Linux ARM , Veronika kabatova , Robin Murphy Subject: Re: [PATCH] ACPI: Add memory semantics to acpi_os_map_memory() Message-ID: <20210727163845.GA16478@lpieralisi> References: <20210726100026.12538-1-lorenzo.pieralisi@arm.com> <20210727100645.GA7108@lpieralisi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_093855_552422_5A200E4F X-CRM114-Status: GOOD ( 29.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 27, 2021 at 12:09:47PM +0200, Ard Biesheuvel wrote: [...] > > > > +void __iomem __ref > > > > +*acpi_os_map_iomem(acpi_physical_address phys, acpi_size size) > > > > > > I am aware that this just duplicated the prototype above, but I think > > > this should be > > > > > > void __iomem *__ref > > > > > > given that the __ref comes after the * in the prototype below. > > > > Yes I just moved/duplicated the prototype above but I believe this is > > consistent with include/acpi/acpi_io.h unless I have not understood > > what you meant ? > > > > It is probably worth changing it in both places to > > > > void __iomem *__ref > > > > ? > > > > I can do that with an additional patch. > > > > Yes, as long as they are all mutually consistent. The __ref is not > part of the type at all, so it should not be between the void and the > *, even if the compiler appears to allow it. Updated into a small series, will repost next week when I am back. Thanks, Lorenzo > > > > +{ > > > > + return __acpi_os_map_iomem(phys, size, false); > > > > +} > > > > EXPORT_SYMBOL_GPL(acpi_os_map_iomem); > > > > > > > > void *__ref acpi_os_map_memory(acpi_physical_address phys, acpi_size size) > > > > { > > > > - return (void *)acpi_os_map_iomem(phys, size); > > > > + return (void *)__acpi_os_map_iomem(phys, size, true); > > > > > > I think this should be (__force void *) to shut up sparse address > > > space warnings. > > > > Yes I can add that attribute in an additional patch and rebase this one > > on top of it. > > > > Thanks, > > Lorenzo > > > > > > > > > } > > > > EXPORT_SYMBOL_GPL(acpi_os_map_memory); > > > > > > > > diff --git a/include/acpi/acpi_io.h b/include/acpi/acpi_io.h > > > > index 027faa8883aa..a0212e67d6f4 100644 > > > > --- a/include/acpi/acpi_io.h > > > > +++ b/include/acpi/acpi_io.h > > > > @@ -14,6 +14,14 @@ static inline void __iomem *acpi_os_ioremap(acpi_physical_address phys, > > > > } > > > > #endif > > > > > > > > +#ifndef acpi_os_memmap > > > > +static inline void __iomem *acpi_os_memmap(acpi_physical_address phys, > > > > + acpi_size size) > > > > +{ > > > > + return ioremap_cache(phys, size); > > > > +} > > > > +#endif > > > > + > > > > extern bool acpi_permanent_mmap; > > > > > > > > void __iomem __ref > > > > -- > > > > 2.31.0 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel