From: Jason Gunthorpe <jgg@nvidia.com>
To: "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>
Cc: Chuck Lever III <chuck.lever@oracle.com>,
Haakon Bugge <haakon.bugge@oracle.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>,
Leon Romanovsky <leonro@nvidia.com>,
Doug Ledford <dledford@redhat.com>
Subject: Re: NFS RDMA test failure as of 5.14-rc1
Date: Tue, 27 Jul 2021 14:38:57 -0300 [thread overview]
Message-ID: <20210727173857.GI1721383@nvidia.com> (raw)
In-Reply-To: <CH0PR01MB7153DE8406A68B049FC81EB6F2E99@CH0PR01MB7153.prod.exchangelabs.com>
On Tue, Jul 27, 2021 at 05:35:46PM +0000, Marciniszyn, Mike wrote:
> > > On Jul 27, 2021, at 1:14 PM, Marciniszyn, Mike
> > <mike.marciniszyn@cornelisnetworks.com> wrote:
> > >
> > >> I suspect the patch needs to be reverted or NFS RDMA needs to handle
> > >> the transition to INIT?
> >
> > If I'm reading nvmet_rdma_create_queue_ib() correctly, it invokes
> > rdma_create_qp() then posts Receives. No
> > ib_modify_qp() there.
> >
> > So some ULPs assume that rdma_create_qp() returns a new QP in the
> > IB_QPS_INIT state.
> >
> > I can't say whether that is spec compliant or even internally documented.
> >
>
> This from the spec:
>
> C10-20: A newly created QP/EE shall be placed in the Reset state.
rdma_create_qp() is a CM function, it is not covered by the spec.
The question is if there is any reasonable basis for ULPs to require
that the QP be in the INIT state after the CM creates it, or if the
ULPs should wait to post their recvs until later on in the process.
Haakon's original analysis said that this was an INIT->INIT
transition, so I'm a bit confused why we lost a RESET->INIT transition
in the end?
Jason
next prev parent reply other threads:[~2021-07-27 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 13:43 NFS RDMA test failure as of 5.14-rc1 Marciniszyn, Mike
2021-07-27 17:14 ` Marciniszyn, Mike
2021-07-27 17:26 ` Chuck Lever III
2021-07-27 17:35 ` Marciniszyn, Mike
2021-07-27 17:38 ` Jason Gunthorpe [this message]
2021-07-27 17:45 ` Chuck Lever III
2021-07-27 21:20 ` Marciniszyn, Mike
2021-07-27 23:10 ` Chuck Lever III
2021-07-28 4:31 ` Leon Romanovsky
2021-07-27 18:12 ` Leon Romanovsky
2021-07-27 20:17 ` Marciniszyn, Mike
2021-07-28 13:50 ` Marciniszyn, Mike
2021-07-28 17:05 ` Jason Gunthorpe
2021-07-29 18:28 ` Marciniszyn, Mike
2021-08-09 13:38 ` Haakon Bugge
2021-08-09 14:00 ` Chuck Lever III
2021-08-10 15:09 ` Marciniszyn, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727173857.GI1721383@nvidia.com \
--to=jgg@nvidia.com \
--cc=chuck.lever@oracle.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=haakon.bugge@oracle.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.