From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192BFC4338F for ; Tue, 27 Jul 2021 18:47:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F30960F9F for ; Tue, 27 Jul 2021 18:47:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8F30960F9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:39878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8S6e-0002ln-7V for qemu-devel@archiver.kernel.org; Tue, 27 Jul 2021 14:47:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8S5n-00023o-Ph for qemu-devel@nongnu.org; Tue, 27 Jul 2021 14:46:15 -0400 Received: from mga01.intel.com ([192.55.52.88]:21065) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8S5j-0002Kz-SA for qemu-devel@nongnu.org; Tue, 27 Jul 2021 14:46:15 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10058"; a="234379791" X-IronPort-AV: E=Sophos;i="5.84,274,1620716400"; d="scan'208";a="234379791" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2021 11:46:03 -0700 X-IronPort-AV: E=Sophos;i="5.84,274,1620716400"; d="scan'208";a="580318294" Received: from dongwonk-mobl.amr.corp.intel.com ([10.254.51.248]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2021 11:46:03 -0700 Date: Tue, 27 Jul 2021 11:46:01 -0700 From: Dongwon Kim To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Subject: Re: [PATCH 1/3] ui/gtk: adds status bar for expressing ups and fps Message-ID: <20210727184601.GA87@dongwonk-MOBL.amr.corp.intel.com> References: <20210726222551.28795-1-dongwon.kim@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Received-SPF: pass client-ip=192.55.52.88; envelope-from=dongwon.kim@intel.com; helo=mga01.intel.com X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" I found there are no such performance indicators available in Qemu/GTK. I thought this was the gap as in many fields, users want to check fps or ups to evaluate graphic or display performance in their use-cases. Thanks for your feedback!. On Tue, Jul 27, 2021 at 09:24:44AM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 26, 2021 at 03:25:49PM -0700, Dongwon Kim wrote: > > With a display option, "show-fps=on", qemu adds a status bar and print > > following performance numbers on the bar, > > > > ups = update per seconds - the rate the guest scanout is updated. > > fps = frame per seconds - the frame rate of VC's GL drawing area > > > > One function, gd_gl_count_frame is added to count # frames > > and calculate ups and fps every 100 frames or guest scanout updates. > > This feels like a pretty niche/novelty feature. Is this really > something we can justify adding to the UI, considering that it > means we will be maintaining this UI and supporting code long > term. > > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| >