From: Karel Zak <kzak@redhat.com>
To: "Krzysztof Olędzki" <ole@ans.pl>
Cc: Jens Axboe <axboe@kernel.dk>,
Sinan Kaya <sinan.kaya@microsoft.com>,
util-linux@vger.kernel.org, linux-block@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Commit d5fd456c88aba4fcf77d35fe38024a8d5c814686 - "loopdev: use LOOP_CONFIG ioctl" broke loop on x86-64 w/ 32 bit userspace
Date: Wed, 28 Jul 2021 11:14:05 +0200 [thread overview]
Message-ID: <20210728091405.cqvkgv6c2vvsmacb@ws.net.home> (raw)
In-Reply-To: <72947cba-6a12-d54f-c9c8-588729631306@ans.pl>
On Tue, Jul 27, 2021 at 10:46:06PM -0700, Krzysztof Olędzki wrote:
> So, to confirm - checking for both EINVAL and ENOTTY after LOOP_CONFIGURE is
> the proper way of taking care this?
>
> https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/lib/loopdev.c?id=d4423cce9b9001c9de7ebc6f64f6cc2bb854944c#n1362
We need both to make losetup/mount robust for already released kernels.
Fixed: https://github.com/karelzak/util-linux/commit/583990d25b5d65a9a9771a39d112de0ee16a1f3a
Thanks for your report!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2021-07-28 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 21:53 Commit d5fd456c88aba4fcf77d35fe38024a8d5c814686 - "loopdev: use LOOP_CONFIG ioctl" broke loop on x86-64 w/ 32 bit userspace Krzysztof Olędzki
2021-07-27 22:39 ` Krzysztof Olędzki
2021-07-27 22:56 ` Krzysztof Olędzki
2021-07-28 1:24 ` Jens Axboe
2021-07-28 5:46 ` Krzysztof Olędzki
2021-07-28 9:14 ` Karel Zak [this message]
2021-07-28 18:00 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728091405.cqvkgv6c2vvsmacb@ws.net.home \
--to=kzak@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ole@ans.pl \
--cc=sinan.kaya@microsoft.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.