Re: [PATCH 14/14] drm/kmb: Enable support for fbcon (framebuffer console)

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 14/14] drm/kmb: Enable support for fbcon (framebuffer console)
Date: Wed, 28 Jul 2021 12:46:02 +0800	[thread overview]
Message-ID: <202107281243.mvnV0LK8-lkp@intel.com> (raw)
In-Reply-To: <20210728003126.1425028-14-anitha.chrisanthus@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3016 bytes --]

Hi Anitha,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.14-rc3 next-20210727]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Anitha-Chrisanthus/drm-kmb-Enable-LCD-DMA-for-low-TVDDCV/20210728-083335
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm64-randconfig-r012-20210728 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c49df15c278857adecd12db6bb1cdc96885f7079)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/58e51349abb9f7085642cbdb5cf5853162be96fe
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Anitha-Chrisanthus/drm-kmb-Enable-LCD-DMA-for-low-TVDDCV/20210728-083335
        git checkout 58e51349abb9f7085642cbdb5cf5853162be96fe
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/kmb/kmb_drv.c:36:5: warning: no previous prototype for function 'kmb_display_clk_enable' [-Wmissing-prototypes]
   int kmb_display_clk_enable(struct kmb_drm_private *kmb)
       ^
   drivers/gpu/drm/kmb/kmb_drv.c:36:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int kmb_display_clk_enable(struct kmb_drm_private *kmb)
   ^
   static 
   1 warning generated.

vim +/kmb_display_clk_enable +36 drivers/gpu/drm/kmb/kmb_drv.c

    29	
    30	/* Module Parameters */
    31	static bool console;
    32	module_param(console, bool, 0400);
    33	MODULE_PARM_DESC(console,
    34			 "Enable framebuffer console support (0=disable [default], 1=on)");
    35	
  > 36	int kmb_display_clk_enable(struct kmb_drm_private *kmb)
    37	{
    38		int ret = 0;
    39	
    40		ret = clk_prepare_enable(kmb->kmb_clk.clk_lcd);
    41		if (ret) {
    42			drm_err(&kmb->drm, "Failed to enable LCD clock: %d\n", ret);
    43			return ret;
    44		}
    45		DRM_INFO("SUCCESS : enabled LCD clocks\n");
    46		return 0;
    47	}
    48	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38888 bytes --]