From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5B6DC4338F for ; Wed, 28 Jul 2021 16:10:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8EC9600D1 for ; Wed, 28 Jul 2021 16:10:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237178AbhG1QKx (ORCPT ); Wed, 28 Jul 2021 12:10:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:58552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237424AbhG1QKA (ORCPT ); Wed, 28 Jul 2021 12:10:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 944C76069E; Wed, 28 Jul 2021 16:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627488599; bh=kyZ1KJI1rvCVsOwDl/SsgMb6gh5MhG+3LuR4pAcoLeo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bctTfQbg6hhb45zejSKPM4EF4dwPXO9LmNNOcrSt74XQvCzmdxv2i57aZcTxZMdxh sIM23GgU/BkCtIS4bbsYGhOu/51wLbcRW+jKBuwG5ZICo8rzPiE81875mhGPTe+Q/W +r40gkbKslFaM1hy2s6rHv1/MpF++EckGvLxdjHDwYYw93Xd4n6Ko4whhY9yisvLlj gl33LtCmHmOfiY+uCEZAz3W8lZKrEm1OgQRUqpcfFByLyyfTgI6MThsO2xrVpvynhH IZFRzHeceysjvbed3exCnN7vzzIlK+5PsXnmXHW1NxUr9J4Dg6mQaXXomPqNK8B9Kz ViYYughdvLrbA== Date: Wed, 28 Jul 2021 17:09:48 +0100 From: Mark Brown To: Richard Fitzgerald Cc: pierre-louis.bossart@linux.intel.com, rander.wang@linux.intel.com, shumingf@realtek.com, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: dapm: Revert "use component prefix when checking widget names" Message-ID: <20210728160948.GE4670@sirena.org.uk> References: <20210703125034.24655-1-rf@opensource.cirrus.com> <20210705165041.GC4574@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Vx/N56bIaYnO6ICL" Content-Disposition: inline In-Reply-To: X-Cookie: Vini, vidi, Linux! User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Vx/N56bIaYnO6ICL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 22, 2021 at 10:55:23AM +0100, Richard Fitzgerald wrote: > I don't mind if someone wants to change the core dapm functions if that > is generally useful, providing that it also updates all callers of those > functions to still work. > Changing the behaviour of core code to fix the Realtek driver without > updating other callers of those functions is a problem. The thing here is that nobody would have thought that that any caller would have been open coding this stuff like the component things were, it's simply the wrong abstraction level to be implementing something like this so people wouldn't think of auditing the callers to find uses which might notice that prefixing suddenly worked. --Vx/N56bIaYnO6ICL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEBgUsACgkQJNaLcl1U h9BMgQf+PalyhGjExV/oRAmKS31UCcBtye8lKsXrMc+XX4t3uWdkNkEXB/Sw1HDb vmWb46mGawRE/nQvNCYFCSh2NmSVL7lz0dGvTY72/X7TEhkVx8ceFoq/VL1m8NBM eXBPu2ww5VI8i02FYPo6s/DLnA9JHhKqFZZZq6PGTZy1fAUeCqYZFoMMSAchNle4 LxDh5tO134EG151LJFTBCFKQFJsYxSW1nhznw/a9MqOnpcxacCsGzDSpGHmZ6/bm 9bLxojsH60Bfw9HhDMvUYLmznpz8uBPgr2CB21dXhQWCioAKwzv8ufol7GMTWBhD RX/6urs3NmTgXmi0ICbce5MlQFlsgw== =sHcF -----END PGP SIGNATURE----- --Vx/N56bIaYnO6ICL-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 414BEC4338F for ; Wed, 28 Jul 2021 16:11:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C79006101B for ; Wed, 28 Jul 2021 16:10:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C79006101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 96AB31FD0; Wed, 28 Jul 2021 18:10:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 96AB31FD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627488656; bh=kyZ1KJI1rvCVsOwDl/SsgMb6gh5MhG+3LuR4pAcoLeo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Q5AYdyIvELumCq9Wsk1XdePPJ2ZrVwr+6ki8AwBkvkcQz4JFhVctw3SkUrhmGzxjs fZ0dZP5t0Rz/pxMzbKzEc3nMAuoS7AyZoflbc9rlOQNM+LrsrBqqvMxM2ASFZbOZRP 9GrHpaWfY3zZeFjyl8SkJLO7bqUUO/SfTfFoKZPI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 30AFCF80253; Wed, 28 Jul 2021 18:10:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F350EF80253; Wed, 28 Jul 2021 18:10:04 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 94474F8020D for ; Wed, 28 Jul 2021 18:10:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 94474F8020D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bctTfQbg" Received: by mail.kernel.org (Postfix) with ESMTPSA id 944C76069E; Wed, 28 Jul 2021 16:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627488599; bh=kyZ1KJI1rvCVsOwDl/SsgMb6gh5MhG+3LuR4pAcoLeo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bctTfQbg6hhb45zejSKPM4EF4dwPXO9LmNNOcrSt74XQvCzmdxv2i57aZcTxZMdxh sIM23GgU/BkCtIS4bbsYGhOu/51wLbcRW+jKBuwG5ZICo8rzPiE81875mhGPTe+Q/W +r40gkbKslFaM1hy2s6rHv1/MpF++EckGvLxdjHDwYYw93Xd4n6Ko4whhY9yisvLlj gl33LtCmHmOfiY+uCEZAz3W8lZKrEm1OgQRUqpcfFByLyyfTgI6MThsO2xrVpvynhH IZFRzHeceysjvbed3exCnN7vzzIlK+5PsXnmXHW1NxUr9J4Dg6mQaXXomPqNK8B9Kz ViYYughdvLrbA== Date: Wed, 28 Jul 2021 17:09:48 +0100 From: Mark Brown To: Richard Fitzgerald Subject: Re: [PATCH] ASoC: dapm: Revert "use component prefix when checking widget names" Message-ID: <20210728160948.GE4670@sirena.org.uk> References: <20210703125034.24655-1-rf@opensource.cirrus.com> <20210705165041.GC4574@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Vx/N56bIaYnO6ICL" Content-Disposition: inline In-Reply-To: X-Cookie: Vini, vidi, Linux! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, pierre-louis.bossart@linux.intel.com, linux-kernel@vger.kernel.org, shumingf@realtek.com, rander.wang@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --Vx/N56bIaYnO6ICL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 22, 2021 at 10:55:23AM +0100, Richard Fitzgerald wrote: > I don't mind if someone wants to change the core dapm functions if that > is generally useful, providing that it also updates all callers of those > functions to still work. > Changing the behaviour of core code to fix the Realtek driver without > updating other callers of those functions is a problem. The thing here is that nobody would have thought that that any caller would have been open coding this stuff like the component things were, it's simply the wrong abstraction level to be implementing something like this so people wouldn't think of auditing the callers to find uses which might notice that prefixing suddenly worked. --Vx/N56bIaYnO6ICL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEBgUsACgkQJNaLcl1U h9BMgQf+PalyhGjExV/oRAmKS31UCcBtye8lKsXrMc+XX4t3uWdkNkEXB/Sw1HDb vmWb46mGawRE/nQvNCYFCSh2NmSVL7lz0dGvTY72/X7TEhkVx8ceFoq/VL1m8NBM eXBPu2ww5VI8i02FYPo6s/DLnA9JHhKqFZZZq6PGTZy1fAUeCqYZFoMMSAchNle4 LxDh5tO134EG151LJFTBCFKQFJsYxSW1nhznw/a9MqOnpcxacCsGzDSpGHmZ6/bm 9bLxojsH60Bfw9HhDMvUYLmznpz8uBPgr2CB21dXhQWCioAKwzv8ufol7GMTWBhD RX/6urs3NmTgXmi0ICbce5MlQFlsgw== =sHcF -----END PGP SIGNATURE----- --Vx/N56bIaYnO6ICL--