From: Steven Rostedt <rostedt@goodmis.org>
To: Kees Cook <keescook@chromium.org>
Cc: Jann Horn <jannh@google.com>, Ingo Molnar <mingo@kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Qitao Xu <qitao.xu@bytedance.com>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
Cong Wang <cong.wang@bytedance.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-hardening@vger.kernel.org
Subject: Re: tracepoints and %p [was: Re: [Patch net-next resend v2] net: use %px to print skb address in trace_netif_receive_skb]
Date: Wed, 28 Jul 2021 16:41:03 -0400 [thread overview]
Message-ID: <20210728164103.245c9db4@oasis.local.home> (raw)
In-Reply-To: <202107281146.B2160202D@keescook>
On Wed, 28 Jul 2021 11:48:11 -0700
Kees Cook <keescook@chromium.org> wrote:
> > That is exactly what is happening. I wrote the following to the replied
> > text up at the top, then noticed you basically stated the same thing
> > here ;-)
>
> Where is the %px being formatted then? If it's the kernel itself (which
> is the only thing that does %px), then it doesn't need to be %px, since
> the raw data is separate. i.e. leave it %p for whatever logs will get
> spilled out to who knows where.
The trace events shown by tracefs/trace are formatted via the kernel
sprintf() and friends, which will hash "%p".
But the raw data read to trace-cmd (and other tools), uses
libtraceevent, that parses the printf-fmt of a trace event just like
the kernel does. But since we are already in user space, it is pretty
pointless to implement "%p" with hashing. But it does understand what
"%px" is.
>
> How does ftrace interact with lockdown's confidentiality mode?
>
as Jann replied. If you enable "LOCKDOWN_TRACEFS" you lose all access
to the tracing interface.
-- Steve
prev parent reply other threads:[~2021-07-28 20:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 5:59 [Patch net-next resend v2] net: use %px to print skb address in trace_netif_receive_skb Cong Wang
2021-07-15 17:40 ` patchwork-bot+netdevbpf
2021-07-23 7:09 ` Kees Cook
2021-07-28 3:17 ` Cong Wang
2021-07-28 15:13 ` tracepoints and %p [was: Re: [Patch net-next resend v2] net: use %px to print skb address in trace_netif_receive_skb] Jann Horn
2021-07-28 15:56 ` Steven Rostedt
2021-07-28 18:48 ` Kees Cook
2021-07-28 18:56 ` Jann Horn
2021-07-28 20:41 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728164103.245c9db4@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qitao.xu@bytedance.com \
--cc=torvalds@linux-foundation.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.