From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A249470 for ; Wed, 28 Jul 2021 20:06:13 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id q17-20020a17090a2e11b02901757deaf2c8so5931718pjd.0 for ; Wed, 28 Jul 2021 13:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oOXvanqkJmFK42acZmBqNZo5yXMDDdF902WjpDqKC4A=; b=WnAwo5B+9Xwwuru6q9EGEhgLjvCcS6LlStfUh1WwP/Q5o3pUKz7vcGCwDWOMbHCf+y vwCvUj3gT/ytNsLCG8dg5cf09Qu1agFSi0hpKEXqg2yrh7+HTfbTLj0N7lTi+DwAUA+c wiR4zn4V2tQ14TJYRd7y2LPKBsbPk2OwmiRff/+J4AEDQGP5zEemUeX5fzPCV0DHnPEJ x7E6m68JxBw48tNnED7NLEn4yeWsOJrRPymcV3InL99jm6wiaqKPuC5cRewZ+ECj610+ bTHswTQoEPjOzgkuA1cbYByHodXUmieFhfZQZTyrmxbT1QxE6ymTkLGJOmpwUyi5Rht+ HcgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oOXvanqkJmFK42acZmBqNZo5yXMDDdF902WjpDqKC4A=; b=DLNuuk4dolKR112Z+qvHWtZIFVxQma0JTD5gQiaodG0bUS87WEMMyu8QAlxyH2bO45 KLFK7LEZ+AfAWhVRqm5lDjq7dagCm/OR4PUqApIFkohWE4j/FFYUxVOc/EvegkBPE6nt 9sMhYJyZg/lXGy4BMLksiMyvLAqqSgR7nvs6zx3tJiL72y3rIcEjm5g+F5Adm6aPrgKR U09qW4S7B1Du4TDQCCEw+MUqhuyvj7+lky8CL/yb7/YDZ52E2L65fSrv9ylIPncHumBs yxHBvu29SryhI3iZyj/Vy7ZtIQxcvd78cN55v4QBY5lHM+Pe6XQjviTqMetlIicZ6TfF tcRg== X-Gm-Message-State: AOAM533V8fpmovGE5YWMwwGprUlm7r7yD21dkFh2T4fhGg6SVnd1Zzj+ DPCoI0yS/KNZltj5fEgGNqI= X-Google-Smtp-Source: ABdhPJxlPnIoSUgxvNTqCOCrs1RLNXp7nKQOGGNqWBmMeOHJQEVlDU7Jpe2FJKzo2NYHKr+EBZjihA== X-Received: by 2002:a17:90a:ead4:: with SMTP id ev20mr11244312pjb.65.1627502773141; Wed, 28 Jul 2021 13:06:13 -0700 (PDT) Received: from ojas ([122.161.51.5]) by smtp.gmail.com with ESMTPSA id m11sm759503pgn.56.2021.07.28.13.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 13:06:12 -0700 (PDT) Date: Thu, 29 Jul 2021 01:36:07 +0530 From: Ojaswin Mujoo To: Greg KH Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default Message-ID: <20210728200607.GB17046@ojas> References: <70d91b0482e19d7551d3258ea54c970c1b996317.1627495116.git.ojaswin98@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jul 28, 2021 at 08:45:55PM +0200, Greg KH wrote: > On Thu, Jul 29, 2021 at 12:07:16AM +0530, Ojaswin Mujoo wrote: > > Before this config was defined, the cdev used to be created > > unconditionally. When an earlier commit introduced this config, the > > default behavior was set to disabled, which might surprise some > > unsuspecting users. Hence, make this config default to 'Y' to be more > > backward consistent. > > > > Signed-off-by: Ojaswin Mujoo > > --- > > drivers/staging/vc04_services/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig > > index 63caa6818d37..2b70c37cdd09 100644 > > --- a/drivers/staging/vc04_services/Kconfig > > +++ b/drivers/staging/vc04_services/Kconfig > > @@ -23,6 +23,7 @@ if BCM2835_VCHIQ > > > > config VCHIQ_CDEV > > bool "VCHIQ Character Driver" > > + default y > > > default y is only if the machine will not work without this option. > Is that the case here? If not, then please do not have this as the > default. Got it Greg. >From my testing, the Raspberry Pi does seem to boot correctly without this although some userspace libraries might not work. Since the machine itself works, I guess I'll drop this patch. Thank you! Ojaswin > > thanks, > > greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1300C4338F for ; Wed, 28 Jul 2021 20:08:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B468B60F5E for ; Wed, 28 Jul 2021 20:08:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B468B60F5E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ByK7OWB9Xj22lkCuMnnXWgIFaKGJO45h5Cu/6DkvKHc=; b=1GYA1Yosa04UZk L9AcqXoI4mHL6vGS9nn1+Uu8ZqOWC6Ek7yzql7fcdEFmfnyHCj+NVP9dQBjKoIStziAUVzcfYJ4K2 TEN0FzUY0Bsh0h4/lMpNAcLzgYNb7D7gzmA/3ZP5bB22ljRdsSOomMaLbqumqIRnp3fPrejG85mfS DsyLhoY3wgn3/e+Hw7Z89ZcuMmuza3OhsUqIkhGHns/zW/MQjG0lKhWpiwDieMjm2FPNrqmDXCxbm mEcrOn0WepqlbKp6jsNXji9VqDjAMxHRBTnGbnQ3EFV1HG+iW/sxbl1cqmJ3cU0H9yYiQoKkxYiZb R72pCRNmb2H5mwYaxMLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8pon-002HQ3-MA; Wed, 28 Jul 2021 20:06:17 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8pok-002HPa-6k for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 20:06:15 +0000 Received: by mail-pj1-x1034.google.com with SMTP id m2-20020a17090a71c2b0290175cf22899cso5827537pjs.2 for ; Wed, 28 Jul 2021 13:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oOXvanqkJmFK42acZmBqNZo5yXMDDdF902WjpDqKC4A=; b=WnAwo5B+9Xwwuru6q9EGEhgLjvCcS6LlStfUh1WwP/Q5o3pUKz7vcGCwDWOMbHCf+y vwCvUj3gT/ytNsLCG8dg5cf09Qu1agFSi0hpKEXqg2yrh7+HTfbTLj0N7lTi+DwAUA+c wiR4zn4V2tQ14TJYRd7y2LPKBsbPk2OwmiRff/+J4AEDQGP5zEemUeX5fzPCV0DHnPEJ x7E6m68JxBw48tNnED7NLEn4yeWsOJrRPymcV3InL99jm6wiaqKPuC5cRewZ+ECj610+ bTHswTQoEPjOzgkuA1cbYByHodXUmieFhfZQZTyrmxbT1QxE6ymTkLGJOmpwUyi5Rht+ HcgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oOXvanqkJmFK42acZmBqNZo5yXMDDdF902WjpDqKC4A=; b=h09G9WziXOH4ISZz6TE7CGt+U1WVn/iVovxJ8BWwJDpHwLT5517HA/nSI0T3TL7rDL Fi5WubR4ak2rpo3hLVf1vpW1Tzub+aLr9ontfyE5oPp616oiOkRbHHLdn9nepjPSBt97 ayIypuiCQw4CfQA+SRyM5zV7Mmt/molWqIIBHY08QGPvhVmeSscC0l+QBN3g9BYziO89 zREfxYjwNDz0C43lBWDsTvXWZaozjF6gxTol1p4rTKaC/xK9TdP7zn6DdCKwUKqQKsNw s97dgDptwKXdH5M66u9XLPWUi/a22CW8i5V7Y23KETt+xbWR8v7vFGjbII0JZSMDlDDK BysQ== X-Gm-Message-State: AOAM5326rfMUc9G2tSvjnorkWsZRFg9umyTWBEhBzFQncNfi57uDfW4x /gMolr+lhYUl034omPHH0Js= X-Google-Smtp-Source: ABdhPJxlPnIoSUgxvNTqCOCrs1RLNXp7nKQOGGNqWBmMeOHJQEVlDU7Jpe2FJKzo2NYHKr+EBZjihA== X-Received: by 2002:a17:90a:ead4:: with SMTP id ev20mr11244312pjb.65.1627502773141; Wed, 28 Jul 2021 13:06:13 -0700 (PDT) Received: from ojas ([122.161.51.5]) by smtp.gmail.com with ESMTPSA id m11sm759503pgn.56.2021.07.28.13.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 13:06:12 -0700 (PDT) Date: Thu, 29 Jul 2021 01:36:07 +0530 From: Ojaswin Mujoo To: Greg KH Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default Message-ID: <20210728200607.GB17046@ojas> References: <70d91b0482e19d7551d3258ea54c970c1b996317.1627495116.git.ojaswin98@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_130614_330942_6DCCFDDE X-CRM114-Status: GOOD ( 21.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 28, 2021 at 08:45:55PM +0200, Greg KH wrote: > On Thu, Jul 29, 2021 at 12:07:16AM +0530, Ojaswin Mujoo wrote: > > Before this config was defined, the cdev used to be created > > unconditionally. When an earlier commit introduced this config, the > > default behavior was set to disabled, which might surprise some > > unsuspecting users. Hence, make this config default to 'Y' to be more > > backward consistent. > > > > Signed-off-by: Ojaswin Mujoo > > --- > > drivers/staging/vc04_services/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig > > index 63caa6818d37..2b70c37cdd09 100644 > > --- a/drivers/staging/vc04_services/Kconfig > > +++ b/drivers/staging/vc04_services/Kconfig > > @@ -23,6 +23,7 @@ if BCM2835_VCHIQ > > > > config VCHIQ_CDEV > > bool "VCHIQ Character Driver" > > + default y > > > default y is only if the machine will not work without this option. > Is that the case here? If not, then please do not have this as the > default. Got it Greg. >From my testing, the Raspberry Pi does seem to boot correctly without this although some userspace libraries might not work. Since the machine itself works, I guess I'll drop this patch. Thank you! Ojaswin > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel