From: Tom Rini <trini@konsulko.com>
To: Artem Panfilov <panfilov.artyom@gmail.com>
Cc: "Alex G." <mr.nuke.me@gmail.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0
Date: Wed, 28 Jul 2021 19:43:51 -0400 [thread overview]
Message-ID: <20210728234351.GI9379@bill-the-cat> (raw)
In-Reply-To: <f3f76b0d-8d57-9d97-3324-0af1b845174a@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
On Thu, Jul 29, 2021 at 02:37:10AM +0300, Artem Panfilov wrote:
>
> On 29.07.2021 01:56, Tom Rini wrote:
> > Part of the question is then, were you enabling the SSL-related parts
> > before this change? Or did the way the code is now being
> > enabled/disabled trigger this now being enabled when it wasn't before?
> >
> This commit broke the build:
> https://gitlab.com/u-boot/u-boot/-/commit/cb9faa6f98ae56d70d59505dad290dd3d381cb7b
OK. How? Or rather, what part of that is causing previously unbuilt
code to now be built?
> Our testing board defconfig:
> https://gitlab.com/u-boot/u-boot/-/blob/master/configs/hsdk_defconfig
OK.
> I also found this patch that was committed 4 months ago.
> It includes OpenSSL compatibility for old versions:
> https://gitlab.com/u-boot/u-boot/-/commit/fbc777429fa35312a9ea5f106692172d3153e659
Yes, true. And that's two 1-line if/else. That's a reasonable to me
level of effort to keep supporting older hosts. Your patch is adding in
60 lines. I really do want to dig a bit more here.
And honestly, part of my concerns also go around "who is going to
maintain / test this area?". We don't have these older versions in CI
(or we would have seen the problem before merging). Are you
volunteering to support the relevant code areas here but on older
openssl/libressl ?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-07-28 23:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 18:10 [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0 Artem Panfilov
2021-07-28 19:16 ` Alex G.
[not found] ` <CAFzqoFjxO8Ox5vCyU_oXc4=a=iKR7NHEY=rgNMppQ5760DL6Kw@mail.gmail.com>
2021-07-28 20:00 ` Alex G.
2021-07-28 20:07 ` Tom Rini
2021-07-28 22:29 ` Artem Panfilov
2021-07-28 22:56 ` Tom Rini
2021-07-28 23:37 ` Artem Panfilov
2021-07-28 23:43 ` Tom Rini [this message]
2021-07-29 10:40 ` Artem Panfilov
2021-07-29 12:59 ` Tom Rini
2021-07-29 14:52 ` Artem Panfilov
2021-07-29 15:48 ` Alex G.
-- strict thread matches above, loose matches on Subject: below --
2021-07-28 18:04 Artem Panfilov
2021-07-29 5:13 ` Jonathan Gray
2021-07-31 16:59 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728234351.GI9379@bill-the-cat \
--to=trini@konsulko.com \
--cc=mr.nuke.me@gmail.com \
--cc=panfilov.artyom@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.