From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34ADFC4338F for ; Thu, 29 Jul 2021 05:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B17660FED for ; Thu, 29 Jul 2021 05:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233910AbhG2FCV (ORCPT ); Thu, 29 Jul 2021 01:02:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233739AbhG2FCS (ORCPT ); Thu, 29 Jul 2021 01:02:18 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FEC9C061757 for ; Wed, 28 Jul 2021 22:02:16 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8yBQ-0002va-Ke; Thu, 29 Jul 2021 07:02:12 +0200 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1m8yBN-0007pz-GV; Thu, 29 Jul 2021 07:02:09 +0200 Date: Thu, 29 Jul 2021 07:02:09 +0200 From: Oleksij Rempel To: Rob Herring Cc: Alexandru Tachici , netdev , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, Andrew Lunn , Heiner Kallweit , Russell King , David Miller , Jakub Kicinski Subject: Re: [PATCH v2 7/7] dt-bindings: adin1100: Add binding for ADIN1100 Ethernet PHY Message-ID: <20210729050209.5eo5hgimb5xctdn3@pengutronix.de> References: <20210712130631.38153-1-alexandru.tachici@analog.com> <20210712130631.38153-8-alexandru.tachici@analog.com> <20210727055329.7y23ob7kir3te2e4@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 07:01:31 up 238 days, 19:07, 12 users, load average: 0.04, 0.04, 0.00 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2021 at 11:23:12AM -0600, Rob Herring wrote: > On Mon, Jul 26, 2021 at 11:53 PM Oleksij Rempel wrote: > > > > On Mon, Jul 12, 2021 at 04:06:31PM +0300, alexandru.tachici@analog.com wrote: > > > From: Alexandru Tachici > > > > > > DT bindings for the ADIN1100 10BASE-T1L Ethernet PHY. > > > > > > Signed-off-by: Alexandru Tachici > > > --- > > > .../devicetree/bindings/net/adi,adin1100.yaml | 45 +++++++++++++++++++ > > > 1 file changed, 45 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/adi,adin1100.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/net/adi,adin1100.yaml b/Documentation/devicetree/bindings/net/adi,adin1100.yaml > > > new file mode 100644 > > > index 000000000000..14943164da7a > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/net/adi,adin1100.yaml > > > @@ -0,0 +1,45 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/net/adi,adin1100.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Analog Devices ADIN1100 PHY > > > + > > > +maintainers: > > > + - Alexandru Tachici > > > + > > > +description: > > > + Bindings for Analog Devices Industrial Low Power 10BASE-T1L Ethernet PHY > > > + > > > +allOf: > > > + - $ref: ethernet-phy.yaml# > > > + > > > +properties: > > > + adi,disable-2400mv-tx-level: > > > + description: > > > + Prevent ADIN1100 from using the 2.4 V pk-pk transmit level. > > > + type: boolean > > > > This property should be generic. It is defined by IEEE 802.3cg 2019 and can > > be implemented on all T1L PHYs. > > > > I assume, it should be something like: > > ethernet-phy-10base-t1l-2.4vpp-enable > > ethernet-phy-10base-t1l-2.4vpp-disable > > 'ethernet-phy-' is a bit redundant and I'd make it a tristate (not > present, 0, 1). So just '10base-t1l-2.4vpp'? > > > To overwrite bootstrapped of fuzed values if supported. The IEEE 802.3cg > > specification uses following wordings for this functionality: > > "10BASE-T1L increased transmit level request ..." sounds ok for me. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |