From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12094C4320A for ; Thu, 29 Jul 2021 05:10:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAF5260FED for ; Thu, 29 Jul 2021 05:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231329AbhG2FKJ (ORCPT ); Thu, 29 Jul 2021 01:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233607AbhG2FKI (ORCPT ); Thu, 29 Jul 2021 01:10:08 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C2F5C061757 for ; Wed, 28 Jul 2021 22:10:06 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id da26so6429067edb.1 for ; Wed, 28 Jul 2021 22:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Syc19wre6CbFsYuYVxR6wCQV/KN3Z3g3cyWjdHJsI6Y=; b=IEXpJZqtx8/txjTKkDv831jvdcvaJHllokmy+eXvmv3bqQZ0+TNSLMQoEXlh5vz2Gn pONHNXO4iZot4WSomc83GOqXszqxUEQGoo/P5ljme69XG08w0moLF4wTD6DCEGXdKJJT hSJD1CSHTZ0rVUJrMz7KfI3k1LYg+I2ekxLhm5hpJYbEzdtMvzXEZyYvogPSFd0JA1Tz upJYTvAjKe4M2KxBD/ZBT9LiRGFkYvBRMIHvJElVOYe7UdSAnhJp/lAAFGdJqocQuAIv ujcxi62WJbyTCRqqf9KIPlBftYen9QjRLfMpxvwjSkKm1iva5eJvs8IgVBfz5FxPxHsy ubGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Syc19wre6CbFsYuYVxR6wCQV/KN3Z3g3cyWjdHJsI6Y=; b=bZREyDyicCSbVYc/z3oZITzH17ZdL5Sj6Hbok0TIbWBpoqfmQGBjfBPLdryxbjpLHk 1NJwZG/eSDiWIm/irSo+vc4GH+pLLQB+a/6crpDAIZ6GELR7WY2EJzJoCvj6C6XNwtuJ QkhL8D5RfOpzlujDxh3mTxtGEqNETO09QUE5KDaxVxmrH+EWPJppwHKyc5W7jNOfs3C3 jv3vVE5aqe2uJ5IfYVCyiDq6jiFMstLBpgkj1Ub+WK0VrBbnuRAUJPUU1AENvsSxqtjG gpFmHxntk+pSOOSWbn3Z7F00OHUKvKWM+ai+1JW5bsY2sUO9rLaAFsmVEX0LlGBprEQr vuOw== X-Gm-Message-State: AOAM5334fXb3FZ84XD7CqcBd1GYcGY3VpIwi5YMPensmSQhqetP9qJvp BgMORdl6ugOqa7iDCut+JSY= X-Google-Smtp-Source: ABdhPJwkim7LFOb/Jd9cUzuAypFNivcvd1SJzW5tEiTQixmCn6eFVhHUzdJDpYJ20hWgUqEiBzxITw== X-Received: by 2002:aa7:cc83:: with SMTP id p3mr3924256edt.365.1627535404684; Wed, 28 Jul 2021 22:10:04 -0700 (PDT) Received: from oberon.zico.biz ([83.222.187.186]) by smtp.gmail.com with ESMTPSA id s20sm530615eji.116.2021.07.28.22.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 22:10:04 -0700 (PDT) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v2 03/87] tarce-cmd library: Fix version string memory leak Date: Thu, 29 Jul 2021 08:08:35 +0300 Message-Id: <20210729050959.12263-4-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210729050959.12263-1-tz.stoyanov@gmail.com> References: <20210729050959.12263-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org The version string is allocated when a VERSION option is processed, but is never freed. Free it on input hanlder close. Signed-off-by: Tzvetomir Stoyanov (VMware) --- lib/trace-cmd/trace-input.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c index 0dbcdbdc..9253bc37 100644 --- a/lib/trace-cmd/trace-input.c +++ b/lib/trace-cmd/trace-input.c @@ -3518,6 +3518,7 @@ void tracecmd_close(struct tracecmd_input *handle) free(handle->cpu_data); free(handle->uname); free(handle->trace_clock); + free(handle->version); close(handle->fd); tracecmd_free_hooks(handle->hooks); @@ -3959,6 +3960,7 @@ tracecmd_buffer_instance_handle(struct tracecmd_input *handle, int indx) new_handle->cpu_data = NULL; new_handle->nr_buffers = 0; new_handle->buffers = NULL; + new_handle->version = NULL; new_handle->ref = 1; if (handle->trace_clock) { new_handle->trace_clock = strdup(handle->trace_clock); -- 2.31.1