All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Willian Rampazzo" <willianr@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 4/9] gitlab-ci: Fix 'when:' condition in OpenSBI jobs
Date: Thu, 29 Jul 2021 10:22:06 +0200	[thread overview]
Message-ID: <20210729082211.532572-5-thuth@redhat.com> (raw)
In-Reply-To: <20210729082211.532572-1-thuth@redhat.com>

From: Philippe Mathieu-Daudé <philmd@redhat.com>

Jobs depending on another should not use the 'when: always'
condition, because if a dependency failed we should not keep
running jobs depending on it. The correct condition is
'when: on_success'.

Fixes: c6fc0fc1a71 ("gitlab-ci.yml: Add jobs to build OpenSBI firmware binaries")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-Id: <20210727142431.1672530-5-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.d/opensbi.yml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml
index d8a0456679..5e0a2477c5 100644
--- a/.gitlab-ci.d/opensbi.yml
+++ b/.gitlab-ci.d/opensbi.yml
@@ -6,14 +6,14 @@
    - .gitlab-ci.d/opensbi.yml
    # or the Dockerfile is modified
    - .gitlab-ci.d/opensbi/Dockerfile
-   when: always
+   when: on_success
  - changes: # or roms/opensbi/ is modified (submodule updated)
    - roms/opensbi/*
-   when: always
+   when: on_success
  - if: '$CI_COMMIT_REF_NAME =~ /^opensbi/' # or the branch/tag starts with 'opensbi'
-   when: always
+   when: on_success
  - if: '$CI_COMMIT_MESSAGE =~ /opensbi/i' # or last commit description contains 'OpenSBI'
-   when: always
+   when: on_success
 
 docker-opensbi:
  extends: .opensbi_job_rules
-- 
2.27.0



  parent reply	other threads:[~2021-07-29  8:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  8:22 [PULL 0/9] Gitlab-CI improvements and some other fixes Thomas Huth
2021-07-29  8:22 ` [PULL 1/9] docs: Document GitLab custom CI/CD variables Thomas Huth
2021-07-29  8:22 ` [PULL 2/9] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template Thomas Huth
2021-07-29  8:22 ` [PULL 3/9] gitlab-ci: Fix 'when:' condition in EDK2 jobs Thomas Huth
2021-07-29  8:22 ` Thomas Huth [this message]
2021-07-29  8:22 ` [PULL 5/9] gitlab-ci.d/buildtest: Disable iotests 197 and 215 Thomas Huth
2021-07-29  8:22 ` [PULL 6/9] gitlab-ci.d/buildtest: Mark the aarch64 and ppc64-s390x CFI jobs as manual Thomas Huth
2021-07-29  8:22 ` [PULL 7/9] gitlab-ci.d/custom-runners: Improve rules for the staging branch Thomas Huth
2021-07-29  8:22 ` [PULL 8/9] tests: Fix migration-test build failure for sparc Thomas Huth
2021-07-29  9:42   ` Philippe Mathieu-Daudé
2021-07-29  8:22 ` [PULL 9/9] configure script fix for Haiku Thomas Huth
2021-07-29 15:06 ` [PULL 0/9] Gitlab-CI improvements and some other fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729082211.532572-5-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.