From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 09E643483 for ; Thu, 29 Jul 2021 10:46:41 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1m92rt-00028S-00; Thu, 29 Jul 2021 12:02:21 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 6D6ABC254D; Thu, 29 Jul 2021 12:01:46 +0200 (CEST) Date: Thu, 29 Jul 2021 12:01:46 +0200 From: Thomas Bogendoerfer To: Sergio Paracuellos Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org, neil@brown.name, linux-mips@vger.kernel.org, ilya.lipnitskiy@gmail.com, john@phrozen.org Subject: Re: [PATCH v2 1/3] MIPS: ralink: Define PCI_IOBASE Message-ID: <20210729100146.GA8648@alpha.franken.de> References: <20210614100617.28753-1-sergio.paracuellos@gmail.com> <20210614100617.28753-2-sergio.paracuellos@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614100617.28753-2-sergio.paracuellos@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) On Mon, Jun 14, 2021 at 12:06:15PM +0200, Sergio Paracuellos wrote: > PCI_IOBASE is used to create VM maps for PCI I/O ports, it is > required by generic PCI drivers to make memory mapped I/O range > work. Hence define it for ralink architectures to be able to > avoid parsing manually IO ranges in PCI generic driver code. > Function 'plat_mem_setup' for ralink is using 'set_io_port_base' > call using '0xa0000000' as address, so use the same address in > the definition to align things. > > Signed-off-by: Sergio Paracuellos > --- > arch/mips/include/asm/mach-ralink/spaces.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > create mode 100644 arch/mips/include/asm/mach-ralink/spaces.h > > diff --git a/arch/mips/include/asm/mach-ralink/spaces.h b/arch/mips/include/asm/mach-ralink/spaces.h > new file mode 100644 > index 000000000000..87d085c9ad61 > --- /dev/null > +++ b/arch/mips/include/asm/mach-ralink/spaces.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef __ASM_MACH_RALINK_SPACES_H_ > +#define __ASM_MACH_RALINK_SPACES_H_ > + > +#define PCI_IOBASE _AC(0xa0000000, UL) > +#define PCI_IOSIZE SZ_16M > +#define IO_SPACE_LIMIT (PCI_IOSIZE - 1) > + > +#include > +#endif does this really work for you ? I tried the same trick for RB532 and the generated IO addresses are wrong... Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]