All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>,
	lgirdwood@gmail.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time
Date: Thu, 29 Jul 2021 12:22:46 +0100	[thread overview]
Message-ID: <20210729112246.GL4670@sirena.org.uk> (raw)
In-Reply-To: <CAKmqyKP8HKERLS3ckOA3wwpiv6J4tdFXn8-d6wXxDXDGn5iN=w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On Thu, Jul 29, 2021 at 09:20:14PM +1000, Alistair Francis wrote:
> On Tue, Jul 6, 2021 at 9:41 PM Alistair Francis <alistair@alistair23.me> wrote:
> >
> > From testing on hardware the poll_enable_time isn't required and
> > sometimes causes the driver probe to fail so let's remove it.
> >
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> 
> Ping

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-07-29 11:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 11:41 [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
2021-07-06 11:41 ` [PATCH 2/2] regulator: sy7636a: Use the parent driver data Alistair Francis
2021-07-29 11:20 ` [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
2021-07-29 11:22   ` Mark Brown [this message]
2021-07-30  6:11     ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729112246.GL4670@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.