[PATCH] smokey: posix_mutex: Fix mutex/smokey_barrier leak

[PATCH] smokey: posix_mutex: Fix mutex/smokey_barrier leak

[Florian Bezdeka]

The mutex of the smokey_barrier used inside protect_handover() was
never destroyed. This had side effects when trying to extend the test
suite with an additional function that had a mutex located on the same
address than the never cleaned up smokey_barrier lock.

Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
---
 testsuite/smokey/posix-mutex/posix-mutex.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testsuite/smokey/posix-mutex/posix-mutex.c b/testsuite/smokey/posix-mutex/posix-mutex.c
index 9a55d0973..e5793c42c 100644
--- a/testsuite/smokey/posix-mutex/posix-mutex.c
+++ b/testsuite/smokey/posix-mutex/posix-mutex.c
@@ -997,6 +997,8 @@ static int protect_handover(void)
 	if (!__T(ret, pthread_mutex_destroy(&mutex)))
 		return ret;
 
+	smokey_barrier_destroy(&barrier);
+
 	return 0;
 }
 
-- 
2.30.2

Re: [PATCH] smokey: posix_mutex: Fix mutex/smokey_barrier leak

[Jan Kiszka]

On 29.07.21 13:29, Florian Bezdeka wrote:
> The mutex of the smokey_barrier used inside protect_handover() was
> never destroyed. This had side effects when trying to extend the test
> suite with an additional function that had a mutex located on the same
> address than the never cleaned up smokey_barrier lock.
> 
> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> ---
>  testsuite/smokey/posix-mutex/posix-mutex.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/testsuite/smokey/posix-mutex/posix-mutex.c b/testsuite/smokey/posix-mutex/posix-mutex.c
> index 9a55d0973..e5793c42c 100644
> --- a/testsuite/smokey/posix-mutex/posix-mutex.c
> +++ b/testsuite/smokey/posix-mutex/posix-mutex.c
> @@ -997,6 +997,8 @@ static int protect_handover(void)
>  	if (!__T(ret, pthread_mutex_destroy(&mutex)))
>  		return ret;
>  
> +	smokey_barrier_destroy(&barrier);
> +
>  	return 0;
>  }
>  
> 

Thanks, applied.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux