From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
wg@grandegger.com, davem@davemloft.net, kuba@kernel.org,
angelo@kernel-space.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] can: flexcan: Fix an uninitialized variable issue
Date: Thu, 29 Jul 2021 14:44:42 +0300 [thread overview]
Message-ID: <20210729114442.GT1931@kadam> (raw)
In-Reply-To: <20210729113101.n5aucrwu56lyqhg7@pengutronix.de>
On Thu, Jul 29, 2021 at 01:31:01PM +0200, Marc Kleine-Budde wrote:
> On 29.07.2021 13:27:42, Christophe JAILLET wrote:
> > If both 'clk_ipg' and 'clk_per' are NULL, we return an un-init value.
> > So set 'err' to 0, to return success in such a case.
>
> Thanks for the patch, a similar one has been posted before:
> https://lore.kernel.org/linux-can/20210728075428.1493568-1-mkl@pengutronix.de/
>
> > Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > Another way to fix it is to remove the NULL checks for 'clk_ipg' and
> > 'clk_per' that been added in commit d9cead75b1c6.
> >
> > They look useless to me because 'clk_prepare_enable()' returns 0 if it is
> > passed a NULL pointer.
>
> ACK, while the common clock framework's clk_prepare_enable() can handle
> NULL pointers, the clock framework used on the mcf5441x doesn't.
Huh? It looks like it just uses the regular stuff?
regards,
dan carpenter
next prev parent reply other threads:[~2021-07-29 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 11:27 [PATCH] can: flexcan: Fix an uninitialized variable issue Christophe JAILLET
2021-07-29 11:31 ` Marc Kleine-Budde
2021-07-29 11:44 ` Dan Carpenter [this message]
2021-07-29 11:57 ` Marc Kleine-Budde
2021-07-29 12:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729114442.GT1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=angelo@kernel-space.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.