From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64FEDC4338F for ; Thu, 29 Jul 2021 13:00:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6296060F21 for ; Thu, 29 Jul 2021 12:59:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6296060F21 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DAC8181FC6; Thu, 29 Jul 2021 14:59:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AphhKbJo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 50D9F82E68; Thu, 29 Jul 2021 14:59:54 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B3AB480098 for ; Thu, 29 Jul 2021 14:59:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id az7so5812236qkb.5 for ; Thu, 29 Jul 2021 05:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R/BDR4tGJ4dUfe6ai2yTKfiwGm4kC6zvcv2aOZBjNm8=; b=AphhKbJoqadScOWPZSx5dsyxG88J5sHNSB793DbPMMzb11agg2LqPlUksF04Vk4ag7 /OBym9FD4i61PNsDcVPeCO8E6HQJFGMy7iViHMXq50Ug2u7LvdDjpnRTXStLgYcqHbIr T2i/v1Y1hfCmS8sMlipXJ7zsEm+28AjfPoi38= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R/BDR4tGJ4dUfe6ai2yTKfiwGm4kC6zvcv2aOZBjNm8=; b=VYvPrAqfAIkOhZIAEMz5wqNg176kfzUjm12W3WnGNodMsBI21f3miILD5hSZstBc7p wY3NpzDaseRc/9W4uq88iMqpxmd8dess0dabEMYu6KSJ+hWgGDEzJ6XNLKze306pSQM2 oGWkhc9A5kO3ahr7SJhSHNb5KXMX8ST6SiQxTeLW1/uv72h0nUGrPdIvQwg9g3h1qHEp ClVgSdKkS0XvlEwqMiS79cNDZHeaUvXalXw9dX83Tm1qwDlIpn7B5qwGWDoKVWbBxieN QbI9yFO9IRfLnMlaSDMQGd6AqA1AU2rCUeeZxz6Mqo8px4Zj/TLzIvgg5vRDa6v1ocaG U19Q== X-Gm-Message-State: AOAM530u/1uFVnHn1KjY1jAZDbIkooHDNSt7ejFF8nLQchxd41tEfHUG /be7PTKi90bdMVVLWkYmfmcC7g== X-Google-Smtp-Source: ABdhPJzr0PlOYo1cqTQ1rRrr1B0YjvVhaKkig4qWD6tkuNSCxqQRCCiyE2iIUB1pPO/q2S5ff9FaOg== X-Received: by 2002:a37:68d:: with SMTP id 135mr5083862qkg.253.1627563589419; Thu, 29 Jul 2021 05:59:49 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3037-3a3d-435c-0707.res6.spectrum.com. [2603:6081:7b01:cbda:3037:3a3d:435c:707]) by smtp.gmail.com with ESMTPSA id o18sm1752845qko.63.2021.07.29.05.59.48 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Jul 2021 05:59:48 -0700 (PDT) Date: Thu, 29 Jul 2021 08:59:46 -0400 From: Tom Rini To: Artem Panfilov Cc: "Alex G." , "u-boot@lists.denx.de" Subject: Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0 Message-ID: <20210729125946.GM9379@bill-the-cat> References: <20210728181023.25067-1-panfilov.artyom@gmail.com> <21fa035a-7ab5-7045-dd47-90670eb8be14@gmail.com> <20210728200701.GY9379@bill-the-cat> <34cdf0ed-c97d-e5ec-31ff-24e4ca085c4d@gmail.com> <20210728225619.GB9379@bill-the-cat> <20210728234351.GI9379@bill-the-cat> <028916da-5e0f-36d2-29bb-dccf30cfcf91@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oEj3/8+YnogYHQRs" Content-Disposition: inline In-Reply-To: <028916da-5e0f-36d2-29bb-dccf30cfcf91@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --oEj3/8+YnogYHQRs Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 29, 2021 at 01:40:41PM +0300, Artem Panfilov wrote: > On 29.07.2021 02:43, Tom Rini wrote: > > > > Yes, true.=A0 And that's two 1-line if/else.=A0 That's a reasonable to = me > > level of effort to keep supporting older hosts.=A0 Your patch is adding= in > > 60 lines.=A0 I really do want to dig a bit more here. >=20 > For me, it doesn't matter how many lines of code were added if I can't > build host tools with older OpenSSL versions. So what's the point > of keeping OpenSSL backward compatibility? Well yes, this is part of the question now, is there enough interest in the old version to bother with? The other part of the question is what's being built now that wasn't being built before, and is that a bug or a feature (a less CONFIG-dependent set of tools is good for generic distributions). > > And honestly, part of my concerns also go around "who is going to > > maintain / test this area?".=A0 We don't have these older versions in CI > > (or we would have seen the problem before merging).=A0 Are you > > volunteering to support the relevant code areas here but on older > > openssl/libressl ? >=20 > We already have a nightly Jenkins CI job that tracks u-boot master > and sends internal reports. >=20 > The best way would be to testing in the upstream azure pipeline. >=20 > You could add the following steps in your trini/u-boot-gitlab-ci-runner d= ocker image: > wget -O - https://www.openssl.org/source/old/1.0.2/openssl-1.0.2k.tar.gz = | tar -C /opt -xz && \ > cd /opt/openssl-1.0.2k/ && ./config shared && \ > make && \ > make install >=20 > In azure pipeline add new job for testing with old OpenSSL: > make tools-only_config tools-only NO_SDL=3D1 \ > HOSTLDFLAGS=3D"-ldl -L/usr/local/ssl/lib" \ > HOSTCFLAGS=3D"-I/usr/local/ssl/include" And the next time something breaks, are you going to be available to fix it? --=20 Tom --oEj3/8+YnogYHQRs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmECpj8ACgkQFHw5/5Y0 tyyHkQv/XwaYjkh5i8Vn5Y4Sw2zYlLn82FvsBegMKlFctrhWWJh7G9zFrNE8Tq21 ynYt0uWEWBCVxBm6nj5q6RGOoVQFR7PlMlzV22HA6bmlNzxI09ENb5rbqpgq9r84 A9i602UL5wq+mNK2pm/JHSlk2gWMuFnpqnzyfcjai26S+J9IaCEm1zcBlSQJwNZR kjONIUqB+GRvHKpBDE4Ctsg5gWbrD5WTiO8qjSE/coablMFbNKa/4uxZIXNB2j4G wWAA/7z9oUt8YyNApP3kG5nzn0O9je2Waje4XWiZNIvjAg8Ny1bP23sz7N6DZxT6 7R3/4d5OQPUexAvUZCi9vm3leqC/VIKfLk6+3KMTCNHbTSqoBfbSpzkLJNY9BHpO 9UyfqIHjXAmlydHlKbZVOmGB7XgXrBRXx9qBq4GXZ+eQUtNfqOa37sfesA570KsX S0k68vOrRr1ZTLZzfaySwoUWEmvcD3caU7dyssmd4U6muITZpI2wKpyb2DJXFvYt hiwYfHKe =Mnk+ -----END PGP SIGNATURE----- --oEj3/8+YnogYHQRs--