All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] doc: bitbake-user-manual: grammar fix for the number of "metadata"
       [not found] <16964500F28F0291.7588@lists.openembedded.org>
@ 2021-07-29 13:13 ` Michael Opdenacker
  2021-07-29 13:51   ` [docs] " Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Opdenacker @ 2021-07-29 13:13 UTC (permalink / raw)
  To: bitbake-devel; +Cc: docs, Michael Opdenacker, Quentin Schulz

"metadata" is used both as singular and as plural.
The first change fixes a case in which the verb has a singular conjugation
but absence of article indicates a plural case.

The second and third changes are for consistency with the first one inside
the same paragraph.

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Reviewed-by: Quentin Schulz <foss@0leil.net>
---
 doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
index eb140665..55effc35 100644
--- a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
+++ b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
@@ -27,11 +27,11 @@ Linux software stacks using a task-oriented approach.
 Conceptually, BitBake is similar to GNU Make in some regards but has
 significant differences:
 
--  BitBake executes tasks according to provided metadata that builds up
-   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
+-  BitBake executes tasks according to provided metadata that build up
+   the tasks. Metadata are stored in recipe (``.bb``) and related recipe
    "append" (``.bbappend``) files, configuration (``.conf``) and
    underlying include (``.inc``) files, and in class (``.bbclass``)
-   files. The metadata provides BitBake with instructions on what tasks
+   files. The metadata provide BitBake with instructions on what tasks
    to run and the dependencies between those tasks.
 
 -  BitBake includes a fetcher library for obtaining source code from
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [docs] [PATCH v2] doc: bitbake-user-manual: grammar fix for the number of "metadata"
  2021-07-29 13:13 ` [PATCH v2] doc: bitbake-user-manual: grammar fix for the number of "metadata" Michael Opdenacker
@ 2021-07-29 13:51   ` Richard Purdie
  2021-07-29 14:00     ` [bitbake-devel] " Michael Opdenacker
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2021-07-29 13:51 UTC (permalink / raw)
  To: Michael Opdenacker, bitbake-devel; +Cc: docs, Quentin Schulz

On Thu, 2021-07-29 at 15:13 +0200, Michael Opdenacker wrote:
> "metadata" is used both as singular and as plural.
> The first change fixes a case in which the verb has a singular conjugation
> but absence of article indicates a plural case.
> 
> The second and third changes are for consistency with the first one inside
> the same paragraph.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> Reviewed-by: Quentin Schulz <foss@0leil.net>
> ---
>  doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
> index eb140665..55effc35 100644
> --- a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
> +++ b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
> @@ -27,11 +27,11 @@ Linux software stacks using a task-oriented approach.
>  Conceptually, BitBake is similar to GNU Make in some regards but has
>  significant differences:
>  
> 
> --  BitBake executes tasks according to provided metadata that builds up
> -   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
> +-  BitBake executes tasks according to provided metadata that build up
> +   the tasks. Metadata are stored in recipe (``.bb``) and related recipe
>     "append" (``.bbappend``) files, configuration (``.conf``) and
>     underlying include (``.inc``) files, and in class (``.bbclass``)
> -   files. The metadata provides BitBake with instructions on what tasks
> +   files. The metadata provide BitBake with instructions on what tasks
>     to run and the dependencies between those tasks.

This change doesn't sound like an improvement to me. I would always say 
"The metadata provides", not what you have here which doesn't read 
correctly to me. "builds up" also sounds better to me than "build up". I'd
also say "Metadata is" sounds more correct too.

I'm not sure I like the original wording but this doesn't sound right, at
least to me.

Cheers,

Richard





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [bitbake-devel] [docs] [PATCH v2] doc: bitbake-user-manual: grammar fix for the number of "metadata"
  2021-07-29 13:51   ` [docs] " Richard Purdie
@ 2021-07-29 14:00     ` Michael Opdenacker
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Opdenacker @ 2021-07-29 14:00 UTC (permalink / raw)
  To: Richard Purdie, bitbake-devel; +Cc: docs, Quentin Schulz

Hi Richard,

On 7/29/21 3:51 PM, Richard Purdie wrote:
> On Thu, 2021-07-29 at 15:13 +0200, Michael Opdenacker wrote:
>> "metadata" is used both as singular and as plural.
>> The first change fixes a case in which the verb has a singular conjugation
>> but absence of article indicates a plural case.
>>
>> The second and third changes are for consistency with the first one inside
>> the same paragraph.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> Reviewed-by: Quentin Schulz <foss@0leil.net>
>> ---
>>  doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
>> index eb140665..55effc35 100644
>> --- a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
>> +++ b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
>> @@ -27,11 +27,11 @@ Linux software stacks using a task-oriented approach.
>>  Conceptually, BitBake is similar to GNU Make in some regards but has
>>  significant differences:
>>  
>>
>> --  BitBake executes tasks according to provided metadata that builds up
>> -   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
>> +-  BitBake executes tasks according to provided metadata that build up
>> +   the tasks. Metadata are stored in recipe (``.bb``) and related recipe
>>     "append" (``.bbappend``) files, configuration (``.conf``) and
>>     underlying include (``.inc``) files, and in class (``.bbclass``)
>> -   files. The metadata provides BitBake with instructions on what tasks
>> +   files. The metadata provide BitBake with instructions on what tasks
>>     to run and the dependencies between those tasks.
> This change doesn't sound like an improvement to me. I would always say 
> "The metadata provides", not what you have here which doesn't read 
> correctly to me. "builds up" also sounds better to me than "build up". I'd
> also say "Metadata is" sounds more correct too.
>
> I'm not sure I like the original wording but this doesn't sound right, at
> least to me.


Many thanks for the review. I know what to update then :)
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-29 14:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <16964500F28F0291.7588@lists.openembedded.org>
2021-07-29 13:13 ` [PATCH v2] doc: bitbake-user-manual: grammar fix for the number of "metadata" Michael Opdenacker
2021-07-29 13:51   ` [docs] " Richard Purdie
2021-07-29 14:00     ` [bitbake-devel] " Michael Opdenacker

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.