From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58285C432BE for ; Thu, 29 Jul 2021 13:22:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A106C60184 for ; Thu, 29 Jul 2021 13:22:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A106C60184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E7F7082E7A; Thu, 29 Jul 2021 15:22:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rzITxXQ4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9FCBE82E7A; Thu, 29 Jul 2021 15:22:17 +0200 (CEST) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B583282E23 for ; Thu, 29 Jul 2021 15:22:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id 190so5853210qkk.12 for ; Thu, 29 Jul 2021 06:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=51jd2DTZWQnkJM4he/5pV7OzNJ0OEoQaWWK0Ub5CZng=; b=rzITxXQ4r9l37aTGBvFFaTTeLRF/xi33j/G5hJFbmhlB44BRTot3SDwVa6kipXR7tU W4GyEyUwrJRZZErIAvB8QUoDJExkEf3KaU7eXJD2TADGNLDoFxmemz6WTGbpOhrIHcGW ZbqdbeoKvc4ZiJPiiJZkKBGBtIObpBUCVk6h0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=51jd2DTZWQnkJM4he/5pV7OzNJ0OEoQaWWK0Ub5CZng=; b=IVgehI6Z7mbSDMa3LRbENnfznIa1sn9gLz/aGOCkFb0nFdl3c036NhrlFRlAV1wEx9 KFjuZkT9RMSjgn3af9nMRCx4l0wyjk3AnA5Jwdd37oV1CGqU7a47aQTEtne17i/o6xhn lkPlomAqBQcCVhhs9XaswWo/OzPkjU+6d/lHsP76KWgcasjd98CAEr9RDikletNajuYz Gbv9N9tnyPV0vmd61l5ww6SrZMCgDBHnfMmphL7dtPz7t5E5wMUNtxNXZ8MPsFf7C1v4 sDRZYBx+/r8ibrb4NRazdTvreDxQRpATIRdeLZoDGQ0pMantDxrzNX62gizdlY4p+a44 FG9A== X-Gm-Message-State: AOAM5303whHWk4VlvZrZrAXoA4Hoj9S3xuXBlK/8sLfFZPW//P1sP4eA /md1kguv84oBX8eiWKKuCTLgGg== X-Google-Smtp-Source: ABdhPJwqpm7sX9TwMKDjQUX12j4k6qyyTUvhCQwN7nVjKFkjiaDcsQ8cKkgYNa1GRcGKAbunLB1goA== X-Received: by 2002:a37:a20d:: with SMTP id l13mr5055034qke.83.1627564932292; Thu, 29 Jul 2021 06:22:12 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3037-3a3d-435c-0707.res6.spectrum.com. [2603:6081:7b01:cbda:3037:3a3d:435c:707]) by smtp.gmail.com with ESMTPSA id 5sm1748821qko.53.2021.07.29.06.22.11 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Jul 2021 06:22:11 -0700 (PDT) Date: Thu, 29 Jul 2021 09:22:09 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List Subject: Re: Debugging dtoc? Message-ID: <20210729132209.GN9379@bill-the-cat> References: <20210725211033.GH9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cq6xAZHFTWWzDscG" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --cq6xAZHFTWWzDscG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 28, 2021 at 07:27:08PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Wed, 28 Jul 2021 at 17:28, Simon Glass wrote: > > > > Hi again, > > > > On Mon, 26 Jul 2021 at 08:06, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > On Sun, 25 Jul 2021 at 15:10, Tom Rini wrote: > > > > > > > > So, I'm trying to fix the problem on am335x_evm (and some family > > > > configs) with needing SPL_OF_CONTROL enabled. This is mostly fine = just > > > > enabling the option, except on am335x_evm itself, which is the > > > > kitchen-sink config and overflows memory. I've gone with switching= to > > > > SPL_OF_PLATDATA there as am335x in general has all of the U_BOOT_DR= VINFO > > > > entries it needs I believe. But, with the following patch: > > > > > > > > diff --git a/arch/arm/dts/am335x-evm-u-boot.dtsi b/arch/arm/dts/am3= 35x-evm-u-boot.dtsi > > > > index 4cf5f9928d58..514f682cac99 100644 > > > > --- a/arch/arm/dts/am335x-evm-u-boot.dtsi > > > > +++ b/arch/arm/dts/am335x-evm-u-boot.dtsi > > > > @@ -8,6 +8,7 @@ > > > > &l4_per { > > > > > > > > segment@300000 { > > > > + u-boot,dm-pre-reloc; > > > > > > > > target-module@e000 { > > > > u-boot,dm-pre-reloc; > > > > diff --git a/configs/am335x_boneblack_vboot_defconfig b/configs/am3= 35x_boneblack_vboot_defconfig > > > > index a0baeec79edd..ffeefd1a0087 100644 > > > > --- a/configs/am335x_boneblack_vboot_defconfig > > > > +++ b/configs/am335x_boneblack_vboot_defconfig > > > > @@ -31,6 +31,7 @@ CONFIG_CMD_SPL=3Dy > > > > # CONFIG_CMD_SETEXPR is not set > > > > CONFIG_BOOTP_DNS2=3Dy > > > > CONFIG_OF_CONTROL=3Dy > > > > +CONFIG_SPL_OF_CONTROL=3Dy > > > > CONFIG_ENV_OVERWRITE=3Dy > > > > CONFIG_ENV_IS_IN_MMC=3Dy > > > > CONFIG_SYS_REDUNDAND_ENVIRONMENT=3Dy > > > > diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defc= onfig > > > > index a33efff42a74..f35b2a02f56b 100644 > > > > --- a/configs/am335x_evm_defconfig > > > > +++ b/configs/am335x_evm_defconfig > > > > @@ -37,13 +37,16 @@ CONFIG_MTDIDS_DEFAULT=3D"nand0=3Dnand.0" > > > > CONFIG_MTDPARTS_DEFAULT=3D"mtdparts=3Dnand.0:128k(NAND.SPL),128k(N= AND.SPL.backup1),128k(NAND.SPL.backup2),128k(NAND.SPL.backup3),256k(NAND.u-= boot-spl-os),1m(NAND.u-boot),128k(NAND.u-boot-env),128k(NAND.u-boot-env.bac= kup1),8m(NAND.kernel),-(NAND.file-system)" > > > > # CONFIG_SPL_EFI_PARTITION is not set > > > > CONFIG_OF_CONTROL=3Dy > > > > +CONFIG_SPL_OF_CONTROL=3Dy > > > > CONFIG_OF_LIST=3D"am335x-evm am335x-bone am335x-boneblack am335x-e= vmsk am335x-bonegreen am335x-icev2 am335x-pocketbeagle" > > > > +CONFIG_SPL_OF_PLATDATA=3Dy > > > > CONFIG_ENV_OVERWRITE=3Dy > > > > CONFIG_SYS_RELOC_GD_ENV_ADDR=3Dy > > > > CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=3Dy > > > > CONFIG_SPL_ENV_IS_NOWHERE=3Dy > > > > CONFIG_VERSION_VARIABLE=3Dy > > > > CONFIG_BOOTP_SEND_HOSTNAME=3Dy > > > > +# CONFIG_SPL_SIMPLE_BUS is not set > > > > CONFIG_BOOTCOUNT_LIMIT=3Dy > > > > CONFIG_CLK=3Dy > > > > CONFIG_CLK_CDCE9XX=3Dy > > > > diff --git a/configs/am335x_evm_spiboot_defconfig b/configs/am335x_= evm_spiboot_defconfig > > > > index 8f0c330674a9..4a2a56a9af9e 100644 > > > > --- a/configs/am335x_evm_spiboot_defconfig > > > > +++ b/configs/am335x_evm_spiboot_defconfig > > > > @@ -32,6 +32,7 @@ CONFIG_BOOTP_DNS2=3Dy > > > > CONFIG_CMD_MTDPARTS=3Dy > > > > # CONFIG_SPL_EFI_PARTITION is not set > > > > CONFIG_OF_CONTROL=3Dy > > > > +CONFIG_SPL_OF_CONTROL=3Dy > > > > CONFIG_OF_LIST=3D"am335x-evm am335x-bone am335x-boneblack am335x-e= vmsk am335x-bonegreen am335x-icev2 am335x-pocketbeagle" > > > > CONFIG_ENV_OVERWRITE=3Dy > > > > # CONFIG_ENV_IS_IN_FAT is not set > > > > > > > > I get the following failure and I don't see how to debug this: > > > > DTOC spl/dts/dt-plat.c > > > > Traceback (most recent call last): > > > > File "./tools/dtoc/dtoc", line 115, in > > > > args.phase, instantiate=3Dargs.instantiate) > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platd= ata.py", line 1223, in run_steps > > > > outfile.method(plat) > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platd= ata.py", line 1081, in generate_plat > > > > self.output_node_plat(node) > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platd= ata.py", line 1023, in output_node_plat > > > > self._output_values(node) > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platd= ata.py", line 812, in _output_values > > > > self._output_prop(node, node.props[pname]) > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platd= ata.py", line 798, in _output_prop > > > > self._output_list(node, prop) > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platd= ata.py", line 628, in _output_list > > > > vals.append(get_value(prop.type, val)) > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/dtb_platd= ata.py", line 126, in get_value > > > > val =3D '%#x' % fdt_util.fdt32_to_cpu(value) > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc/fdt_util.= py", line 28, in fdt32_to_cpu > > > > return struct.unpack('>I', val)[0] > > > > TypeError: a bytes-like object is required, not 'bool' > > > > scripts/Makefile.spl:352: recipe for target 'spl/dts/dt-plat.c' fai= led > > > > make[1]: *** [spl/dts/dt-plat.c] Error 1 > > > > make[1]: *** Deleting file 'spl/dts/dt-plat.c' > > > > Makefile:1999: recipe for target 'spl/u-boot-spl' failed > > > > make: *** [spl/u-boot-spl] Error 2 > > > > > > That seems like a bug, where perhaps it is seeing a property with no > > > value so it thinks it is a bool, but then somehow tries to gets its > > > int value. > > > > > > I added a print to _output_list() > > > > > > else: > > > print('node', node.path, prop.name) > > > for val in prop.value: > > > vals.append(get_value(prop.type, val)) > > > > > > and see that it is the 'ranges' property. Definitely seems like a bug > > > but I'll have to dig into it I think. The Prop() class selects a bool > > > type when the value is empty, but somehow that isn't happening. > > > > This is actually a little tricky, but I'm looking at it. >=20 > OK I think I have figured this out. I sent a series. That gets everything building, thanks! It also shows that some parts of the kitchen-sink config there depend on OF_CONTROL features, really. What I'm going to prove out next (but will require a little bit of time due to having to set up lab stuff and dig out notes) is that for this case, we can just go with however ROM configured the PHY. We were also still over SRAM space, with PLATDATA enabled too. --=20 Tom --cq6xAZHFTWWzDscG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmECq3YACgkQFHw5/5Y0 tyxCxwwAupcetIt6LiG2lhkf25KnrkVcpIVgp+6gH1+3popPTiAyFwdNjneCGNix HwA8IjM+ccpvMVSWq+Ae1lST631essRJHjeikxrqgTrVWJJtO05yLATpi9DdBvXv HN8rV+YuSVX8Biz4sP/iVINzDFRDAqPHxHjOA7VWEWT5M1yxYtn0h7pCJwIpQvwW 2Uj1uJH3g2Tqmsv/MFxlMuCcQk6jyJ++hrjc3URxH+D7aXUxCWBjFk46tQIkqb9p Kw5pfdUUc65aPwGEUVGo8way6e7x/kezd3fvEZwZDepVJJLWxushAFyzOHsNul73 h1JQdt7afcLKFHzkxKvhpXEmvDYFXCqC6AhbURPr/3MV6amST+4L6XFUmpX8BfS7 s9Y3CM+4Sg0yomxWE1RF+0fx97PjT7ThdNiyD2P/QiytbTjL063vMR+jM1JLOCkp qOOquZ6Xrcwn7vVjVgEdShjho0E+5H52AivnVWGRHpTxK0EIkg0Npo3YhBbj68WR guoBX2Od =rysU -----END PGP SIGNATURE----- --cq6xAZHFTWWzDscG--