From: Mark Brown <broonie@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] arm64/sve: Delay freeing memory in fpsimd_flush_thread()
Date: Thu, 29 Jul 2021 15:26:16 +0100 [thread overview]
Message-ID: <20210729142616.GO4670@sirena.org.uk> (raw)
In-Reply-To: <20210729105215.2222338-2-bigeasy@linutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 423 bytes --]
On Thu, Jul 29, 2021 at 12:52:14PM +0200, Sebastian Andrzej Siewior wrote:
> +static void *sve_free_atomic(struct task_struct *task)
> +{
> + void *sve_state = task->thread.sve_state;
> +
> + WARN_ON(test_tsk_thread_flag(task, TIF_SVE));
> +
> + task->thread.sve_state = NULL;
> + return sve_state;
> +}
This has exactly one caller - why not just inline it there? It'd
probably make it easier to follow what's going on.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-29 14:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 10:52 arm64/sve: Two PREEMPT_RT related arm64 fixes Sebastian Andrzej Siewior
2021-07-29 10:52 ` [PATCH] arm64/sve: Delay freeing memory in fpsimd_flush_thread() Sebastian Andrzej Siewior
2021-07-29 13:58 ` Dave Martin
2021-07-29 14:26 ` Mark Brown [this message]
2021-07-29 14:39 ` Sebastian Andrzej Siewior
2021-07-29 15:37 ` Dave Martin
2021-07-29 10:52 ` [PATCH] arm64/sve: Make kernel FPU protection RT friendly Sebastian Andrzej Siewior
2021-07-29 13:54 ` Dave Martin
2021-07-29 14:17 ` Sebastian Andrzej Siewior
2021-07-29 15:34 ` Dave Martin
2021-07-29 16:00 ` Sebastian Andrzej Siewior
2021-07-29 16:07 ` Sebastian Andrzej Siewior
2021-07-29 16:32 ` Dave Martin
2021-07-29 17:11 ` Sebastian Andrzej Siewior
2021-07-29 14:22 ` Mark Brown
2021-07-29 14:41 ` Sebastian Andrzej Siewior
2021-07-29 16:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729142616.GO4670@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.